From 571956c7f546d84211d955b93d540a992795544a Mon Sep 17 00:00:00 2001 From: Mike Baiocchi Date: Thu, 28 Mar 2019 13:35:28 -0500 Subject: Create Attribute to force UCD Updates This commit adds ATTR_UCD_MFR_REVISION_OVERRIDE such that a user can override the MFR_REVISION seen on a UCD device. This could then force a UCD flash update. Change-Id: I3d807b3ddf2c62752046953f0f3d1754d80da381 RTC:205982 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75179 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Ilya Smirnov Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding --- src/usr/isteps/ucd/updateUcdFlash.C | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) (limited to 'src/usr/isteps/ucd') diff --git a/src/usr/isteps/ucd/updateUcdFlash.C b/src/usr/isteps/ucd/updateUcdFlash.C index 4c90540fe..5648a331f 100644 --- a/src/usr/isteps/ucd/updateUcdFlash.C +++ b/src/usr/isteps/ucd/updateUcdFlash.C @@ -1798,9 +1798,31 @@ errlHndl_t updateAllUcdFlashImages( break; } - if(tocEntry.mfrRevision == mfrRevision) + // If ATTR_UCD_MFR_REVISION_OVERRIDE is non-zero use its value + // instead of tocEntry.mfrRevision + auto mfrRevisionCheck = 0; + auto mfrRevisionOverride = + powerSequencer->getAttr< + TARGETING::ATTR_UCD_MFR_REVISION_OVERRIDE>(); + + if (mfrRevisionOverride != 0) { - TRACFCOMP(g_trac_ucd,INFO_MRK + mfrRevisionCheck = mfrRevisionOverride; + TRACFCOMP(g_trac_ucd,INFO_MRK + "updateAllUcdFlashImages: Using " + "ATTR_UCD_MFR_REVISION_OVERRIDE value of 0x%04X rather " + "than TOC Entry MFR Revision of (0x%04X) for incoming UCD " + "sub-flash image", + mfrRevisionCheck, tocEntry.mfrRevision); + } + else + { + mfrRevisionCheck = tocEntry.mfrRevision; + } + + if(mfrRevisionCheck == mfrRevision) + { + TRACFCOMP(g_trac_ucd,INFO_MRK "updateAllUcdFlashImages: Device has MFR revision of " "0x%04X which matches incoming UCD sub-flash image " "version, so inhibit flash update", @@ -1810,11 +1832,11 @@ errlHndl_t updateAllUcdFlashImages( } else { - TRACFCOMP(g_trac_ucd,INFO_MRK + TRACFCOMP(g_trac_ucd,INFO_MRK "updateAllUcdFlashImages: Device has different MFR revision" " (0x%04X) than the incoming UCD sub-flash image " "version (0x%04X), so perform flash update", - mfrRevision, tocEntry.mfrRevision); + mfrRevision, mfrRevisionCheck); } // Turns out doing the check via UtilMem is not that easy, -- cgit v1.2.1