From be6ed717c7a1de17f3934ed229b64c30f7a9e58b Mon Sep 17 00:00:00 2001 From: Christian Geddes Date: Thu, 28 Jun 2018 16:54:16 -0500 Subject: Only switch sides and perform hreset if SEEPROM side versions match In the event that the SBE fails hostboot will attempt to recover it. During runtime hostboot will attempt an HRESET if the SBE is in a failed state. When the SBE performs the HRESET it will save some important information that will persist through the reset. If one side is failing to recover the retry code will attempt to switch sides and do the hreset. If the SBE seeproms have different versions of the SBE code the data that was supposed to persist through the HRESET will be in incorrect places because the version mismatch. Because of this we cannot switch seeprom sides and perform a hreset if the seeproms have different level of the SBE code. CQ: SW438029 Change-Id: Ic7078a886088cc4d5355cc076e72d0fc36f85027 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/61605 Reviewed-by: Matt Derksen Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell Reviewed-by: William G. Hoffa --- src/include/usr/sbe/sbe_update.H | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'src/include/usr/sbe/sbe_update.H') diff --git a/src/include/usr/sbe/sbe_update.H b/src/include/usr/sbe/sbe_update.H index d907e57c9..f4dc648b7 100644 --- a/src/include/usr/sbe/sbe_update.H +++ b/src/include/usr/sbe/sbe_update.H @@ -541,6 +541,18 @@ namespace SBE const uint64_t i_boundary, uint8_t* o_dst); + /** + * @brief Read the version of code found on each of the SBE's seeproms + * and store values in sbeTargetState_t type + * + * @param[in] io_sbeState Struct holding SBE related information + * @pre it is expected that the member 'target' in the + * sbeTargetState_t struct is set prior to calling this function + * + * @return errlHndl_t if error, nullptr if no error + */ + errlHndl_t getSeepromVersions(sbeTargetState_t& io_sbeState); + /** * @brief Removes ECC from a block of code or data. Removes padding at -- cgit v1.2.1