From 576b16849ca58fcaa2248a59341ba0ea299ddf04 Mon Sep 17 00:00:00 2001
From: Dan Crowell <dcrowell@us.ibm.com>
Date: Tue, 22 Oct 2019 13:37:54 -0500
Subject: Add plug-rule callout to memory vpd lookup failure

If there is a mismatch in the dimm ranks behind a memory port
that will result in a VPD lookup error.  It would be better if
we got a list of the dimms but that isn't how the code is currently
designed.  In lieu of a perfect fix, we will add a procedure
callout that points a memory plugging issue.

Change-Id: I036f002c2145fd1debd957db8f46bc2e23d298f6
CQ: SW477820
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85737
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Marc Gollub <gollub@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85778
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
---
 .../xml/error_info/p9_get_mem_vpd_keyword.xml           | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

(limited to 'src/import')

diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_get_mem_vpd_keyword.xml b/src/import/chips/p9/procedures/xml/error_info/p9_get_mem_vpd_keyword.xml
index 48be558fe..a9372ceda 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_get_mem_vpd_keyword.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_get_mem_vpd_keyword.xml
@@ -5,7 +5,7 @@
 <!--                                                                        -->
 <!-- OpenPOWER HostBoot Project                                             -->
 <!--                                                                        -->
-<!-- Contributors Listed Below - COPYRIGHT 2016,2017                        -->
+<!-- Contributors Listed Below - COPYRIGHT 2016,2019                        -->
 <!-- [+] International Business Machines Corp.                              -->
 <!--                                                                        -->
 <!--                                                                        -->
@@ -128,15 +128,22 @@
     <ffdc>MAPROW8</ffdc>
     <ffdc>MAPROW9</ffdc>
     <!-- Should use a variable ffdc for the rows but that isn't supported -->
+    <!-- Most likely scenario is some bad configs -->
     <callout>
-      <hw>
-        <hwid>VPD_PART</hwid>
-        <refTarget>MCS_TARGET</refTarget>
-      </hw>
+      <procedure>MEMORY_PLUGGING_ERROR</procedure>
       <priority>HIGH</priority>
     </callout>
+    <!-- Next would be a code issue since we have a copy of MEMD in FW -->
     <callout>
       <procedure>CODE</procedure>
+      <priority>MEDIUM</priority>
+    </callout>
+    <!-- Finally it could be downlevel MEMD VPD in the backplane -->
+    <callout>
+      <hw>
+        <hwid>VPD_PART</hwid>
+        <refTarget>MCS_TARGET</refTarget>
+      </hw>
       <priority>LOW</priority>
     </callout>
   </hwpError>
-- 
cgit v1.2.1