From 3b13a6483b18a93d67b36c5a28d07415212a6995 Mon Sep 17 00:00:00 2001 From: "Andre A. Marin" Date: Fri, 26 Apr 2019 16:41:53 -0500 Subject: Add call to setup derived attributes in p9a_mss_eff_config Previously there was some work done to write the functions that do the calculations for these derived attributes but the code was not being called, and one of the functions had an incorrect parameter. This commit addresses both of those issues and also improves on a trace in eff_grouping that made debugging this issue tricky. Change-Id: I8394f1dcc29374afc765668fce79e55f9f823e7d RTC: 207850 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76616 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Reviewed-by: ANDRE A. MARIN Tested-by: Hostboot CI Reviewed-by: Louis Stermole Reviewed-by: STEPHEN GLANCY Reviewed-by: Jennifer A. Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76661 Reviewed-by: Jenkins Server Reviewed-by: Christian R. Geddes Tested-by: Christian R. Geddes --- src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/import/chips/p9a') diff --git a/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C b/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C index 3bbf0ea9f..8a5529734 100644 --- a/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C +++ b/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C @@ -112,6 +112,10 @@ fapi2::ReturnCode p9a_mss_eff_config( const fapi2::Target::set(l_spd_decoder) ); } } + + // Set up derived ATTRS + FAPI_TRY( mss::attr_derived_engine::set(dimm) ); + }// dimm fapi_try_exit: -- cgit v1.2.1