From 64883413fd1982a88735905de136fef6d86ac783 Mon Sep 17 00:00:00 2001 From: Andre Marin Date: Sat, 5 Aug 2017 02:11:38 -0500 Subject: Change tREFI calc to be 99% of calculated result to stay within lab margin Change-Id: Ibafeb05378d9bc0b3e96ab4bb7acac050da9e2dc Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44249 Reviewed-by: Michael D. Pardeik Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: JACOB L. HARVEY Reviewed-by: Jennifer A. Stofer Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44250 Reviewed-by: Hostboot Team Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell --- src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src/import/chips/p9/procedures/hwp') diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C index 76e167e35..7926425a6 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C @@ -799,7 +799,7 @@ fapi2::ReturnCode eff_dimm::dram_trefi() { // Calculate refresh cycle time in nCK & set attribute - constexpr double PERCENT_ADJUST = 0.999; + constexpr double PERCENT_ADJUST = 0.99; std::vector l_mcs_attrs_trefi(PORTS_PER_MCS, 0); uint64_t l_trefi_in_nck = 0; @@ -814,10 +814,11 @@ fapi2::ReturnCode eff_dimm::dram_trefi() l_trefi_in_nck), "Error in calculating tREFI for target %s, with value of l_trefi_in_ps: %d", mss::c_str(iv_dimm), l_trefi_in_ps); - // Per Mike P., requested 99.9% of tREFI calculation to avoid any latency impact and violation of any - // refresh specification (across all number of ranks and frequencies) observed during lab tests. + // Lab requested 99% of tREFI calculation to avoid any latency impact and violation of any + // refresh specification (across all number of ranks and frequencies) observed + // during lab power/thermal tests. - FAPI_INF("For %s, adjusting tREFI calculation by 99.9%, calculated tREFI (nck): %lu, adjusted tREFI (nck): %lu,", + FAPI_INF("For %s, adjusting tREFI calculation by 99%, calculated tREFI (nck): %lu, adjusted tREFI (nck): %lu,", mss::c_str(iv_dimm), l_trefi_in_nck, l_trefi_in_nck * PERCENT_ADJUST); // The compiler does this under the covers but just to be explicit on intent: -- cgit v1.2.1