From 431fd07bcd5f5e17b73c7e82c71be351b0e333f0 Mon Sep 17 00:00:00 2001 From: Prasad Bg Ranganath Date: Thu, 2 May 2019 12:35:23 -0500 Subject: PPB: Bug fix in compute VPD points that impact to bias values - Whenvever there are external freq/volt attribute values present, we consider those value as an additional to the base vpd values.It's basically percentage value that is mentioned in attributes. The bug was we were getting double the value because using the wrong variable for the computation. Change-Id: I5fcbf92b177e7a00fc4b5b3719a48562dbfd0b05 CQ:SW464661 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76879 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: Prem Shanker Jha Reviewed-by: Gregory S. Still Reviewed-by: Jennifer A. Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76895 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell --- src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/import/chips/p9/procedures/hwp/pm') diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C b/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C index 0609ddc8f..0f1a8bdc6 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C @@ -2396,9 +2396,9 @@ void PlatPmPPB::compute_vpd_pts() //BIASED POINTS for (p = 0; p < NUM_OP_POINTS; p++) { - uint32_t l_frequency_mhz = (iv_biased_vpd_pts[p].frequency_mhz); - uint32_t l_vdd_mv = (iv_biased_vpd_pts[p].vdd_mv); - uint32_t l_vcs_mv = (iv_biased_vpd_pts[p].vcs_mv); + uint32_t l_frequency_mhz = (iv_raw_vpd_pts[p].frequency_mhz); + uint32_t l_vdd_mv = (iv_raw_vpd_pts[p].vdd_mv); + uint32_t l_vcs_mv = (iv_raw_vpd_pts[p].vcs_mv); iv_operating_points[VPD_PT_SET_BIASED][p].vdd_mv = bias_adjust_mv(l_vdd_mv, iv_bias[p].vdd_ext_hp); -- cgit v1.2.1