From 17003aae2a9797e990fb2a6869d77967db9c1633 Mon Sep 17 00:00:00 2001 From: Dan Crowell Date: Thu, 17 Nov 2016 15:57:19 -0600 Subject: Improve detection and description for MEMVPD_POS issues Updated attribute description based on changes to requirements Added explicit check for invalid data to improve debug Change-Id: Ie22287166855be1e0d99a52cc4a3ad89d354acfa Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32793 Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: Christian R. Geddes Reviewed-by: Brian R. Silver Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33833 Reviewed-by: Hostboot Team Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell --- .../chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src/import/chips/p9/procedures/hwp/memory') diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H index 9d1f69bba..801f392b4 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H @@ -26460,10 +26460,11 @@ fapi_try_exit: /// @note Generated by gen_accessors.pl generateParameters (NODIM A) /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK /// @note The position of the MCS target's VPD selector data, relative to the EEPROM that -/// contains its data. For systems with a single EEPROM for all chips, this should -/// be equivalent to ATTR_FAPI_POS (the logical MCA position). For systems with an -/// EEPROM per chip, this value should be equivalent to -/// ATTR_CHIP_UNIT_POS. +/// contains its data. The VPD defition supports up to 16 values per EEPROM. For +/// systems with an EEPROM per chip, this value should be equivalent to +/// ATTR_CHIP_UNIT_POS. For systems with a single EEPROM for all chips, the value +/// should follow the physical position in such a way to fit within the 16 available +/// slots. /// inline fapi2::ReturnCode memvpd_pos(const fapi2::Target& i_target, uint8_t& o_value) { -- cgit v1.2.1