From e75b51ba9604d184bf01b5ea7d572ba614d3d2bb Mon Sep 17 00:00:00 2001 From: Louis Stermole Date: Fri, 19 Jan 2018 14:14:57 -0600 Subject: Return failing MCA targets when MSS_CALC_PORT_POWER_EXCEEDS_MAX condition hit Change-Id: I6e2644eda24d6d47bb06cd52640695f64e47c772 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52284 Tested-by: FSP CI Jenkins Reviewed-by: ANDRE A. MARIN Reviewed-by: Michael D. Pardeik Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: Hostboot CI Reviewed-by: STEPHEN GLANCY Reviewed-by: Jennifer A. Stofer Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52295 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Christian R. Geddes --- .../p9/procedures/hwp/memory/p9_mss_utils_to_throttle.C | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'src/import/chips/p9/procedures/hwp/memory/p9_mss_utils_to_throttle.C') diff --git a/src/import/chips/p9/procedures/hwp/memory/p9_mss_utils_to_throttle.C b/src/import/chips/p9/procedures/hwp/memory/p9_mss_utils_to_throttle.C index 76117735b..eccd56532 100644 --- a/src/import/chips/p9/procedures/hwp/memory/p9_mss_utils_to_throttle.C +++ b/src/import/chips/p9/procedures/hwp/memory/p9_mss_utils_to_throttle.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2015,2017 */ +/* Contributors Listed Below - COPYRIGHT 2015,2018 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -30,8 +30,8 @@ /// allowed within a window of M DRAM clocks given the minimum dram data bus utilization. /// -// *HWP HWP Owner: Jacob Harvey -// *HWP HWP Backup: Andre A. Marin +// *HWP HWP Owner: Andre A. Marin +// *HWP HWP Backup: Louis Stermole // *HWP Team: Memory // *HWP Level: 3 // *HWP Consumed by: FSP:HB @@ -71,6 +71,8 @@ extern "C" { FAPI_INF("Entering p9_mss_utils_to_throttle"); + std::vector< fapi2::Target > l_exceeded_power; + for( const auto& l_mcs : i_targets ) { if (mss::count_dimm(l_mcs) == 0) @@ -146,8 +148,9 @@ extern "C" l_n_port) ); } - //equalize throttles to prevent variable performance - FAPI_TRY( mss::power_thermal::equalize_throttles (i_targets, mss::throttle_type::POWER)); + // Equalize throttles to prevent variable performance + // Note that we don't do anything with any MCA that exceed the power limit here, as we don't have an input power limit to go from + FAPI_TRY( mss::power_thermal::equalize_throttles (i_targets, mss::throttle_type::POWER, l_exceeded_power)); fapi_try_exit: return fapi2::current_err; -- cgit v1.2.1