From 533e2008783a3158e4b16393a1b1e92eaf6388b7 Mon Sep 17 00:00:00 2001 From: Tsung Yeung Date: Thu, 18 Jul 2019 16:46:10 -0400 Subject: Stop mcbist during nvdimm restore to prevent broadcast out of sync If mcbist is running during nvdimm restore it could detect UE due to the drams not in the right state and could lead to broadcast out of sycn error Change-Id: I1dbf79fb4b3c66f2100eb3dbe202cfae22d35677 CQ:SW470102 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80645 Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: STEPHEN GLANCY Reviewed-by: Louis Stermole Tested-by: FSP CI Jenkins Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80666 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M Crowell --- .../chips/p9/procedures/hwp/memory/lib/dimm/ddr4/nvdimm_utils.C | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/import/chips/p9/procedures/hwp/memory/lib') diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/nvdimm_utils.C b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/nvdimm_utils.C index 8b49ad80f..9178379dd 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/nvdimm_utils.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/nvdimm_utils.C @@ -266,10 +266,14 @@ template<> fapi2::ReturnCode self_refresh_entry( const fapi2::Target& i_target ) { fapi2::buffer l_mbarpc0_data, l_mbastr0_data; + const auto& l_mcbist = mss::find_target(i_target); // Entry time to 0 for immediate entry constexpr uint64_t l_str_entry_time = 0; + // Stop mcbist (scrub) in case of MPIPL. It will get restarted in the later istep + FAPI_TRY(mss::mcbist::start_stop(l_mcbist, mss::states::STOP)); + // Step 1 - In MBARPC0Q, disable power domain control, set domain to MAXALL_MIN0, // and disable minimum domain reduction (allow immediate entry of STR) FAPI_TRY(mss::mc::read_mbarpc0(i_target, l_mbarpc0_data)); -- cgit v1.2.1