From de35db8a7994cf356e76bedefe27e5190f63b77a Mon Sep 17 00:00:00 2001 From: Stephen Glancy Date: Mon, 22 Jul 2019 10:16:46 -0400 Subject: Fixes MCBIST ecc/spare data pattern bug MCBIST wasn't setting up the ecc/spare DRAM's data pattern registers. This commit fixes that bug by taking the first byte of data and putting it into the ecc/spare data registers Change-Id: I5cdda1de8d123ff5f3bb991a2182c5027abb4f29 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80769 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Hostboot CI Tested-by: HWSV CI Reviewed-by: Mark Pizzutillo Reviewed-by: Louis Stermole Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80790 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Christian R Geddes --- .../p9/procedures/hwp/memory/lib/mcbist/mcbist.H | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/mcbist') diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/mcbist.H b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/mcbist.H index 80c5eab20..02f3a2ba5 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/mcbist.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/mcbist.H @@ -126,6 +126,28 @@ fapi2::ReturnCode setup_broadcast_port_select(const fapi2::Target& i_target, template< mss::mc_type MC = DEFAULT_MC_TYPE, fapi2::TargetType T > fapi2::ReturnCode enable_broadcast_mode(const fapi2::Target& i_target, mcbist::program<>& io_program); +/// +/// @brief Load MCBIST ECC (and?) spare data pattern given a pattern - explorer specialization +/// @param[in] i_target the target to effect +/// @param[in] i_pattern an mcbist::patterns +/// @param[in] i_invert whether to invert the pattern or not +/// @note this overload disappears when we have real patterns. +/// @return FAPI2_RC_SUCCSS iff ok +/// +template< > +inline fapi2::ReturnCode load_eccspare_pattern( + const fapi2::Target& i_target, + const pattern& i_pattern, + const bool i_invert ) +{ + // First up assemble the pattern + const auto l_pattern = generate_eccspare_pattern(i_pattern, i_invert); + + FAPI_TRY(fapi2::putScom(i_target, MCBIST_MCBFDQ, l_pattern)); + +fapi_try_exit: + return fapi2::current_err; +} } // namespace MCBIST } // namespace mss -- cgit v1.2.1