From c96464c7d52540eda875ac62082f1ebf24de3f72 Mon Sep 17 00:00:00 2001 From: Stephen Glancy Date: Mon, 18 Feb 2019 10:25:11 -0500 Subject: Moves set bad bitmap into generic Change-Id: I0c9e8beb0e4cd930ebccbf26d1e8149b64fae65d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72154 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Dev-Ready: STEPHEN GLANCY Reviewed-by: ANDRE A. MARIN Reviewed-by: Louis Stermole Tested-by: HWSV CI Tested-by: Hostboot CI Reviewed-by: Jennifer A. Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72163 Reviewed-by: Daniel M. Crowell Tested-by: Daniel M. Crowell --- src/import/chips/p9/procedures/hwp/memory/lib/mc/port.C | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/mc/port.C') diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mc/port.C b/src/import/chips/p9/procedures/hwp/memory/lib/mc/port.C index 75d15c1d1..5c1433bbe 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mc/port.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mc/port.C @@ -403,11 +403,10 @@ fapi_try_exit: /// @param[out] o_repairs_exceeded 2-bit mask, where a bit set means a DIMM had more bad bits than could be repaired (bit0-1 = DIMM0-1) /// @return FAPI2_RC_SUCCESS if and only if ok /// -// TODO RTC:157753 Template parameters here are Nimbus specific. Convert to attribute/trait of TARGET_TYPE_MCA when traits are created. template<> -fapi2::ReturnCode restore_repairs_helper( +fapi2::ReturnCode restore_repairs_helper( const fapi2::Target& i_target, - const uint8_t i_bad_bits[MAX_RANK_PER_DIMM][BAD_DQ_BYTE_COUNT], + const uint8_t i_bad_bits[BAD_BITS_RANKS][BAD_DQ_BYTE_COUNT], fapi2::buffer& o_repairs_applied, fapi2::buffer& o_repairs_exceeded) { @@ -476,7 +475,7 @@ fapi2::ReturnCode restore_repairs( const fapi2::Target& fapi2::buffer& o_repairs_applied, fapi2::buffer& o_repairs_exceeded) { - uint8_t l_bad_bits[MAX_RANK_PER_DIMM][BAD_DQ_BYTE_COUNT] = {}; + uint8_t l_bad_bits[BAD_BITS_RANKS][BAD_DQ_BYTE_COUNT] = {}; o_repairs_applied = 0; o_repairs_exceeded = 0; @@ -485,7 +484,7 @@ fapi2::ReturnCode restore_repairs( const fapi2::Target& { FAPI_TRY( mss::bad_dq_bitmap(l_dimm, &(l_bad_bits[0][0])) ); - FAPI_TRY( (restore_repairs_helper( + FAPI_TRY( (restore_repairs_helper( l_dimm, l_bad_bits, o_repairs_applied, o_repairs_exceeded)) ); } -- cgit v1.2.1