From 78426ddee158cfed3e45f837900aba01f1dd109d Mon Sep 17 00:00:00 2001 From: Stephen Glancy Date: Tue, 12 Nov 2019 15:57:48 -0500 Subject: Disables broadcast mode in memdiags::continue_cmd Broadcast mode at runtime can cause issues. memdiags::continue_cmd is called at runtime, so disabling the broadcast mode check will fix an NVDIMM runtime bug. Change-Id: Ib13ad0bf46c44aa26a6df39ffabc507348a1a14e CQ:SW480744 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86898 Reviewed-by: Mark Pizzutillo Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: Louis Stermole Reviewed-by: Zane C Shelley Reviewed-by: Caleb N Palmer Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86912 Reviewed-by: Jenkins Server Reviewed-by: Daniel M Crowell Tested-by: Daniel M Crowell --- src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H b/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H index dfb6b495b..efd2e9bd9 100644 --- a/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H +++ b/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H @@ -1103,8 +1103,12 @@ fapi2::ReturnCode continue_cmd( const fapi2::Target& i_target, // Read-modify-write the fields in the program. FAPI_TRY( mss::getScom(i_target, TT::MCBAGRAQ_REG, l_program.iv_addr_gen) ); - // Configure broadcast mode if needed - FAPI_TRY(mss::mcbist::configure_broadcast_mode(i_target, l_program)); + // Note: we are specifically not configuring broadcast mode here + // The continue command is called by PRD exclusively at mainline + // If we're at mainline, we can't run in broadcast mode + // If we ever need to call continue elsewhere, we'll need to do the following + // 1) add the function to configure broadcast mode + // 2) add in a switch to disable broadcast mode if we're at runtime l_program.change_end_boundary(i_end); -- cgit v1.2.1