summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Add check to see if BPM is connected before attempting UpdatesMatthew Raybuck2019-10-021-92/+111
| | | | | | | | | | | | | | | | | | | | The BPM update procedure didn't first verify if there were any BPMs present and enabled before attempting updates. This lead to misleading error logs. With this commit, the code will first check if there are BPMs present and enabled before attempting the update. If not, then the appropriate error will be created. Change-Id: I7b46b7748a5eed0e5a95affe364f8573643b25d0 CQ:SW476941 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84224 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84598 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Fix ThreadPool Memory CorruptionIlya Smirnov2019-10-021-4/+4
| | | | | | | | | | | | | | | | | | | One of the functions that ends up being called by threads spun by ThreadPool has a potential memory corruption where a vector of data structures can be searched while it's being populated by two different threads. This commit changes the positions of mutex lock and ulock calls in the vicinity to protect the population and search of the vector. Change-Id: Ic1a5eb8928c1133ee2a99e2d9c04607be3c41b15 CQ: SW476649 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84561 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Attempt to unlock encryption in NVDIMM Arm functionCorey Swenson2019-10-022-1/+55
| | | | | | | | | | | | | | | | | Ensure encryption is unlocked when NVDIMM is armed at runtime. Failure to unlock will generate additional Arm error and prevent Arm from continuing. CQ:SW477075 Change-Id: I7f97a6b8d574562d4e4abeb256020df5433d3a5f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84559 Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed portabiliy issue in pre-commit hookZane Shelley2019-10-021-1/+1
| | | | | | | | | | | | | | A change was previously applied to pre-commit via 1d4530dac35 that included a bashism that is not portable with other shells. Change-Id: I0ab536005973627953e1a3b4fa41f51963a953ea Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84413 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Luis P Fernandez <luis.fernandez@ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: boolean logic error in Axone chnl fail codeZane Shelley2019-10-011-1/+1
| | | | | | | | | | | | Change-Id: I34c98635fb6bc5ac600639474b2a91c7a4a5309c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84498 Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84595 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Increase hostboot standalone timeout to be 75 minutesChristian Geddes2019-10-011-2/+8
| | | | | | | | | | | | | | | | We were seeing normal CIs take 56 minutes which was exceeding the existing 50 minute timeout. This increase is due the adding a 2nd proc to the axone simics xml and the addition of axone related tests. Change-Id: I0fa1f2ce93efab47e4ccb7d81a13cf293b3ed5b0 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84549 Reviewed-by: DANIEL J LARSON <dlarson@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add NVDIMM node controller readme textMatt Derksen2019-10-011-0/+77
| | | | | | | | | | | | | | | Add some description of how the NVDIMM node controller's firmware is updated. Change-Id: I8ee3f7d2e84536bfb127178cd41dcb7460362797 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84356 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Hostboot platform support for Explorer inband commands via i2cMatt Derksen2019-09-307-32/+481
| | | | | | | | | | | | | | | | | | | | Inband SRAM can be accessed via scom i2c commands. To Explorer, a register address and an internal memory address are the same thing. That allows us to execute the inband command set even if the OMI link is not active. A new attribute determinds when this inband i2c is required so it can be an easy override for lab use. By default, this i2c path will not execute when OMI links are working. Change-Id: I3f18cf78d2e88e33935f1bd241ef4e2796d36d93 RTC: 208447 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83787 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Skip hardware delays when running in SimicsDan Crowell2019-09-301-1/+7
| | | | | | | | | | | | | | | | | | There are sometimes delays in HWPs due to hardware delays that need to be accounted for. When we're running in Simics there is no reason to wait because the hardware works instantly (in non- modeled time). Removing these extra delays can have a huge benefit on the total runtime because there is a multiplicative penalty between real time and simulated time. Change-Id: I4f581ad2c028f250ed3fea00cc924e028f3d22d3 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84439 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* PRD: Add threshold for stopping on UEs/CEs during BgScrubCaleb Palmer2019-09-304-16/+103
| | | | | | | | | | | | | | Change-Id: Iddeec04300631fc57b5c2f4a2eb57302e9f98fe2 CQ: SW476467 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84071 Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84073 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Add new DDR4 DDIMM keyword ENTIRE_SPD_WITHOUT_EFDChristian Geddes2019-09-275-22/+23
| | | | | | | | | | | | | | | | | | | | With the DDR4 DDIMM SPD there are really two parts. There is the 640 bytes of information you typically see in a DIMM's SPD and then there are 2 KB - 640 bytes of EFD (extensible function descriptors) to give vendors space to add customized data. In many cases we want the ENTIRE_SPD (including the EFD area) but in other cases we want to save some time/space and only read in the first 640 bytes. This new keyword will give us that flexibility. Change-Id: I88ed58b37417b576f2ec4a779ee0c114791c6c21 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84070 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Matthew Raybuck <matthew.raybuck@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed error handling issues in arm pathMATTHEW I. HICKMAN2019-09-275-121/+155
| | | | | | | | | | | | Addresses the following: 1. nvdimms not getting disarmed in error cases 2. nvdimms getting garded on BPM-specific errors Change-Id: Ibf9b391cb94c1dd247406f960298a1e55ebf186f CQ:SW475860 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84061 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed NOT_ENOUGH_ENERGY_FOR_CSAVE checkMATTHEW I. HICKMAN2019-09-271-1/+1
| | | | | | | | | | | | CQ:SW476011 Change-Id: I17c82bece187c216e29a7c0acb58a50c62c6e016 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83800 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add support for new pmic sequencing SPD fieldsMark Pizzutillo2019-09-2714-240/+480
| | | | | | | | | | | | | | | | Change-Id: I8847090585161375fbb2c0ef853cffed80a67cc3 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82961 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83375 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Add blank files for exp_omi_train_check procedureMark Pizzutillo2019-09-274-0/+98
| | | | | | | | | | | | | | | | | | The new ordering of the omi train/setup procedures means that nothing will check the final status of the OMI training from the explorer side. We will use this procedure in the same way that p9a_omi_train does Change-Id: I225aa55205e008eceb0389a3a7fdb74b76dd7307 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84180 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84222 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Fix dmb_revision size in ddimm_get_efdMark Pizzutillo2019-09-271-5/+3
| | | | | | | | | | | | | | | | Change-Id: I159682143e4c8f65d9a154fc3ebc6e0cedbf34b4 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84131 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Dev-Ready: Mark Pizzutillo <mark.pizzutillo@ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84147 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Fixes explorer accessor bugsStephen Glancy2019-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | Bugs fixed 1) updates the Update delay line command to be 0x22 2) updates number of lanes based upon if there is a spare byte Change-Id: I93f1c12c8111a752631ed7a274f5befd2e824453 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83833 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83954 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* PM: Modified FFDC to avoid corruption of RC in error path.Prem Shanker Jha2019-09-271-11/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On FSP platform, in case of some errors, HWP captures certain EX level registers. To ensure availability of such registers, FSP first attempts special wakeup. Special wakeup HWP uses FAPI_TRY in its code path. It is known that in FFDC collection path, use of FAPI_TRY leads to corruption of original FAPI2 RC. Commit removes such registers from the capture list. Key_Cronus_Test=PM_REGRESS Change-Id: I23ce8b1a8a4a61f71c7b33c1122fcfac905616c4 CQ: SW471606 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83863 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Gregory S Still <stillgs@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com> Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com> Reviewed-by: AMIT J. TENDOLKAR <amit.tendolkar@in.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83958 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Fixed the restore status flag bugMATTHEW I. HICKMAN2019-09-272-4/+6
| | | | | | | | | | | | Change-Id: Ia3c7b138964a7b09bb258c1539f7d9c9d957a69d CQ:SW475473 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83981 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Update TweaksMatthew Raybuck2019-09-271-15/+15
| | | | | | | | | | | | | | | Adds procedure and part callouts where necessary and updates some comments. Change-Id: Ia94add82b7ccbafc11243452d616898133297ecd RTC:215466 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83535 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added additional erase error handlingMATTHEW I. HICKMAN2019-09-273-5/+94
| | | | | | | | | | | | CQ:SW476620 Change-Id: I5fb983405d7d9c0bf58f5e45dfbcfb0a3435a89f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84069 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: fix Explorer FSI address workaround in FIRDATA codeZane Shelley2019-09-271-5/+5
| | | | | | | | | | | | | | | | | | | There was a previous workaround to stub out filling in the FSI address for Explorer in the FIRDATA code for checkstop analysis. That workaround would fill in the FSI address for processor chips before initializing the structure that contains the FSI address. Therefore, the FSI address for processors would always get initialized to 0xffffffff. The fix is to simply put the code in the correct order. Change-Id: Id76ec015ffec1565236481fcc14be6c1a3145d28 CQ: SW474413 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84369 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
* PRD: Initial Axone Channel Fail supportCaleb Palmer2019-09-2710-45/+813
| | | | | | | | | | | | | Change-Id: I1a86cd97e2188409a1fbcc2fd8981ad5e162214f RTC: 212714 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83667 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84365 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: add virtual destructor to ScomRegister classZane Shelley2019-09-271-0/+3
| | | | | | | | | | | | | | Change-Id: I6f8c9bc98d87ed48fa23c73dfb168121d36ca3ea Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84042 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84364 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Make snprintf always terminate the output bufferZach Clark2019-09-271-6/+24
| | | | | | | | | | | | | | | | | | | | | | Previously, the snprintf function would not terminate the output buffer if it had already filled the entire buffer with characters. This would lead to the creation of unterminated strings which could result in buffer overreads and/or information disclosures. This commit fixes that issue, making it conform to the C99 standard (section 7.19.6.5). Also addresses a buffer underflow that could occur when the source string to an sprintf call contains too many \b characters. Change-Id: Ie516b1c7d74d37cc5f48fe03693f096fe4bd6c02 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84349 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* PRD: NVDIMM workaround for ES TEMP glitchesCaleb Palmer2019-09-272-16/+66
| | | | | | | | | | | | | | | | | | | | | | There is currently a glitch with the energy source temperature readings. We are getting intermittent incorrect readings for the temperature that is causing us to analyze to an ES temperature warning or error because of these glitched readings. This is a workaround to make the ES temp logs hidden until we hit threshold. The fix for the root cause of the glitches will need to come from SMART. Change-Id: I8df3f2531fda2e4c0273bfe3714c7efb9662971d CQ: SW476951 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84345 Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84363 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Fix race condition in BufferPage allocation functionZach Clark2019-09-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BufferPage::claimEntry implements a lockfree algorithm to allocate space for trace messages within a single page of memory. In performing the bounds check for the allocation, a local copy of a member variable is created, and a compare-and-swap strategy is used to update the member variable with the new size of the allocated portion of the buffer. However, in the bounds check, the member variable was mistakenly used, rather than the local copy. This leads to a race condition where if the member variable is updated in memory by another thread between the time that its value is loaded from memory for the bounds check and loaded again for the local variable, the bounds check can succeed when it should fail and the allocation can go beyond the bounds of the page owned by the BufferPage object. This issue manifests only when the claimEntry function is compiled by GCC (versions 4.9.2 and 8.2.0 tested) with size optimization (-Os) because at this level, the compiler emits two load instructions for the value of the member variable. Using -O3, only a single load instruction is emitted and so the race condition is averted. Change-Id: I89fbffee9806972bab410c4bc75022a33793b453 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84284 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Disable OMI deconfig testsChristian Geddes2019-09-261-1/+1
| | | | | | | | | | | | | | | | | | These tests cannot run as part of the standard test suite as they disrupt targeting expectations from other tests that are running in parallel. Currently we are seeing other tests cases that use the OMI/OCMB targets to fail intermittently because targets are missing. Change-Id: Id152e6f571465fee22bae5789eb9a92643738d4b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84250 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Support EXP_FW_LOG command to get Explorer Firmware logsMatt Derksen2019-09-2513-10/+1047
| | | | | | | | | | | | | | | | | Includes framework to add explorer error logs to an error. Tests the ekb RC path and the hostboot way to add these logs. Tests are disabled until simics supports the new command. Change-Id: I03b735342251b6c9e078a3e5b412e5a9f88e1e6b RTC:205128 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82362 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Support EXP_FW_LOG command to get Explorer FW logsMatt Derksen2019-09-259-5/+794
| | | | | | | | | | | | Framework to send inband command and a proof of concept adding explorer error log data via collectFfdc RC. Change-Id: I41be5598eb6fb3239fd933e0a0563d1a99ed2fa0 RTC:205128 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82372 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed pre-req check during NVDimm ArmMATTHEW I. HICKMAN2019-09-251-1/+61
| | | | | | | | | | | | CQ:SW475280 Change-Id: I15634923e18dfecb18146e9ec33ed128111f517c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83484 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed several Arm error handling bugsMATTHEW I. HICKMAN2019-09-256-15/+43
| | | | | | | | | | | | CQ:SW475445 Change-Id: I19cd03850b65a23d2a35c9160352cdc7a4946667 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83534 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Merging of Serverwiz and hostboot repo Targets.pmGiridhari Krishnan2019-09-251-1/+37
| | | | | | | | | | | | | file, so to have a common version at start. This common version is pulled to hostboot repo for use. Change-Id: I2024fb0a344375ac1d4705a9b9a7b77f2dc774ab Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82062 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Remove Unused clearPoreBars function in Istep 21.3Bill Hoffa2019-09-251-94/+1
| | | | | | | | | | | | | | | | - This functionality was never used so remove it Change-Id: I2885be14c4bbf68e322a8a52f9364210e6943ca9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84183 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Add a ReadMe to explain high level BPM Update ProcessMatthew Raybuck2019-09-241-0/+147
| | | | | | | | | | | | | | | | | | Adds a readme to explain some of the background info, the update process, and point out the various files that the BPM update process relies on to succeed. Change-Id: I572f8789eab231d4f97e53eb7bfb8e7f94c2cc42 RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82675 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Double the NVDIMM_READY timeout to prevent erroneous errorTsung Yeung2019-09-241-2/+2
| | | | | | | | | | | | | | | | NVDIMM controller POR or firmware induced reset time may vary from run-to-run. Doubling the timeout here in case of edge condition. Change-Id: I717dfbef9b2903e8bb1e7aed92c28df1fab90033 CQ:SW476597 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84107 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add wrapper to exp_getidec HWP so we can call it in platform codeChristian Geddes2019-09-207-1/+191
| | | | | | | | | | | | | | | | | | | | | There has been a trend to create more HWPs that process raw data. This allows Hostboot and Cronus to share more code. The trick is that we generally want to call these HWPs inside traditionally hostboot-only code. This new fapiwrap directory will help encapsulate all of the calls to ekb code in one place. That way if we ever need to remove HWPs/EKB code it will be easier to stub out the calls. In the past we have contaminated a lot of Hostboot-only code with calls out to EKB code. This new new directory should help avoid this issue. Change-Id: I2b2d0d1e62c97f0976c9c9ede3fe2eac30c7a40f RTC: 214627 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83029 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: Lane repair OMI bus callout changesCaleb Palmer2019-09-192-17/+26
| | | | | | | | | | | | | Change-Id: I6c282e0d3db63df2bb9badbf717f75aff16e6c4e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83666 Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84008 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: Fix UNIT_CS analysis in OCMB chiplet FIRCaleb Palmer2019-09-191-1/+1
| | | | | | | | | | | | | | Change-Id: I1237a42d416cca9aac9014bcffe38ac138632d9d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83665 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84007 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Enable SMF tests for AxoneDan Crowell2019-09-192-7/+17
| | | | | | | | | | | | | | | | Need to take multiple chips into account when computing the values to compare with. Change-Id: Ie423b2afec126f6e69590584631da9b6d6657a84 RTC: 206800 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83560 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Fixed several small bugs found via code reviewMATTHEW I. HICKMAN2019-09-196-97/+152
| | | | | | | | | | | CQ:SW474830 Change-Id: I1ff22805b9bb3facf68d4d62ea66de169be9b98b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83213 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Patch For: Implement Static Analysis with cppcheckLuis Fernandez2019-09-181-38/+33
| | | | | | | | | | | | | | | CPPCHECK commands fail in machines that do not use bin/sh. Wrap commands inside an if-statement to only be read when User explicitly run the tool. Change-Id: Ifad56b0978c8190efa033203f661daf9259a4d43 RTC: 201451 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83938 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: NVDIMM keep log hidden if no error found during analysisCaleb Palmer2019-09-182-18/+39
| | | | | | | | | | | | | Change-Id: I56d3444b2b9a87e34ce03da9a7a805cdc629d573 CQ: SW476229 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83930 Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
* Dummy commit to prime hwsv for new Explorer FFDC collectionMatt Derksen2019-09-181-0/+55
| | | | | | | | | | | | | | | | | | A new procedure is coming to grab Explorer Firmware Logs. This requires a new file to be mirrored to hwsv so ffdc_includes.H can be updated. Change-Id: Ia2c11d3273eb27e37bc7dc92d6b7059fe1ec679a RTC:205128 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83398 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83715 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Add blank files for p9a_omi_setup procedureMark Pizzutillo2019-09-183-0/+72
| | | | | | | | | | | | | | | Change-Id: I1fb1c9d35b12cb46107d2b6f90587dfc0f2a058f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83740 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83839 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Update explorer scom header files with newer figtree data.Ben Gass2019-09-178-7159/+7413
| | | | | | | | | | | | | | | | | Change-Id: I2ba7df5fdd7f532f9ad5c2fca202849d443bfea9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83277 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83427 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Add Printk Traces to ThreadPool Unit TestsIlya Smirnov2019-09-161-0/+3
| | | | | | | | | | | | | | | | | | Some ThreadPool unit tests that test crashed tasks were missing printk logs to indicate the crashes were expected. This creates confusion when debugging printk logs. This commit adds the traces to indicate the crashes are expected and are part of the test. Change-Id: I38d2d886cfd73106e32fb4e461bba3d5a39a8032 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83783 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Update axone pnor layout to move eecache to the beginingChristian Geddes2019-09-162-9/+11
| | | | | | | | | | | | | | | | | Because we rely on having a stable offset for the EECACHE section of pnor we will move it to the start of the pnor layout. This will make it less likely to move around as now we are auto-adjusting offsets if sections like HBI happen to exceed to allotted space. Change-Id: I4463c9d1cfb6ba86c777c976f911b14be5a483e3 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83791 Reviewed-by: Zachary Clark <zach@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add pmic_i2c_addr_get function for platform code useMark Pizzutillo2019-09-161-0/+82
| | | | | | | | | | | | | Change-Id: I79b5bcc1ce8de9066aa87e793d38fab64752f17f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83033 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83735 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Skip OCMB targets while decidng what targets to process for IpmiFruInvChristian Geddes2019-09-161-2/+7
| | | | | | | | | | | | | | | Some targets types will not have IPMI fru inventory classes associated with them, attempting to process them will result in an assert. Change-Id: I34cb080c981ac5d0008eb937c127e043ff077a27 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83433 Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
OpenPOWER on IntegriCloud