summaryrefslogtreecommitdiffstats
path: root/src/usr
Commit message (Collapse)AuthorAgeFilesLines
...
* Support scoms to MEM_PORT targetsDan Crowell2019-10-282-10/+145
| | | | | | | | | | | | | | | | | | Some of the memory HWPs require MEM_PORT scom support for Explorer. There is no address translation required but we need to allow the scoms to occur. Added testcase paths to scom MEM_PORT targets. Change-Id: I00b29e8dda6a105e994a5dcd009fd4b8aebdbdef Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85690 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Don't consider processor's OMI freq if it is 0 when freq restrictionsChristian Geddes2019-10-251-3/+5
| | | | | | | | | | | | | | | | | | We have been told that processors must run at the same OMI frequency. During bringup we saw that if the first boot was done with one of the processors guarded out, and that processor was later unguarded. We would fail the check that ensures these frequencies are the same, because the proc that was guarded/unguarded would still be 0 where the other would be set. This change will allow us to ignore processors with unset frequency so we can boot far enough to set it. Later on the rule will be enforced as well on subsequent boots. Change-Id: I23950371f6f65750aacb07b28317ba11a3a4e8ab Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85832 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Re-enable NV_STATUS notification for OpalCorey Swenson2019-10-251-9/+3
| | | | | | | | | | | | | | Change-Id: Ie577faad36e6799a347e24c8ff32b80f0e2c7719 RTC:213292 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85100 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Call cronus version of memdiags for explorer until prd version worksChristian Geddes2019-10-252-0/+35
| | | | | | | | | | | | | | | | | | There are some delays in getting the attention driven memory diagnostics code up and running. In the mean time we will use the memory diagnostics HWP that cronus uses. This will allow us to init the system without any bootscripts. Eventually, after we get the correct fir settings, we will enable PRD's version of memory diagnostics and remove the cronus version. Change-Id: I6b9b5ff8f32983487a7b811a82a515d9da9502d9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85863 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Update Part Number field side for DDR4 DDIMM spd layoutChristian Geddes2019-10-251-1/+1
| | | | | | | | | | | | | | | | Originally we had this set to 0x30 (48) bytes but now it seems the spec says its only 0x1E (30) bytes. This commit update to the new value that the spec is indicating. Change-Id: I3ba643411a51fdd0df731119dce371bd16435944 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85432 Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Set endianess attributes in hb_customized_attrs instead of in codeChristian Geddes2019-10-222-13/+20
| | | | | | | | | | | | When we first detected we needed to have these attributes differerent than what the EKB had we set them in the call_mss_eff_config istep code. Really these should be set in the hb_customized_attrs xml. Change-Id: I7166a25c53330bf90e423b0e4de718b95344bfb7 RTC: 202491 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85443 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add attribute to explicitly force OCMB Firmware update behaviorDan Crowell2019-10-213-3/+77
| | | | | | | | | | | | | | | | | | Allow us to override the default behavior (update when versions don't match) via an attribute. The options will be: - Update if versions do not match - Never update - Always update - Do the version check but don't actually update the code Change-Id: I5fdaa3cd2adf4cfb96f7ad7568de5d2c083d276c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85180 Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Remove unused procedure p9a_mss_eff_config_thermalLouis Stermole2019-10-182-433/+293
| | | | | | | | | | | | | | | | Change-Id: Ib848efb56534b484abfd7f5ebedde0895c941519 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82289 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82343 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Reorganize omi training steps accounting for new omi training hwpsChristian Geddes2019-10-174-99/+201
| | | | | | | | | | | | | | | | | | | | | | | | A few new steps have been added that were found to be required for explorer power on. The correct steps of the OMI training need to be dmi_pre_trainadv: - exp_omi_setup - p9a_omi_setup dmi_io_run_training: - exp_omi_train (skip on gemini) - p9a_omi_train dmi_post_trainadv: - exp_omi_train_check (skip on gemini) - p9a_omi_train_check Change-Id: I90a3c2dfb1bec8983d38e0d4810753154651e452 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85289 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Automatically set VPD cache flags based on EEPROM cache settingDan Crowell2019-10-171-0/+13
| | | | | | | | | | | | | | | | Added more logic to the vpd/HBconfig file to force the correct (use hardware) values for the VPD code if the EECACHE flag (SUPPORT_EEPROM_CACHING) is set. This allows the system config files to not include the unused VPD flags anymore. Change-Id: I87f7c5f3e51e3121c081b3007164dbf21cbafba8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84757 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Dynamically generate ocmb cmd/rsp seq idChen Du2019-10-163-0/+53
| | | | | | | | | | | | | | | | | | | The current procedure code is using the sequence id portion of the FW message to indicate the type of the command rather than the command number. This makes error handling very difficult because we can't detect which ocmb we are accessing when we detect a failure. Create a function backed ekb attribute to hold the sequence id so that every time we retrieve this attribute, we increment the valuwe on the next get. Change-Id: I93e0e7062d01ddf7ba6a69f89411a5b6bcf01471 RTC: 210371 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78767 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix invalid use of vector iteratorGlenn Miles2019-10-161-3/+6
| | | | | | | | | | | | | | | | | | | Once an element of a vector is erased using an iterator, that iterator should be considered invalid and not used. The accepted practice is to update the iterator with the return value of the erase method and not to increment the iterator. CQ: SW465848 Change-Id: If6ec7887d8c2b6c6ad44a9608c474b9c118bd117 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85220 Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Do nothing with error logs after shutdown event is received.Glenn Miles2019-10-151-0/+28
| | | | | | | | | | | | | | | | | | Disable processing of error logs by the error log server after receiving the shutdown event. This is to prevent the possibility of bad things from happening once other services are shutdown. CQ: SW465848 Change-Id: I59c4951182d43a78f5704b4b4c3379f10dd03182 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85278 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: OCMB handling for checkstop analysis pathCaleb Palmer2019-10-143-35/+54
| | | | | | | | | | | | | | Change-Id: I708d59f8bbf732edac4ee77e9885bf287cdf03d8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85020 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85204 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Add OMI bus support to calloutsDan Crowell2019-10-103-0/+9
| | | | | | | | | | | | | | | | Fill in a few spots where we need to handle OMI busses for proper error processing and display. Change-Id: Ibf236a7f6cb894d1516dbbe49b57e5be7dcceca2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84952 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Prevent pre-3.0 level NVDIMMs from being in systemsMatt Derksen2019-10-091-3/+7
| | | | | | | | | | | | | | | Do not want these non-updateable NVDIMMs to be used. Change-Id: Ia045257d101fc249d65b2d0af6194f8f3aa1e9dc CQ: SW477628 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84729 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM Erase error handle not working in IPL Arm handlingMatt Derksen2019-10-092-12/+3
| | | | | | | | | | | | | | | | | | | | NVDIMM erase error handling is failing because nvdimmDisarm() checks ATTR_NVDIMM_ARMED before disarming the nvdimm. Disarming an nvdimm that is already disarmed should not be harmful. Also erase error should correctly set the error status as 0x01 (memory unable to preserve future content) Change-Id: I8a710343478691c87f1570fd30074c2543d3373c CQ: SW477541 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84662 Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Add support for DMI-MEMBUF bus failures to fapiDan Crowell2019-10-071-0/+7
| | | | | | | | | | | | | | | | | | | I noticed this error message the other day - processEIBusCallouts - Bus between target types not known (0x00000027:0x00000004) The effect of this is that we don't end up with the bus error procedure getting added to the error log like it should be. Change-Id: Iecc5f6df2f9c6812d70c5ea66ad0f46dc9bb2694 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83671 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Create error for unsuspected target in configureHbrtHypIdsMatt Derksen2019-10-071-7/+47
| | | | | | | | | | | | | | | | | Specifically check for all expected types. Create an error if an unsuspected type is encountered. Also use the const for error logs which just add software callout. Change-Id: Ie1b35945ee7c580dd70d3c97c68184a22fb6ced5 RTC:210321 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82225 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: Axone Two Phase Scrub (TPS) supportCaleb Palmer2019-10-042-1054/+196
| | | | | | | | | | | | | | Change-Id: If2540907b7ceb51612b0a68142d54836b89f1e13 RTC: 208263 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84537 Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84783 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* PRD: Axone VCM UpdatesCaleb Palmer2019-10-043-174/+84
| | | | | | | | | | | | | | Change-Id: I9c54c9d8ae01186785bf4a773f6a9ea5d0d311fb RTC: 208262 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84233 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84782 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: Axone UE/CE threshold for background scrubCaleb Palmer2019-10-044-20/+100
| | | | | | | | | | | | | Change-Id: I2872ee94a385d84b10a6e0aaf7f3c0a95c496aa0 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84551 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84781 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* PRD: Add additional FFDC to runtime NVDIMM analysisCaleb Palmer2019-10-043-5/+74
| | | | | | | | | | | | | | Change-Id: I7472a883a27c30315c01f2722f98fe40d42c1070 CQ: SW476683 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84181 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84182 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Add nvdimm arm retry logic in case of glitchesTsung Yeung2019-10-041-88/+193
| | | | | | | | | | | | | | | | | Random BPM glitches could cause temporary persistency lost and failing the arm command. Allow arm retry if glitch only persisted for a second or less. Change-Id: I28e65b05e482129f6fea34580064a825923aaaf3 CQ:SW477211 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84668 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
* PRD: Fix returning port position in dynamic mem deallocCaleb Palmer2019-10-031-4/+4
| | | | | | | | | | | | | Change-Id: Ib128e038b84c6a9aafd692c43611cadf25b582b8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84602 Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84657 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Add call to fapi wrapper of exp_getidec into hwasPlat codeChristian Geddes2019-10-031-84/+65
| | | | | | | | | | | | | | | | | | | | | | The file hwasPlat.C contains the code we use to lookup and compare the IDEC information of a given OCMB when read from the card's SPD versus what is read from the card's defined registers. Recently the code that looks up the IDEC from the card's registers was made into a HWP so it could be leveraged by multiple platforms. A new wrapper has been created on the hostboot side in src/usr/fapiwrap/ that provides an interface for the hostboot platform to call in order to leverage the new EKB hwp. Change-Id: I9155767b199c9b197c010521f33cc0d418901628 RTC: 214627 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83109 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Verify manufacture date (MB) from PVPD before usinglixg2019-10-031-35/+57
| | | | | | | | | | | | | | | | | | If the contents of the MB keyword is invalid, we could end up doing some illegal math and causing a crash. This change will add some simple verification of the data before we use it. Resolves #183 Change-Id: I2f3ead87be24e909a671f54f6005f3fffdbafd52 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84441 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* errl: Free memory allocated for parsersArtem Senichev2019-10-031-1/+3
| | | | | | | | | | | | | | | | | Errl's factory creates new instance of User Defined Data parser on every call, but doesn't free it after usage. Resolves #184 Signed-off-by: Artem Senichev <a.senichev@yadro.com> Change-Id: I8e8bd54e7aaa4ddb813cec3485404b6ba7a29ffa Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84518 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* errl: Fix data reading from unaligned pointersArtem Senichev2019-10-036-26/+117
| | | | | | | | | | | | | | | | | | | | | | Some architectures (like an ARM used in OpenBMC) do not support unaligned memory access. On these systems, reading an integral value from an unaligned pointer leads to undefined behavior. This patch doesn't change existing functionality, but forces the compiler to generate extra instructions to satisfy architectural alignment requirements. Resolves #185 Signed-off-by: Artem Senichev <a.senichev@yadro.com> Change-Id: I6e75044b93c26cca76336d17bb3886fab403253a Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84520 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Compile Hostboot with -OsDean Sanner2019-10-033-8/+8
| | | | | | | | | | | | | | | | | | | Hostboot currently spends a significant percentage of time loading data from PNOR across a relatively slow LPC bus. This commit enables compilation of Hostboot with -Os, optimized for space to reduce the amount of data required to be transferred across the LPC bus Rough measurements show a ~30% size reduction of the hostboot image and a ~10% reduction (improvement) in boot time Change-Id: Ib73863019595a24cc7d10e924bc5c92cd64af1ed Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84436 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Add check to see if BPM is connected before attempting UpdatesMatthew Raybuck2019-10-021-92/+111
| | | | | | | | | | | | | | | | | | | | The BPM update procedure didn't first verify if there were any BPMs present and enabled before attempting updates. This lead to misleading error logs. With this commit, the code will first check if there are BPMs present and enabled before attempting the update. If not, then the appropriate error will be created. Change-Id: I7b46b7748a5eed0e5a95affe364f8573643b25d0 CQ:SW476941 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84224 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84598 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Fix ThreadPool Memory CorruptionIlya Smirnov2019-10-021-4/+4
| | | | | | | | | | | | | | | | | | | One of the functions that ends up being called by threads spun by ThreadPool has a potential memory corruption where a vector of data structures can be searched while it's being populated by two different threads. This commit changes the positions of mutex lock and ulock calls in the vicinity to protect the population and search of the vector. Change-Id: Ic1a5eb8928c1133ee2a99e2d9c04607be3c41b15 CQ: SW476649 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84561 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Attempt to unlock encryption in NVDIMM Arm functionCorey Swenson2019-10-021-1/+53
| | | | | | | | | | | | | | | | | Ensure encryption is unlocked when NVDIMM is armed at runtime. Failure to unlock will generate additional Arm error and prevent Arm from continuing. CQ:SW477075 Change-Id: I7f97a6b8d574562d4e4abeb256020df5433d3a5f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84559 Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: boolean logic error in Axone chnl fail codeZane Shelley2019-10-011-1/+1
| | | | | | | | | | | | Change-Id: I34c98635fb6bc5ac600639474b2a91c7a4a5309c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84498 Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84595 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Add NVDIMM node controller readme textMatt Derksen2019-10-011-0/+77
| | | | | | | | | | | | | | | Add some description of how the NVDIMM node controller's firmware is updated. Change-Id: I8ee3f7d2e84536bfb127178cd41dcb7460362797 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84356 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Hostboot platform support for Explorer inband commands via i2cMatt Derksen2019-09-306-32/+478
| | | | | | | | | | | | | | | | | | | | Inband SRAM can be accessed via scom i2c commands. To Explorer, a register address and an internal memory address are the same thing. That allows us to execute the inband command set even if the OMI link is not active. A new attribute determinds when this inband i2c is required so it can be an easy override for lab use. By default, this i2c path will not execute when OMI links are working. Change-Id: I3f18cf78d2e88e33935f1bd241ef4e2796d36d93 RTC: 208447 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83787 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Skip hardware delays when running in SimicsDan Crowell2019-09-301-1/+7
| | | | | | | | | | | | | | | | | | There are sometimes delays in HWPs due to hardware delays that need to be accounted for. When we're running in Simics there is no reason to wait because the hardware works instantly (in non- modeled time). Removing these extra delays can have a huge benefit on the total runtime because there is a multiplicative penalty between real time and simulated time. Change-Id: I4f581ad2c028f250ed3fea00cc924e028f3d22d3 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84439 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* PRD: Add threshold for stopping on UEs/CEs during BgScrubCaleb Palmer2019-09-304-16/+103
| | | | | | | | | | | | | | Change-Id: Iddeec04300631fc57b5c2f4a2eb57302e9f98fe2 CQ: SW476467 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84071 Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84073 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Add new DDR4 DDIMM keyword ENTIRE_SPD_WITHOUT_EFDChristian Geddes2019-09-274-21/+16
| | | | | | | | | | | | | | | | | | | | With the DDR4 DDIMM SPD there are really two parts. There is the 640 bytes of information you typically see in a DIMM's SPD and then there are 2 KB - 640 bytes of EFD (extensible function descriptors) to give vendors space to add customized data. In many cases we want the ENTIRE_SPD (including the EFD area) but in other cases we want to save some time/space and only read in the first 640 bytes. This new keyword will give us that flexibility. Change-Id: I88ed58b37417b576f2ec4a779ee0c114791c6c21 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84070 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Matthew Raybuck <matthew.raybuck@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed error handling issues in arm pathMATTHEW I. HICKMAN2019-09-274-121/+153
| | | | | | | | | | | | Addresses the following: 1. nvdimms not getting disarmed in error cases 2. nvdimms getting garded on BPM-specific errors Change-Id: Ibf9b391cb94c1dd247406f960298a1e55ebf186f CQ:SW475860 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84061 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed NOT_ENOUGH_ENERGY_FOR_CSAVE checkMATTHEW I. HICKMAN2019-09-271-1/+1
| | | | | | | | | | | | CQ:SW476011 Change-Id: I17c82bece187c216e29a7c0acb58a50c62c6e016 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83800 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed the restore status flag bugMATTHEW I. HICKMAN2019-09-272-4/+6
| | | | | | | | | | | | Change-Id: Ia3c7b138964a7b09bb258c1539f7d9c9d957a69d CQ:SW475473 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83981 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Update TweaksMatthew Raybuck2019-09-271-15/+15
| | | | | | | | | | | | | | | Adds procedure and part callouts where necessary and updates some comments. Change-Id: Ia94add82b7ccbafc11243452d616898133297ecd RTC:215466 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83535 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added additional erase error handlingMATTHEW I. HICKMAN2019-09-272-5/+93
| | | | | | | | | | | | CQ:SW476620 Change-Id: I5fb983405d7d9c0bf58f5e45dfbcfb0a3435a89f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84069 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: fix Explorer FSI address workaround in FIRDATA codeZane Shelley2019-09-271-5/+5
| | | | | | | | | | | | | | | | | | | There was a previous workaround to stub out filling in the FSI address for Explorer in the FIRDATA code for checkstop analysis. That workaround would fill in the FSI address for processor chips before initializing the structure that contains the FSI address. Therefore, the FSI address for processors would always get initialized to 0xffffffff. The fix is to simply put the code in the correct order. Change-Id: Id76ec015ffec1565236481fcc14be6c1a3145d28 CQ: SW474413 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84369 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
* PRD: Initial Axone Channel Fail supportCaleb Palmer2019-09-2710-45/+813
| | | | | | | | | | | | | Change-Id: I1a86cd97e2188409a1fbcc2fd8981ad5e162214f RTC: 212714 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83667 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84365 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: add virtual destructor to ScomRegister classZane Shelley2019-09-271-0/+3
| | | | | | | | | | | | | | Change-Id: I6f8c9bc98d87ed48fa23c73dfb168121d36ca3ea Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84042 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84364 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: NVDIMM workaround for ES TEMP glitchesCaleb Palmer2019-09-272-16/+66
| | | | | | | | | | | | | | | | | | | | | | There is currently a glitch with the energy source temperature readings. We are getting intermittent incorrect readings for the temperature that is causing us to analyze to an ES temperature warning or error because of these glitched readings. This is a workaround to make the ES temp logs hidden until we hit threshold. The fix for the root cause of the glitches will need to come from SMART. Change-Id: I8df3f2531fda2e4c0273bfe3714c7efb9662971d CQ: SW476951 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84345 Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84363 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Fix race condition in BufferPage allocation functionZach Clark2019-09-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BufferPage::claimEntry implements a lockfree algorithm to allocate space for trace messages within a single page of memory. In performing the bounds check for the allocation, a local copy of a member variable is created, and a compare-and-swap strategy is used to update the member variable with the new size of the allocated portion of the buffer. However, in the bounds check, the member variable was mistakenly used, rather than the local copy. This leads to a race condition where if the member variable is updated in memory by another thread between the time that its value is loaded from memory for the bounds check and loaded again for the local variable, the bounds check can succeed when it should fail and the allocation can go beyond the bounds of the page owned by the BufferPage object. This issue manifests only when the claimEntry function is compiled by GCC (versions 4.9.2 and 8.2.0 tested) with size optimization (-Os) because at this level, the compiler emits two load instructions for the value of the member variable. Using -O3, only a single load instruction is emitted and so the race condition is averted. Change-Id: I89fbffee9806972bab410c4bc75022a33793b453 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84284 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Disable OMI deconfig testsChristian Geddes2019-09-261-1/+1
| | | | | | | | | | | | | | | | | | These tests cannot run as part of the standard test suite as they disrupt targeting expectations from other tests that are running in parallel. Currently we are seeing other tests cases that use the OMI/OCMB targets to fail intermittently because targets are missing. Change-Id: Id152e6f571465fee22bae5789eb9a92643738d4b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84250 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
OpenPOWER on IntegriCloud