summaryrefslogtreecommitdiffstats
path: root/src/usr/isteps
Commit message (Collapse)AuthorAgeFilesLines
...
* Add NVDIMM node controller readme textMatt Derksen2019-10-011-0/+77
| | | | | | | | | | | | | | | Add some description of how the NVDIMM node controller's firmware is updated. Change-Id: I8ee3f7d2e84536bfb127178cd41dcb7460362797 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84356 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed error handling issues in arm pathMATTHEW I. HICKMAN2019-09-274-121/+153
| | | | | | | | | | | | Addresses the following: 1. nvdimms not getting disarmed in error cases 2. nvdimms getting garded on BPM-specific errors Change-Id: Ibf9b391cb94c1dd247406f960298a1e55ebf186f CQ:SW475860 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84061 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed NOT_ENOUGH_ENERGY_FOR_CSAVE checkMATTHEW I. HICKMAN2019-09-271-1/+1
| | | | | | | | | | | | CQ:SW476011 Change-Id: I17c82bece187c216e29a7c0acb58a50c62c6e016 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83800 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed the restore status flag bugMATTHEW I. HICKMAN2019-09-272-4/+6
| | | | | | | | | | | | Change-Id: Ia3c7b138964a7b09bb258c1539f7d9c9d957a69d CQ:SW475473 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83981 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Update TweaksMatthew Raybuck2019-09-271-15/+15
| | | | | | | | | | | | | | | Adds procedure and part callouts where necessary and updates some comments. Change-Id: Ia94add82b7ccbafc11243452d616898133297ecd RTC:215466 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83535 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added additional erase error handlingMATTHEW I. HICKMAN2019-09-272-5/+93
| | | | | | | | | | | | CQ:SW476620 Change-Id: I5fb983405d7d9c0bf58f5e45dfbcfb0a3435a89f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84069 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed pre-req check during NVDimm ArmMATTHEW I. HICKMAN2019-09-251-1/+61
| | | | | | | | | | | | CQ:SW475280 Change-Id: I15634923e18dfecb18146e9ec33ed128111f517c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83484 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed several Arm error handling bugsMATTHEW I. HICKMAN2019-09-256-15/+43
| | | | | | | | | | | | CQ:SW475445 Change-Id: I19cd03850b65a23d2a35c9160352cdc7a4946667 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83534 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Remove Unused clearPoreBars function in Istep 21.3Bill Hoffa2019-09-251-94/+1
| | | | | | | | | | | | | | | | - This functionality was never used so remove it Change-Id: I2885be14c4bbf68e322a8a52f9364210e6943ca9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84183 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Add a ReadMe to explain high level BPM Update ProcessMatthew Raybuck2019-09-241-0/+147
| | | | | | | | | | | | | | | | | | Adds a readme to explain some of the background info, the update process, and point out the various files that the BPM update process relies on to succeed. Change-Id: I572f8789eab231d4f97e53eb7bfb8e7f94c2cc42 RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82675 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Double the NVDIMM_READY timeout to prevent erroneous errorTsung Yeung2019-09-241-2/+2
| | | | | | | | | | | | | | | | NVDIMM controller POR or firmware induced reset time may vary from run-to-run. Doubling the timeout here in case of edge condition. Change-Id: I717dfbef9b2903e8bb1e7aed92c28df1fab90033 CQ:SW476597 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84107 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed several small bugs found via code reviewMATTHEW I. HICKMAN2019-09-194-95/+148
| | | | | | | | | | | CQ:SW474830 Change-Id: I1ff22805b9bb3facf68d4d62ea66de169be9b98b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83213 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Changed the callout in the call NVM Health Status to be an NVDIMMRoland Veloz2019-09-161-17/+48
| | | | | | | | | | | | | | | | | | | | | | | In the call nvDimmNvmCheckHealthStatus, the call is incorrectly using HB when it should be associated with NVDIMM. Switched out the addPartCallout with HWAS::BPM_PART_TYPE to a addHwCallout with the given NVDIMM. Also added more trace info to print out the registers that are being retrieved. Corrected the logic such that a good state passes. Apparently, the way the code was written, a good or bad state, both would fail. Now the good state passes and the bad state fails. Change-Id: I46b62ce3fe5c5ac86efb501e2a91fdea8160b9b5 CQ: SW475265 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83673 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix bad arguments to additional FFDC capture in BPM Update codeMatthew Raybuck2019-09-142-67/+99
| | | | | | | | | | | | | | | | In bpm_update.C there were two places where the wrong errl was being given as a parameter to FFDC functions. The errl supplied was nullptr causing hostboot to crash as a result. This commit fixes that by suppling the correct errl. Change-Id: I50e8459d2b3602177ca740059a706613402c3e95 RTC:212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83781 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM: FW_UPDATE: New FFDC for SECURITY_ERRORCorey Swenson2019-09-132-1/+73
| | | | | | | | | | | | | | | For any command error or timeout during FW_UPDATE add regs to error log. Registers specified in NVDIMM IPL Error Handling Document. CQ:SW473060 Change-Id: I3ca8933b9c62f0b12bebefbae06357400e8e436e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83590 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add vendor log data to FFDC for all NVDIMM HW errorsCorey Swenson2019-09-134-0/+701
| | | | | | | | | | | | | Read vendor log data from NVDIMM Do checksum compare Add to error log as string Change-Id: I41a295bf54d031c978b59fe1f59c98507fbeec81 CQ:SW473585 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83383 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Apply MC_HANG timeout workaround to all processorsChristian Geddes2019-09-131-59/+45
| | | | | | | | | | | | | | | | When we initially added this workaround for whatever reason we specified the master proc only. It needs to be applied to all procesors in the system. Change-Id: I5840f2b0670f1790393a385f045ee656ad76bef8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83594 Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM: Additional FFDC for NVDIMM/BPM calloutsCorey Swenson2019-09-125-1/+148
| | | | | | | | | | | | Add page 4 SMART regs to error log FFDC for all NVDIMM HW errors. Add attribute to prevent recursively executing the function. Change-Id: I2cdd89436a2647c440f900a729596b522829aca6 CQ:SW470690 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82599 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Re-enable mss_scrub in istep16 for axone systemsChristian Geddes2019-09-121-8/+0
| | | | | | | | | | | | | | | | This step was disabled during bringup. Workarounds in place now so we can call it again. Change-Id: I6aaaf77173cdcf45771f1072fcab67b09546da86 RTC: 213933 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83200 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add exp_mss_eff_config_thermal call to istep7 for AxoneMatt Derksen2019-09-122-292/+435
| | | | | | | | | | | | | | | | This adds the procedure call along with removing unneccesary calls based on system type. Change-Id: I869b25246f32472246bd4cd5bf31080db68a7e39 RTC:208847 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82666 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Updates: Move NVDIMM controller reset and final fw check to end of updateMatthew Raybuck2019-09-111-75/+83
| | | | | | | | | | Change-Id: I54832f6197e620885b1506b47af248132173eba4 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83480 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix misleading trace output for BPM attribute overridesMatthew Raybuck2019-09-101-6/+24
| | | | | | | | | | | | | | | | The traces would indicate that the SKIP attribute override was enabled in some circumstances when it wasn't. This could lead to confusion about why BPM updates didn't occur. Change-Id: Ib577d5fe322266b300f622e9c9095e36dc69c5d1 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83122 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Updates: Extend the reset device wait to 15 seconds from 10Matthew Raybuck2019-09-101-2/+4
| | | | | | | | | | | | | | | | | There was an issue where the BPM reset wait was set to 10 seconds which would sometimes lead to SCAP timeouts. By setting it to 15 seconds, the issue goes away by giving the BPM more time to come back online after a reset command is sent. Change-Id: I3c20657ef976f13fb6636b280c7cc95195a24d53 RTC:215466 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83482 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Final solution for Axone HCODE lid idDan Crowell2019-09-091-9/+17
| | | | | | | | | | | | | | | | | Axone can just reuse the lid number that is assigned to Nimbus since it is only used to map to a common PNOR partition. There is never a real lid load done with this value. Change-Id: I7e1c2cc5f3f76e28b35dfd11e02a0af62c239c1b RTC: 214257 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83138 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added code to support doing an NVM health checkRoland Veloz2019-09-032-117/+596
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added a method that will do an NVM (non-volatile memory) health check. In particular this method will check the flash error counts and does a predictive callout if the number of flash error counts exceeds the maximum allowed. This method also checks the bad block percentage and does a predictive callout if the number of bad block percentage exceeds the maximum allowed. A predictive callout is done if either or both fail the check. Added support in the runtime commands to make the nvm health check call as well. Also, when I did the ES (energy source) health check method, I was not very explicit in the method that it was doing an ES health check. So I updated the verbiage in the nvDimmCheckHealthStatus to add ES wherever appropriate as to make these two method explicit as to what health check is being performed. Change-Id: Ib9925fd2bb8430cf2121108329247d96072beb1b CQ: 473220 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82843 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Compile new ioo_dl_npu_scominit HWP so its ready to useChristian Geddes2019-08-301-0/+1
| | | | | | | | Change-Id: I3267ab77f3a802b27a8bd0a03418804c0202e628 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83096 Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Fix for offset traces due to merge bugMATTHEW I. HICKMAN2019-08-291-4/+0
| | | | | | | | | | | Change-Id: Ied920772272b025952f82dcc918dfe59d679cc1b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83028 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add more FFDC to BPM Update Error logsMatthew Raybuck2019-08-281-6/+144
| | | | | | | | | | | | | | | | | | Adds part callouts for all BPM related error logs and collects BPM traces for any errors that are returned from interactions with the NVDIMM to provide context. Additionally, if there is an error during the config updates the code will erase the firmware section to force an update on any subsequent attempt. Change-Id: I045b4ba1feea2fbc1ddb5e418bf60b86d6c11bb1 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82946 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix lingering error log issues for BPM updatesMatthew Raybuck2019-08-282-77/+260
| | | | | | | | | | | | | | | | | There was a lingering issue where an error that was retryable was thought to be non-retryable. This propagated out of blockWrite() causing the update to think it had failed when it fact it had not. Change-Id: I536e79ddd4ac476fdf1aa0b370f81f4b0b198f4c RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82614 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added security bit and fir handling, gard and trace fixesMATTHEW I. HICKMAN2019-08-277-113/+273
| | | | | | | | | | | Change-Id: I8160d9662859232dfd612b3a2f5c1c522c02e308 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82534 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add call to exp_mss_thermal_init to step 14.2Andre Marin2019-08-272-7/+14
| | | | | | | | | | | Change-Id: I85b34168b8a93ea8c744b6a79f207ce924cdf50f RTC:195557 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79326 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add Encryption Enabled bit to NV_STATUS_FLAGCorey Swenson2019-08-271-4/+38
| | | | | | | | | | | | | | | | | | - 0x10: Contents are encrypted Set when encryption is enabled Clear when encryption is disabled Attribute comments should match HDAT Change-Id: I52805f6c8c3f303ce29cf8b8534304dfd0a09821 RTC:214625 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82638 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Replaces nvdimmWrite() to reset controller with nvdimmResetController()Tsung Yeung2019-08-261-3/+3
| | | | | | | | | | | | | | | nvdimmResetController() will call nvdimm_encrypt_unlock() to unlock encryption if needed. Without it nvdimm ops could fail on runtime Change-Id: Iad4c4d354d3b9522ee0544b5c8de7484dcf89c6c CQ:SW474050 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82838 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix restore fail due to restore attempt on empty flashTsung Yeung2019-08-264-71/+87
| | | | | | | | | | | | | | | -fix NVDIMM FFDC misalignment -correct NV_STATUS enum naming Change-Id: Ib0084f5fb95ce8a93ee5e85a0790878469065acb CQ:SW473934 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82775 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM: Load warning thresholds, after FW_UPDATE, on every IPLCorey Swenson2019-08-262-0/+112
| | | | | | | | | | | | | | | | See defect for register list and hard-coded values Change-Id: Ibc32ddfcb4719388dd744aa946df62e27066a05c CQ:SW472435 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82348 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Update SBE In Istep7.5 In SMF ModeIlya Smirnov2019-08-231-1/+31
| | | | | | | | | | | | | | | | | | | | | A bug was discovered on OpenPOWER systems wherein if SMF is enabled, we would checkstop in istep10.1 when trying to XSCOM to the slave proc. The issue was that SBE at that time didn't know we were booting in SMF mode and so didn't set up the XSCOM BAR for the slave proc appropriately. The solution is to force SBE update in istep7.5 if SMF is enabled in the MRW (ATTR_SMF_CONFIG) but SBE doesn't yet know about that (bit 16 in scratch reg6 is not set). Change-Id: Ibaa2d1e5b441f378528443aa84e5cd61789792dd Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81950 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* In regards to health check errors, removed the software calloutRoland Veloz2019-08-211-4/+4
| | | | | | | | | | | | | | | | | Software callouts, ADD_SW_CALLOUT, where added to the error logs for errors associated with the health check status when they should not have. Changed them to NO_SW_CALLOUT. Change-Id: Iccf5289a38053aa3eccaa59b200a99fa1f14f83b CQ: SW473391 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82540 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Enable BPM UpdatesMatthew Raybuck2019-08-202-395/+881
| | | | | | | | | | | | | | | | This commit turns on BPM updates and fixes several issues that were preventing them from occuring successfully. Change-Id: I2aa544c59f04fcc06bf7f10bdff5026579d7f053 RTC:212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82487 Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix NVDIMM update error log commentsCorey Swenson2019-08-201-17/+17
| | | | | | | | | | | | | | First line of error log comment must include /*@ or error log will not be documented. Also fixed in other HB files. Change-Id: Ifa5eba6d6abd7f8565a4cc8d62a25a2b833725f2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82497 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix retry failure in nvdimmWriteData()Matt Derksen2019-08-191-3/+6
| | | | | | | | | | | | | | | | Need to create a local variable for i_dataLen, because deviceOp will alter the i_dataLen value on failure (ie NACK). Change-Id: If73efb77a1ba918fbc1bb7decd8fb46a5d2014b9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82344 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Matthew Raybuck <matthew.raybuck@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add attribute to force/skip BPM updatesMatthew Raybuck2019-08-191-7/+72
| | | | | | | | | | | | | | | | | Adds a new attribute ATTR_BPM_UPDATE_OVERRIDE to override the default update behavior. Updates can be forced, skipped, and the firmware and config portion of the updates can be individually forced or skipped. Change-Id: I1d50ab60d18a0511466f1551108755ef9f70cf35 RTC:212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82263 Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Correct BPM update flow to match SMARTs flowMatthew Raybuck2019-08-192-170/+540
| | | | | | | | | | | | | | | | | | Corrects the update flow for the BPM to match the flow given by SMART. This commit also pulls out the firmware and config update procedures into their own functions as well as fix a few bugs in the verifyBlockWrite function. Change-Id: Ia7950078112e1ad54ef63594efa010b06460513a RTC:212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82219 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add code to run BPM update procedure from nvdimm_update.CMatthew Raybuck2019-08-192-21/+187
| | | | | | | | | | | | | | | | | Adds the necessary code to hook the existing BPM update code into istep 21. The BPM update will be called in nvdimm_update.C after the nvdimm updates have occurred. Change-Id: If968313433bfdfbbbb929874de6eb0bf4d21b241 RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79640 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added error checking and handling to nvdimm iplMatthew Hickman2019-08-1912-233/+2372
| | | | | | | | | | | | Change-Id: I153cf39cc674b49441b5f41f7b96cd667b2a265b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/77543 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Skip Alternate PNOR Validation on alt-master proc if lpc init failsBill Hoffa2019-08-191-7/+12
| | | | | | | | | | | | | | | | | | - It is expected that the alt pnor validation step will fail if lpc init fails so this step should be skipped. The errors from lpc init are committed so that is already handled. Change-Id: I07ab852abd986d743bad86040ea9b13479926501 CQ: SW465693 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78345 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Call new p9a_throttle_sync procedureMatt Derksen2019-08-142-9/+26
| | | | | | | | | | | | | | | Should be called just like the old p9_throttle_sync but specific to Axone. Change-Id: I08c39ecae6453e527482f7e498e44131b4222894 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80237 Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Do not unload modules loaded for unit testsChristian Geddes2019-08-131-56/+3
| | | | | | | | | | | | | | | | | | | | | | | | For some of the unit tests we must load in .so modules that were unloaded during the boot. Modules must get loaded and unloaded during the boot, especially before we expand from cache containment to over come size limitations. We were seeing issues were test case A and B both relied on a module and attempted to load it when the test case was instantiated then tried to unload the module when the test case was completed. This was causing issues if two tests were using the same loaded module and one test finished early and unloaded it. Test cases are run on simics after memory is expanded so there is no reason unload the extra modules we load in so we will leave them loaded. Change-Id: Ia41d38da11400f54ee2e59e497b9610ac24f1629 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82099 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Move exp_inband to lib directoryMark Pizzutillo2019-08-112-1/+2
| | | | | | | | | | | | | | | Change-Id: If494c330ce20f6ec96ded6194d705e908198cf8b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81882 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81886 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Only compare a proc's omi freq if it has functional OCMB childrenChristian Geddes2019-08-091-72/+11
| | | | | | | | | | | | | | | | | | There are checks we do during the memory intialization where we check to make sure that both processors have the same frequence set for their OMI traffic. If a processor has no OCMB targets then its OMI frequence will not get set so we should ignore those processors for this comparison. Change-Id: Id00f01756b431695e92a15872ebe00fd18306c4f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81462 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add workaround to ignore MC channel hangs for Swift bringupChristian Geddes2019-08-092-2/+70
| | | | | | | | | | | | | | | | | Using the gemini cards we have been detecting channel hangs which are actually just a result of the gemini cards being slow. To work around this for now we will disable the channel hang checks for the memory controller. Change-Id: Ic21dca4c207140fab8d91b5f1f1a20e6670494cc Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81471 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
OpenPOWER on IntegriCloud