summaryrefslogtreecommitdiffstats
path: root/src/usr/isteps
Commit message (Collapse)AuthorAgeFilesLines
* Adjust deadman timeout request time to be 10.5 secondsChristian Geddes2019-11-061-2/+3
| | | | | | | | | | | | | | | | | | | | | We see intermittent deadman timeouts occuring in our testing. Upon further inspection it was determined that value we were passing to the SBE was being cast to a uint32_t and multiplied by up to a factor of 400000 , which was resulting in an overflow of the uint32_t. This was giving us a timeout lower than desired. This commit lowers the requested timeout to be 10.5 seconds which will not overflow the uint32_t. Change-Id: I747db46a5d4a99d273b5604971d3db51f077be50 CQ: SW477557 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86513 Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Slot check after firmware updateMatt Derksen2019-11-054-11/+146
| | | | | | | | | | | | | | | | | | Verify every NVDIMM is running from slot 1 and is at the latest firmware version. Create a predictive error for those that are not running latest code level. Change-Id: I46766d267f4a1293739a49c989ef5ab7dde585b5 CQ:SW478561 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85656 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM FW update region write retryMatt Derksen2019-11-052-16/+61
| | | | | | | | | | | | | | | | | | Retry writing a region of code if the checksums do not match. Retry up to 3 times per region. Second of two commits for this defect. CQ:SW469894 Change-Id: Id3cbd71a2930a2dc19532b3b5c87f692dde447cd Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80360 Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM update - Clear FW Ops Status verificationMatt Derksen2019-11-052-7/+115
| | | | | | | | | | | | | | | | | | | SMART is recommending after 0x41=0x02 (Clear FW Ops Status) that the IBM utility read 0x71 to verify that the OPS_SUCCESS and OPS_ERROR bits have been cleared and that only Bit 2 (FIRMWARE_UPDATE_MODE) is set. First of two fixes for SW469894 Change-Id: Id9e9d7fa5abd5bcd3bae806b27332513f48956b2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83946 Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Only call memdiags on Explorer ocmb chipsChristian Geddes2019-10-311-9/+15
| | | | | | | | | | | | | | | | | | We should only call memdiags on the Explorer ocmb chips because it will fail if we attempt to call it on the Gemini chips. Gemini chips will boot fine without this step being called. Change-Id: I50645db29b17d4dc93de9c1e5f7b419e5dea6f0d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86159 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Re-enable NV_STATUS notification for OpalCorey Swenson2019-10-251-9/+3
| | | | | | | | | | | | | | Change-Id: Ie577faad36e6799a347e24c8ff32b80f0e2c7719 RTC:213292 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85100 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Call cronus version of memdiags for explorer until prd version worksChristian Geddes2019-10-252-0/+35
| | | | | | | | | | | | | | | | | | There are some delays in getting the attention driven memory diagnostics code up and running. In the mean time we will use the memory diagnostics HWP that cronus uses. This will allow us to init the system without any bootscripts. Eventually, after we get the correct fir settings, we will enable PRD's version of memory diagnostics and remove the cronus version. Change-Id: I6b9b5ff8f32983487a7b811a82a515d9da9502d9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85863 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Set endianess attributes in hb_customized_attrs instead of in codeChristian Geddes2019-10-221-7/+0
| | | | | | | | | | | | When we first detected we needed to have these attributes differerent than what the EKB had we set them in the call_mss_eff_config istep code. Really these should be set in the hb_customized_attrs xml. Change-Id: I7166a25c53330bf90e423b0e4de718b95344bfb7 RTC: 202491 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85443 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add attribute to explicitly force OCMB Firmware update behaviorDan Crowell2019-10-211-3/+32
| | | | | | | | | | | | | | | | | | Allow us to override the default behavior (update when versions don't match) via an attribute. The options will be: - Update if versions do not match - Never update - Always update - Do the version check but don't actually update the code Change-Id: I5fdaa3cd2adf4cfb96f7ad7568de5d2c083d276c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85180 Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Remove unused procedure p9a_mss_eff_config_thermalLouis Stermole2019-10-182-433/+293
| | | | | | | | | | | | | | | | Change-Id: Ib848efb56534b484abfd7f5ebedde0895c941519 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82289 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82343 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Reorganize omi training steps accounting for new omi training hwpsChristian Geddes2019-10-174-99/+201
| | | | | | | | | | | | | | | | | | | | | | | | A few new steps have been added that were found to be required for explorer power on. The correct steps of the OMI training need to be dmi_pre_trainadv: - exp_omi_setup - p9a_omi_setup dmi_io_run_training: - exp_omi_train (skip on gemini) - p9a_omi_train dmi_post_trainadv: - exp_omi_train_check (skip on gemini) - p9a_omi_train_check Change-Id: I90a3c2dfb1bec8983d38e0d4810753154651e452 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85289 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Prevent pre-3.0 level NVDIMMs from being in systemsMatt Derksen2019-10-091-3/+7
| | | | | | | | | | | | | | | Do not want these non-updateable NVDIMMs to be used. Change-Id: Ia045257d101fc249d65b2d0af6194f8f3aa1e9dc CQ: SW477628 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84729 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM Erase error handle not working in IPL Arm handlingMatt Derksen2019-10-092-12/+3
| | | | | | | | | | | | | | | | | | | | NVDIMM erase error handling is failing because nvdimmDisarm() checks ATTR_NVDIMM_ARMED before disarming the nvdimm. Disarming an nvdimm that is already disarmed should not be harmful. Also erase error should correctly set the error status as 0x01 (memory unable to preserve future content) Change-Id: I8a710343478691c87f1570fd30074c2543d3373c CQ: SW477541 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84662 Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Add nvdimm arm retry logic in case of glitchesTsung Yeung2019-10-041-88/+193
| | | | | | | | | | | | | | | | | Random BPM glitches could cause temporary persistency lost and failing the arm command. Allow arm retry if glitch only persisted for a second or less. Change-Id: I28e65b05e482129f6fea34580064a825923aaaf3 CQ:SW477211 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84668 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
* Compile Hostboot with -OsDean Sanner2019-10-032-2/+2
| | | | | | | | | | | | | | | | | | | Hostboot currently spends a significant percentage of time loading data from PNOR across a relatively slow LPC bus. This commit enables compilation of Hostboot with -Os, optimized for space to reduce the amount of data required to be transferred across the LPC bus Rough measurements show a ~30% size reduction of the hostboot image and a ~10% reduction (improvement) in boot time Change-Id: Ib73863019595a24cc7d10e924bc5c92cd64af1ed Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84436 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Add check to see if BPM is connected before attempting UpdatesMatthew Raybuck2019-10-021-92/+111
| | | | | | | | | | | | | | | | | | | | The BPM update procedure didn't first verify if there were any BPMs present and enabled before attempting updates. This lead to misleading error logs. With this commit, the code will first check if there are BPMs present and enabled before attempting the update. If not, then the appropriate error will be created. Change-Id: I7b46b7748a5eed0e5a95affe364f8573643b25d0 CQ:SW476941 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84224 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84598 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Attempt to unlock encryption in NVDIMM Arm functionCorey Swenson2019-10-021-1/+53
| | | | | | | | | | | | | | | | | Ensure encryption is unlocked when NVDIMM is armed at runtime. Failure to unlock will generate additional Arm error and prevent Arm from continuing. CQ:SW477075 Change-Id: I7f97a6b8d574562d4e4abeb256020df5433d3a5f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84559 Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add NVDIMM node controller readme textMatt Derksen2019-10-011-0/+77
| | | | | | | | | | | | | | | Add some description of how the NVDIMM node controller's firmware is updated. Change-Id: I8ee3f7d2e84536bfb127178cd41dcb7460362797 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84356 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed error handling issues in arm pathMATTHEW I. HICKMAN2019-09-274-121/+153
| | | | | | | | | | | | Addresses the following: 1. nvdimms not getting disarmed in error cases 2. nvdimms getting garded on BPM-specific errors Change-Id: Ibf9b391cb94c1dd247406f960298a1e55ebf186f CQ:SW475860 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84061 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed NOT_ENOUGH_ENERGY_FOR_CSAVE checkMATTHEW I. HICKMAN2019-09-271-1/+1
| | | | | | | | | | | | CQ:SW476011 Change-Id: I17c82bece187c216e29a7c0acb58a50c62c6e016 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83800 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed the restore status flag bugMATTHEW I. HICKMAN2019-09-272-4/+6
| | | | | | | | | | | | Change-Id: Ia3c7b138964a7b09bb258c1539f7d9c9d957a69d CQ:SW475473 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83981 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Update TweaksMatthew Raybuck2019-09-271-15/+15
| | | | | | | | | | | | | | | Adds procedure and part callouts where necessary and updates some comments. Change-Id: Ia94add82b7ccbafc11243452d616898133297ecd RTC:215466 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83535 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added additional erase error handlingMATTHEW I. HICKMAN2019-09-272-5/+93
| | | | | | | | | | | | CQ:SW476620 Change-Id: I5fb983405d7d9c0bf58f5e45dfbcfb0a3435a89f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84069 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed pre-req check during NVDimm ArmMATTHEW I. HICKMAN2019-09-251-1/+61
| | | | | | | | | | | | CQ:SW475280 Change-Id: I15634923e18dfecb18146e9ec33ed128111f517c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83484 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed several Arm error handling bugsMATTHEW I. HICKMAN2019-09-256-15/+43
| | | | | | | | | | | | CQ:SW475445 Change-Id: I19cd03850b65a23d2a35c9160352cdc7a4946667 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83534 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Remove Unused clearPoreBars function in Istep 21.3Bill Hoffa2019-09-251-94/+1
| | | | | | | | | | | | | | | | - This functionality was never used so remove it Change-Id: I2885be14c4bbf68e322a8a52f9364210e6943ca9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84183 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Add a ReadMe to explain high level BPM Update ProcessMatthew Raybuck2019-09-241-0/+147
| | | | | | | | | | | | | | | | | | Adds a readme to explain some of the background info, the update process, and point out the various files that the BPM update process relies on to succeed. Change-Id: I572f8789eab231d4f97e53eb7bfb8e7f94c2cc42 RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82675 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Double the NVDIMM_READY timeout to prevent erroneous errorTsung Yeung2019-09-241-2/+2
| | | | | | | | | | | | | | | | NVDIMM controller POR or firmware induced reset time may vary from run-to-run. Doubling the timeout here in case of edge condition. Change-Id: I717dfbef9b2903e8bb1e7aed92c28df1fab90033 CQ:SW476597 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84107 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed several small bugs found via code reviewMATTHEW I. HICKMAN2019-09-194-95/+148
| | | | | | | | | | | CQ:SW474830 Change-Id: I1ff22805b9bb3facf68d4d62ea66de169be9b98b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83213 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Changed the callout in the call NVM Health Status to be an NVDIMMRoland Veloz2019-09-161-17/+48
| | | | | | | | | | | | | | | | | | | | | | | In the call nvDimmNvmCheckHealthStatus, the call is incorrectly using HB when it should be associated with NVDIMM. Switched out the addPartCallout with HWAS::BPM_PART_TYPE to a addHwCallout with the given NVDIMM. Also added more trace info to print out the registers that are being retrieved. Corrected the logic such that a good state passes. Apparently, the way the code was written, a good or bad state, both would fail. Now the good state passes and the bad state fails. Change-Id: I46b62ce3fe5c5ac86efb501e2a91fdea8160b9b5 CQ: SW475265 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83673 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix bad arguments to additional FFDC capture in BPM Update codeMatthew Raybuck2019-09-142-67/+99
| | | | | | | | | | | | | | | | In bpm_update.C there were two places where the wrong errl was being given as a parameter to FFDC functions. The errl supplied was nullptr causing hostboot to crash as a result. This commit fixes that by suppling the correct errl. Change-Id: I50e8459d2b3602177ca740059a706613402c3e95 RTC:212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83781 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM: FW_UPDATE: New FFDC for SECURITY_ERRORCorey Swenson2019-09-132-1/+73
| | | | | | | | | | | | | | | For any command error or timeout during FW_UPDATE add regs to error log. Registers specified in NVDIMM IPL Error Handling Document. CQ:SW473060 Change-Id: I3ca8933b9c62f0b12bebefbae06357400e8e436e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83590 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add vendor log data to FFDC for all NVDIMM HW errorsCorey Swenson2019-09-134-0/+701
| | | | | | | | | | | | | Read vendor log data from NVDIMM Do checksum compare Add to error log as string Change-Id: I41a295bf54d031c978b59fe1f59c98507fbeec81 CQ:SW473585 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83383 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Apply MC_HANG timeout workaround to all processorsChristian Geddes2019-09-131-59/+45
| | | | | | | | | | | | | | | | When we initially added this workaround for whatever reason we specified the master proc only. It needs to be applied to all procesors in the system. Change-Id: I5840f2b0670f1790393a385f045ee656ad76bef8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83594 Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM: Additional FFDC for NVDIMM/BPM calloutsCorey Swenson2019-09-125-1/+148
| | | | | | | | | | | | Add page 4 SMART regs to error log FFDC for all NVDIMM HW errors. Add attribute to prevent recursively executing the function. Change-Id: I2cdd89436a2647c440f900a729596b522829aca6 CQ:SW470690 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82599 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Re-enable mss_scrub in istep16 for axone systemsChristian Geddes2019-09-121-8/+0
| | | | | | | | | | | | | | | | This step was disabled during bringup. Workarounds in place now so we can call it again. Change-Id: I6aaaf77173cdcf45771f1072fcab67b09546da86 RTC: 213933 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83200 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add exp_mss_eff_config_thermal call to istep7 for AxoneMatt Derksen2019-09-122-292/+435
| | | | | | | | | | | | | | | | This adds the procedure call along with removing unneccesary calls based on system type. Change-Id: I869b25246f32472246bd4cd5bf31080db68a7e39 RTC:208847 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82666 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Updates: Move NVDIMM controller reset and final fw check to end of updateMatthew Raybuck2019-09-111-75/+83
| | | | | | | | | | Change-Id: I54832f6197e620885b1506b47af248132173eba4 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83480 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix misleading trace output for BPM attribute overridesMatthew Raybuck2019-09-101-6/+24
| | | | | | | | | | | | | | | | The traces would indicate that the SKIP attribute override was enabled in some circumstances when it wasn't. This could lead to confusion about why BPM updates didn't occur. Change-Id: Ib577d5fe322266b300f622e9c9095e36dc69c5d1 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83122 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Updates: Extend the reset device wait to 15 seconds from 10Matthew Raybuck2019-09-101-2/+4
| | | | | | | | | | | | | | | | | There was an issue where the BPM reset wait was set to 10 seconds which would sometimes lead to SCAP timeouts. By setting it to 15 seconds, the issue goes away by giving the BPM more time to come back online after a reset command is sent. Change-Id: I3c20657ef976f13fb6636b280c7cc95195a24d53 RTC:215466 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83482 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Final solution for Axone HCODE lid idDan Crowell2019-09-091-9/+17
| | | | | | | | | | | | | | | | | Axone can just reuse the lid number that is assigned to Nimbus since it is only used to map to a common PNOR partition. There is never a real lid load done with this value. Change-Id: I7e1c2cc5f3f76e28b35dfd11e02a0af62c239c1b RTC: 214257 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83138 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added code to support doing an NVM health checkRoland Veloz2019-09-032-117/+596
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added a method that will do an NVM (non-volatile memory) health check. In particular this method will check the flash error counts and does a predictive callout if the number of flash error counts exceeds the maximum allowed. This method also checks the bad block percentage and does a predictive callout if the number of bad block percentage exceeds the maximum allowed. A predictive callout is done if either or both fail the check. Added support in the runtime commands to make the nvm health check call as well. Also, when I did the ES (energy source) health check method, I was not very explicit in the method that it was doing an ES health check. So I updated the verbiage in the nvDimmCheckHealthStatus to add ES wherever appropriate as to make these two method explicit as to what health check is being performed. Change-Id: Ib9925fd2bb8430cf2121108329247d96072beb1b CQ: 473220 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82843 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Compile new ioo_dl_npu_scominit HWP so its ready to useChristian Geddes2019-08-301-0/+1
| | | | | | | | Change-Id: I3267ab77f3a802b27a8bd0a03418804c0202e628 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83096 Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Fix for offset traces due to merge bugMATTHEW I. HICKMAN2019-08-291-4/+0
| | | | | | | | | | | Change-Id: Ied920772272b025952f82dcc918dfe59d679cc1b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83028 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add more FFDC to BPM Update Error logsMatthew Raybuck2019-08-281-6/+144
| | | | | | | | | | | | | | | | | | Adds part callouts for all BPM related error logs and collects BPM traces for any errors that are returned from interactions with the NVDIMM to provide context. Additionally, if there is an error during the config updates the code will erase the firmware section to force an update on any subsequent attempt. Change-Id: I045b4ba1feea2fbc1ddb5e418bf60b86d6c11bb1 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82946 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix lingering error log issues for BPM updatesMatthew Raybuck2019-08-282-77/+260
| | | | | | | | | | | | | | | | | There was a lingering issue where an error that was retryable was thought to be non-retryable. This propagated out of blockWrite() causing the update to think it had failed when it fact it had not. Change-Id: I536e79ddd4ac476fdf1aa0b370f81f4b0b198f4c RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82614 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Added security bit and fir handling, gard and trace fixesMATTHEW I. HICKMAN2019-08-277-113/+273
| | | | | | | | | | | Change-Id: I8160d9662859232dfd612b3a2f5c1c522c02e308 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82534 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add call to exp_mss_thermal_init to step 14.2Andre Marin2019-08-272-7/+14
| | | | | | | | | | | Change-Id: I85b34168b8a93ea8c744b6a79f207ce924cdf50f RTC:195557 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79326 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add Encryption Enabled bit to NV_STATUS_FLAGCorey Swenson2019-08-271-4/+38
| | | | | | | | | | | | | | | | | | - 0x10: Contents are encrypted Set when encryption is enabled Clear when encryption is disabled Attribute comments should match HDAT Change-Id: I52805f6c8c3f303ce29cf8b8534304dfd0a09821 RTC:214625 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82638 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Replaces nvdimmWrite() to reset controller with nvdimmResetController()Tsung Yeung2019-08-261-3/+3
| | | | | | | | | | | | | | | nvdimmResetController() will call nvdimm_encrypt_unlock() to unlock encryption if needed. Without it nvdimm ops could fail on runtime Change-Id: Iad4c4d354d3b9522ee0544b5c8de7484dcf89c6c CQ:SW474050 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82838 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
OpenPOWER on IntegriCloud