summaryrefslogtreecommitdiffstats
path: root/src/import/hwpf/fapi2/include/buffer.H
Commit message (Collapse)AuthorAgeFilesLines
* fapi2: Fix template call sites for GCC 7Joel Stanley2017-12-011-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following errors stop hostboot from building with modern GCC: src/import/hwpf/fapi2/include/buffer.H:710:23: error: invalid operands of types ‘<unresolved overloaded function type>’ and ‘fapi2::bufferTraits<long unsigned int, unsigned int>::bits_type {aka unsigned int}’ to binary ‘operator<’ out.insert<TS, L, SS>(iv_data); ~~~~~~~~~~^~~ src/import/hwpf/fapi2/include/buffer.H: In member function ‘fapi2::buffer<T, TT>& fapi2::buffer<T, TT>::flipBit()’: src/import/hwpf/fapi2/include/buffer.H:316:49: error: expected primary-expression before ‘)’ token iv_data ^= buffer<T>().setBit<B, C>(); ^ In both cases the call site needs to be prepended with the keyword 'template'. Otherwise the name is assumed to be a non-template (as per C++ 14.2/4). Change-Id: I925c35d51787c4f4f232372f0e1299ec2a5cab42 Signed-off-by: Joel Stanley <joel.stanley@au1.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49760 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49892 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
* Enable and fix error log variable_buffer support.Donald Washburn2017-06-151-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Errorlog support for the fapi2::variable_buffer type was not enabled in hostboot. Tests showed that when enabled, variable_buffer data was not being propagated properly to the error log. The issue was found to be that the pointer to the variable_buffer's internal data was not being properly passed to an ffdc_t object. Also, transferring the size of the variable_buffer data was not being correctly communicated to an ffdc_t object because a specialization of the getErrorInfoFfdcSize template function is needed. Becuase the specialization of the getErrorInfoFfdcSize function with an ffdc_t parameter did not exist, the code base used the primary function template for the getErrorInfoFfdcSize function which just returns the size of an ffdc_t object passed to it instead of the size of the contained data within the ffdc_t. Changes: * Added specialization of getErrorInfoFfdcSize for fapi2::ffdc_t. * Enabled variable_buffer support in parseErrorInfo.mk. * Added const overload of the pointer() method for the fapi2::buffer and fapi2::variable_buffer classes. This to allow these methods to be used in the set_BUFFER methods that take a const reference to objects of these classes. * Modified parseErrorInfo.pl to generate code to use the above mentioned pointer methods. The adjusted generated code fixes the problem of assigning an incorrect buffer pointer. Change-Id: I96dc89fbb68ee6a153ca43191181c56804b84ae8 RTC: 175239 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41541 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Prachi Gupta <pragupta@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41548 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Add another writeBit API, modify getBit. Add unit tests.Andre Marin2017-04-111-4/+30
| | | | | | | | | | | | | | | | | Change-Id: I9bd9efdc4b2c8a2eac26b7b1f1e1ef183d81f9b6 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38817 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com> Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38824 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Update prologs of mirrored files to apache licenseStephen Cprek2016-08-051-8/+14
| | | | | | | | Change-Id: I25a782f6f8af801beb35f541f6076c482b78bf8e Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27920 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Modify freq & dep. files. Add cas latency & unit testsAndre Marin2016-04-221-1/+17
| | | | | | | | | | | | | | | | Change-Id: I205bf48e54fb3c8f19f973f58f8ec1d4c7345a23 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22632 Tested-by: PPE CI Tested-by: Jenkins Server Reviewed-by: Brian R. Silver <bsilver@us.ibm.com> Tested-by: Hostboot CI Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22634 Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
* Fix mask calculation in buffer insert functionSantosh Puranik2015-12-111-5/+5
| | | | | | | | | Change-Id: Iec346df5b73f4e1796a73b1c6ac8fcebfcf58c4d Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/21589 Tested-by: Jenkins Server Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
* added plat_trace.H include for FAPI_ERR use in buffer.HMatt K. Light2015-12-111-0/+1
| | | | | | | | | Change-Id: If0a6884e7005022eb5e2730883e8c3bef16c95e3 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/21456 Tested-by: Jenkins Server Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
* fapi2 doxygen warning/error cleanup from ecmd repositoryKahn Evans2015-12-111-16/+16
| | | | | | | | | Change-Id: I502a6f79f461632588b46e51d5892e2d6b74942d Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/20985 Tested-by: Jenkins Server Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
* FAPI2 - Error/FFDC work related updatesThi Tran2015-12-111-15/+15
| | | | | | | | | Change-Id: I2c153d4362791d885b85fee0f4891a9239c6aec7 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/19308 Tested-by: Jenkins Server Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
* Fixed overflow problem in buffersBrian Silver2015-12-111-40/+40
| | | | | | | | | Change-Id: Idb3349052373cedaa8955b530a00dd7a25e72122 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/20182 Tested-by: Jenkins Server Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: WILLIAM G. HOFFA <wghoffa@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
* made const extract methodsMatt K. Light2015-12-111-84/+158
| | | | | | | | | Change-Id: I556f0028fcfae3b3d3892897edf8c853d8873660 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/18831 Tested-by: Jenkins Server Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
* Add support for ranges of bits in bit operatorsBrian Silver2015-12-111-24/+32
| | | | | | | | | Change-Id: Ifb8d66983379a9f113bfe315a671738d703da8d2 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17716 Tested-by: Jenkins Server Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Bilicon Patil <bilpatil@in.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com>
* Add variable_buffer get<OT>()Brian Silver2015-12-111-2/+2
| | | | | | | | | Change-Id: Iaf658f2d4a43703400ea016c37244f27524a73c0 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17679 Tested-by: Jenkins Server Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com>
* Swap arguments to extract API to match ecmd buffersBrian Silver2015-12-111-9/+9
| | | | | | | | | | Change-Id: I787daba83e3aba64e2f61d9ec8d5d4d92f31999a Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17595 Tested-by: Jenkins Server Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Alex Goryachev <gory@il.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com>
* Extend fapi2::buffer parametric interfacesBrian Silver2015-12-111-34/+191
| | | | | | | | | | | | | Add fapi2::buffer<T>::clearBit(bit_to_clear) Add extract/insert(<parameters>) Change-Id: I8dc00b6da68b22cd7b346cc1da56d33b94aec5b7 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17542 Tested-by: Jenkins Server Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Remove buffer_base.HBrian Silver2015-12-111-59/+116
| | | | | | | | | Change-Id: Iaa194fa4261a122dd0516e85572ae6deacbe854c Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/17135 Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com> Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Add variable_buffer::pointer()Brian Silver2015-12-111-0/+6
| | | | | | | | | | Change-Id: I4018509b00898c6ce9706c62d2d956a1019126aa Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/16819 Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: PRACHI GUPTA <pragupta@us.ibm.com> Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Fix flush, invert, and reverse buffer chainingBrian Silver2015-12-111-8/+60
| | | | | | | | | | | | | | Fix flush, insert/extract invert, and reverse buffer chaining Add thread bitset functions Remove putScom reference - allow for (b | 0x6) as a buffer param Add FAPI@_RC_FALSE to allow for tri-bool type operations Change-Id: I5e07f3f2050e45bca1a6c5a21c74ac62f5b9c51d Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/16539 Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: James N. Klazynski <jklazyns@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Buffer, targeting updatesBrian Silver2015-12-111-50/+32
| | | | | | | | | | | | | | | | Update target types for ex, l2/l3 Add variable_buffer resize Update, fix, variable_buffer insert/extract variable_buffer array constructor -Wall clean up Refactor buffer::insert, bit_lengths Change-Id: I2bbec294f275a80c33917dc2df2f8b8220f6d8d6 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/16359 Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: MATTHEW A. PLOETZ <maploetz@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Add fapi2::buffer<T>::extractToRight()Brian Silver2015-12-111-11/+10
| | | | | | | | | Change-Id: I3c9825260e24500c7bb8adc4bb92e154d31b5208 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/16157 Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: PRACHI GUPTA <pragupta@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* fapi2 bug fixes and cleanupBrian Silver2015-12-111-6/+7
| | | | | | | | | | | | | | Add assignment/equality operators to targets Add fapi2::buffer<T>::pointer() Fix fapi2::buffer<T> operator documentation Add inline to hw_access, error_info functions Remove error_info interator typdefs in favor of auto Change-Id: I8931215862c55188747a7de78f9344c0ca7ab517 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/16096 Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Add doxygen fapi2 tooling, doc clean upBrian Silver2015-12-111-2/+3
| | | | | | | Change-Id: Ieb787904e7d359f966298cf834195bed5ce86207 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/15730 Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
* Error/xml parsing and FFDC classesBrian Silver2015-12-111-0/+421
Change-Id: Iddc92bb876dd07efe398255d7321ac6394eb4ae9 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/15966 Reviewed-by: Thi N. Tran <thi@us.ibm.com> Reviewed-by: Matt K. Light <mklight@us.ibm.com> Reviewed-by: Brian Silver <bsilver@us.ibm.com> Tested-by: Brian Silver <bsilver@us.ibm.com>
OpenPOWER on IntegriCloud