| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Builds on Ubuntu are failing with hbibl.bin size error.
Traced back to linker struct Object constructor missing
the init of sfpr section.
Change-Id: I9ad7ab90f02d403dc0237831736cc615e73738e6
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86066
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zachary Clark <zach@ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hostboot currently spends a significant percentage of
time loading data from PNOR across a relatively slow LPC
bus. This commit enables compilation of Hostboot with
-Os, optimized for space to reduce the amount of data required
to be transferred across the LPC bus
Rough measurements show a ~30% size reduction of the hostboot
image and a ~10% reduction (improvement) in boot time
Change-Id: Ib73863019595a24cc7d10e924bc5c92cd64af1ed
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84436
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit cd1e5c91e4a15ca933c699553ece9b841825ac03.
The previous change seems to be causing problems with
thread local storage (TLS) access.
CQ: SW471547
Change-Id: Ic6f43fbba2a3d5abe94ea73e8e5fd03702b84365
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81652
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hostboot currently spends a significant percentage of
time loading data from PNOR across a relatively slow LPC
bus. This commit enables compilation of Hostboot with
-Os, optimized for space to reduce the amount of data required
to be transferred across the LPC bus
Rough measurements show a ~30% size reduction of the hostboot
image and a ~10% reduction (improvement) in boot time
Change-Id: Ib140e6f07b112ae95a901f49b75416ef91c94a9d
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79059
Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zachary Clark <zach@ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hostboot uses the objdump tool to disassemble modules and the genlist
program to create the listing files (*.list.bz2) for each binary blob
generated by the build process (hbibl, hbicore, etc). The hundreds of
objdump invocations account for a majority of the build time when
recompiling hostboot after a small number of files have been changed
because all the shared objects for a binary must be dumped again
regardless of whether they have been modified.
This commit causes the genlist program and the makefiles to cache the
(compressed) disassembly when the BUILD_FAST flag is set so that only
modified ELF files need to be redumped. Also several binaries include
the same modules, which means that a given module may be dumped
multiple times needlessly.
Benchmarks for recompilation after modifying small numbers of files
show at least a 5x speedup as compared with the original build system.
Using BUILD_FAST comes with a cost of about 35 MB of disk space. When
compiling all of hostboot (i.e. all libraries must be dumped), using
BUILD_FAST is not slower than a vanilla build. The cached objdump
output is stored in the img/objdump/ folder.
Example:
make BUILD_FAST=1 -j32
Change-Id: I65be7b29cec953950bfa664a5ee04e3a711007b5
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80115
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Luis P Fernandez <luis.fernandez@ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit fixes GCOV code coverage for P9 with GCC 4.9.2
Change-Id: Ie1e7c35f67414531dbd6e7a771ac1529a9ebd59d
RTC: 208351
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76812
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resolve warnings when compiling with gcc 4.8. Compiled with GCC 7.3,
no more compile errors/warnings; build ends with caught exception from
linker. This commit compiles with GCC 8.2, no more error/warnings; except
for a linking warning.
Change-Id: Ib5d7c2b5bd350edc76ee2c7de96896154cd44420
RTC: 202716
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72271
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generally adds support to declare variables as thread_local
- Add support in HBRT start assembly to skip adjusting TLS relocations
- Add support in linker to generate tagged TLS entries
- Update linker to process TLS relocations correctly
- Update TLS code to ignore top half of module ID
- Update module images to hold a "module ID"
- Update custome linker to update module ID during binary link
- Update TLS code to track TLS sections via module ID
Change-Id: I1589550d7787beb08827ca24a728397dedf0373b
RTC: 147599
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71709
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Fedora 28 (x86_64) the linker binary, produced by GCC 8.1.1, always
ended in an infinite loop in which it repeatedly appended some text to
*.lnkout.bz2 file and *.bin.modinfo file.
Example : .hbicore.lnkout.bz2: Error writing to output.
Success
hbicore.bin.modinfo: hbicore.elf,0x0
The GCC was also displaying warnings about missing return statements
(-Wreturn-type). When these warnings were fixed, the problem with
infinite loop disappeared. This problem also never appeared when the
-O0 flag was used.
While being there, also fix some warnings that happen with the -Wall
flag.
Resolves #143
Change-Id: Ia1ddfa07d3b22b151922de2df1db91ffc2aad2ca
Signed-off-by: Jan Hlavac <jhlavac@redhat.com>
Signed-off-by: Joel Stanley <joel.stanley@au1.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61862
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/62830
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally added version id to resolve story 135747
RTC: 143902
Change-Id: I67ad4b28b76464aaa58ec2c344cd1f9ceef9ff73
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33608
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since genlist is used in makefiles and stdout redirected,
if there is an error, you will not see it in make output at
all, instead having things fail in weird ways.
Use fprintf for stderr rather than to stdout to avoid
Change-Id: I947a72bb1ecc33cbecf51f426a5b76664a6dc03b
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Patrick Williams <iawillia@us.ibm.com>
Forwardport: yes
Github: See open-power/hostboot#39
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23180
Tested-by: Jenkins Server
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23185
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since genlist is used in makefiles and stdout redirected,
if there is an error, you will not see it in make output at
all, instead having things fail in weird ways.
Use fprintf for stderr rather than to stdout to avoid
Change-Id: Ief51d85817540437c2831719270a04efbe2a2feb
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Patrick Williams <iawillia@us.ibm.com>
Forwardport: yes
Github: See open-power/hostboot#39
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23179
Tested-by: Jenkins Server
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23184
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, when run with valgrind on my fedora 23 laptop:
==27841== Thread 2:
==27841== Conditional jump or move depends on uninitialised value(s)
==27841== at 0x4028AE: read_module_symbols(void*) (gensyms.C:308)
==27841== by 0x4E3C609: start_thread (pthread_create.c:334)
==27841== by 0x59EFA9C: clone (clone.S:109)
==27841==
Change-Id: Ib1540baddc8d32013208df86b871546bc24461fa
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: Patrick Williams <iawillia@us.ibm.com>
Forwardport: Yes
Github: close open-power/hostboot#40
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23178
Tested-by: Jenkins Server
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/23182
|
|
|
|
|
|
|
|
|
|
| |
RTC: 124148
Change-Id: I055885bc7d7cfc4ebd7cf1a662f677bdf4e28c62
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/22313
Tested-by: Jenkins Server
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Reviewed-by: Brian Silver <bsilver@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
RTC: 124148
Change-Id: I6f9b1a654c5a19bb0a27ecb6179af27f2b783671
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/22312
Tested-by: Jenkins Server
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to explicitly link with -ldl with binutils 2.25
Change-Id: Ie0a7a7ac39d69914e3be0d26f0c6b0c4c58ae5c4
Fixes: open-power/hostboot#31
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/20092
Tested-by: Jenkins Server
Tested-by: Jenkins OP Build CI
Tested-by: Jenkins OP HW
Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I46505bd6bddfdf4fb0f2dccc7c78a382431fc63d
RTC: 120455
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/15520
Tested-by: Jenkins Server
Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I96ad2aff81ad5695f175fbdea3fe0ecbae4f1654
RTC: 123430
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/15627
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
- See https://github.com/lucasdemarchi/codespell
Change-Id: I03e102d1ebb9473b6226fa9b6edb684fa0218a2f
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/15031
Tested-by: Jenkins Server
Reviewed-by: STEPHEN M. CPREK <smcprek@us.ibm.com>
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Reviewed-by: Brian Silver <bsilver@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: I27e18a424ba4bad7dbd33cd17a5c23c65269f51a
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/11958
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: I8f2bef01886d69d275824054faac4be34b9cac6b
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/11943
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: I5664587b4f889099290ef50d50fa9ce5e580e1eb
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/11167
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I64a05ac460d75a8328a326d808e906dc0751a8d8
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/7166
Tested-by: Jenkins Server
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added support for master processor type attributes
- Made attribute sync multinode aware
- Added platform properties constants
- Added multinode iterator support
- Extended default iterator to skip hidden system targets
- Added raw iterator to "see" hidden system targets
- Updated target service to be multinode aware
- Added new API to query master proc per node
- Modified MRW parser to support cross node peers
- Modified MRW parser to default master proc per node
- Removed cross node peer workarounds in node splitter script
- Added common support for master system targets
- Updated attribute compiler to serialize cross node peer targets
- Updated attribute compiler to generate attribute size map
- Updated attribute compiler to impose special ordering on target layout
- Inhibited XML merge script from merging itself in xmltohb makefile
- Inhibited duplicate weak symbol errors in trace statements
Change-Id: I661eca12f3a7cc16c0ff5476a7ae66cea3bad7d3
RTC: 63940
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6103
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
| |
RTC: 76675
Change-Id: Ibd21cf5b555e6dcee182a2f1a292b47d4f384ba0
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6127
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Change-Id: Ie0210ec7a136613a5407466af827d6a74e534876
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5648
Tested-by: Jenkins Server
Reviewed-by: ADAM R. MUHLE <armuhle@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ia09c2fe78981d61487dfae328f54c14baba083b2
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5551
Tested-by: Jenkins Server
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: ADAM R. MUHLE <armuhle@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ib35acf9e151d39fd9f1ce310e138f447aae51302
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5550
Tested-by: Jenkins Server
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I435996d29ca6c7ad4ce892302729089a2767e643
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5549
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I38b3c391f2fd33ec21d9c11d1088e284216b8b3b
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5133
Tested-by: Jenkins Server
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I67a7d626c81b0b90e25057c486d490e6e2b5aede
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5132
Tested-by: Jenkins Server
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I0f3b9a941c19040635752b2648ef51c50dba849b
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5135
Tested-by: Jenkins Server
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I1da7d93fb9d36d780321f291fce8edd216092488
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4583
Tested-by: Jenkins Server
Reviewed-by: ADAM R. MUHLE <armuhle@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: I94de98109b28434050030af824dd6ca50f7a18dc
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4042
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unused files for generating LIDs.
- Reduce the overall verbosity of the build.
- Separate 'config.mk' into a number of smaller, topic-centric
files and comment better.
- Generalize the 'passes' concept and added an IMAGES pass.
- Deprecate most "magic" make variables like EXTRAFOO.
- Overall performance improvements.
I've tried to reduce the impact of these changes on component-level
makefiles. There will be follow-up commit(s) to improve those and
decrease the verbosity of some component-owned commands.
Change-Id: I6d319f5338eb3946f56b281c3cdd5f341a016fcc
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3368
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: ADAM R. MUHLE <armuhle@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have issues with weak symbols containing member variables
if they exist in multiple modules because each module's code
ends up with their own copy. For objects like Singleton's
this is bad because the objects are no longer singleton.
The original solution for this was to prohibit multiple
definition of the same weak symbol. This causes extra errors
when using templated code such as using a vector<foo> in two
different modules.
The solution here is to search for member values inside of a
weak symbol instead of just duplicate weak symbols. This
allows multiple weak symbol definitions as long as those
weak symbols do not have a contained member value (like a
singleton instance would).
Change-Id: I173dde9be71f169a457b20db8b960c2b89e7a900
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/709
Tested-by: Jenkins Server
Reviewed-by: Van H. Lee <vanlee@us.ibm.com>
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: Id4d7c03b65a2c15e434e8282691d0cc4c9961267
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/584
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I2c933597d48b5cd16a3e26bffc0371f5df340181
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/566
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: I6d2a7e22570ae1c10512844ee2ba7de5c3605006
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/356
Tested-by: Jenkins Server
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Change-Id: Iaa6a256a8a15ac48bfba5bc1cab292c5ac246166
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/253
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cause the linker to stop the build if the image has multiple instances
of the same weak symbol. This is to prevent, for instance, two
different instances of the same Singleton<Foo> from being created in
two different modules.
Change-Id: I0204e69f191d63451a53b1f99dd226c9996bbccb
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/217
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
|
|
|
| |
Change-Id: I21acf1b870667aa3aa2617837bead3a1697db7c1
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/194
Tested-by: Jenkins Server
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pass is executed before trying to compile anything. Makefiles can
now add headerfiles to be generated to the GENFILES variable and define
rules for how these headers get generated. Generated headers should go
into 'obj/genfiles/'.
Change-Id: Ieab44f0559e1dd75f5426b67545c4914035d4c23
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/157
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
|
|
|
|
| |
dd45c30bd53d8e6c123165b83842d08117558a3c
|
| |
|
| |
|
|
|