diff options
Diffstat (limited to 'src/usr/diag')
-rwxr-xr-x | src/usr/diag/prdf/common/plat/prdfPlatServices_common.C | 28 | ||||
-rwxr-xr-x | src/usr/diag/prdf/common/plat/prdfPlatServices_common.H | 26 | ||||
-rwxr-xr-x | src/usr/diag/prdf/common/plat/prdfRasServices_common.C | 1 | ||||
-rwxr-xr-x | src/usr/diag/prdf/common/plat/prdfTargetServices.C | 1 | ||||
-rw-r--r-- | src/usr/diag/prdf/common/plugins/prdfLogParse_common.C | 4 | ||||
-rw-r--r-- | src/usr/diag/prdf/common/plugins/prdfMemLogParse.C | 10 | ||||
-rw-r--r-- | src/usr/diag/prdf/common/plugins/prdfParserEnums.H | 2 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/mem/prdfMemTdCtlr_rt.C | 12 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C | 4 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/mem/prdfMemVcm_rt.C | 4 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/prdfPlatServices.C | 17 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/prdfPlatServices.H | 2 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/prdfPlatServices_ipl.C | 8 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/prdfPlatServices_ipl.H | 4 | ||||
-rw-r--r-- | src/usr/diag/prdf/plat/prdfPlatServices_rt.C | 2 |
15 files changed, 69 insertions, 56 deletions
diff --git a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C index 932aad510..6e8241ffa 100755 --- a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C +++ b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C @@ -39,11 +39,11 @@ #include <prdfTrace.H> #include <prdfErrlUtil.H> -//#include <prdfCenAddress.H> TODO RTC 136126 -//#include <prdfCenDqBitmap.H> TODO RTC 136126 -//#include <prdfCenMarkstore.H> TODO RTC 136126 +//#include <prdfCenAddress.H> TODO RTC 157888 +//#include <prdfCenDqBitmap.H> TODO RTC 157888 +//#include <prdfCenMarkstore.H> TODO RTC 157888 -//#include <dimmBadDqBitmapFuncs.H> // for dimm[S|G]etBadDqBitmap() TODO RTC 136126 +//#include <dimmBadDqBitmapFuncs.H> // for dimm[S|G]etBadDqBitmap() TODO RTC 164707 //#include <io_read_erepair.H> TODO RTC 136120 //#include <io_power_down_lanes.H> TODO RTC 136120 @@ -269,7 +269,7 @@ int32_t erepairFirIsolation(TargetHandle_t i_rxBusTgt) //## Memory specific functions //############################################################################## -/* TODO RTC 136126 +/* TODO RTC 157888 // Helper function for the for several other memory functions. int32_t getMemAddrRange( TargetHandle_t i_mba, uint8_t i_mrank, ecmdDataBufferBase & o_startAddr, @@ -343,7 +343,7 @@ int32_t getMemAddrRange( TargetHandle_t i_mba, uint8_t i_mrank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 int32_t getBadDqBitmap( TargetHandle_t i_mba, const CenRank & i_rank, CenDqBitmap & o_bitmap, bool i_allowNoDimm ) { @@ -391,7 +391,7 @@ int32_t getBadDqBitmap( TargetHandle_t i_mba, const CenRank & i_rank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 int32_t setBadDqBitmap( TargetHandle_t i_mba, const CenRank & i_rank, const CenDqBitmap & i_bitmap ) { @@ -429,7 +429,7 @@ int32_t setBadDqBitmap( TargetHandle_t i_mba, const CenRank & i_rank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssGetMarkStore( TargetHandle_t i_mba, const CenRank & i_rank, CenMark & o_mark ) { @@ -495,7 +495,7 @@ int32_t mssGetMarkStore( TargetHandle_t i_mba, const CenRank & i_rank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssSetMarkStore( TargetHandle_t i_mba, const CenRank & i_rank, CenMark & io_mark, bool & o_writeBlocked, bool i_allowWriteBlocked ) @@ -554,7 +554,7 @@ int32_t mssSetMarkStore( TargetHandle_t i_mba, const CenRank & i_rank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssGetSteerMux( TargetHandle_t i_mba, const CenRank & i_rank, CenSymbol & o_port0Spare, CenSymbol & o_port1Spare, CenSymbol & o_eccSpare ) @@ -588,7 +588,7 @@ int32_t mssGetSteerMux( TargetHandle_t i_mba, const CenRank & i_rank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssSetSteerMux( TargetHandle_t i_mba, const CenRank & i_rank, const CenSymbol & i_symbol, bool i_x4EccSpare ) { @@ -616,7 +616,7 @@ int32_t mssSetSteerMux( TargetHandle_t i_mba, const CenRank & i_rank, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t getMemAddrRange( TargetHandle_t i_mba, CenAddr & o_startAddr, CenAddr & o_endAddr ) { @@ -642,7 +642,7 @@ int32_t getMemAddrRange( TargetHandle_t i_mba, CenAddr & o_startAddr, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t getMemAddrRange( TargetHandle_t i_mba, const CenRank & i_rank, CenAddr & o_startAddr, CenAddr & o_endAddr, bool i_slaveOnly ) @@ -916,7 +916,7 @@ int32_t getMemBufRawCardType( TargetHandle_t i_mba, //## Maintenance Command class wrapper //############################################################################## -/* TODO RTC 136126 +/* TODO RTC 157888 mss_MaintCmdWrapper::mss_MaintCmdWrapper( mss_MaintCmd * i_maintCmd ) : iv_cmd(i_maintCmd) {} diff --git a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.H b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.H index 55ff237f9..8688892ce 100755 --- a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.H +++ b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.H @@ -43,7 +43,7 @@ #include <prdfTimer.H> #include <prdfParserEnums.H> -//#include <dimmConsts.H> // for DIMM_DQ_RANK_BITMAP_SIZE TODO RTC 136126 +//#include <dimmConsts.H> // for DIMM_DQ_RANK_BITMAP_SIZE TODO RTC 164707 #include <plat_hwp_invoker.H> @@ -213,7 +213,7 @@ int32_t erepairFirIsolation(TARGETING::TargetHandle_t i_rxBusTgt); * possible ranks. Default is FALSE. * @return Non-SUCCESS if an internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 164707 int32_t getBadDqBitmap( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, CenDqBitmap & o_bitmap, bool i_allowNoDimm = false ); */ @@ -226,7 +226,7 @@ int32_t getBadDqBitmap( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, * @note This is a no-op if DRAM Repairs are disabled in manufacturing. * @return Non-SUCCESS if an internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 164707 int32_t setBadDqBitmap( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, const CenDqBitmap & i_bitmap ); */ @@ -238,7 +238,7 @@ int32_t setBadDqBitmap( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, * @param o_mark The returned mark. * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssGetMarkStore( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, CenMark & o_mark ); */ @@ -263,7 +263,7 @@ int32_t mssGetMarkStore( TARGETING::TargetHandle_t i_mba, * time, so do a RMW operation to avoid overwritting a previous mark. * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssSetMarkStore( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, CenMark & io_mark, bool & o_writeBlocked, @@ -279,7 +279,7 @@ int32_t mssSetMarkStore( TARGETING::TargetHandle_t i_mba, * @param o_eccSpare A symbol associated with the ECC spare (x4 mode only). * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssGetSteerMux( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, CenSymbol & o_port0Spare, CenSymbol & o_port1Spare, CenSymbol & o_eccSpare ); @@ -294,7 +294,7 @@ int32_t mssGetSteerMux( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, * @note The procedure will be able to derive the port from the given symbol. * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssSetSteerMux( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, const CenSymbol & i_symbol, bool i_x4EccSpare ); */ @@ -306,7 +306,7 @@ int32_t mssSetSteerMux( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, * @param o_endAddr The return end address. * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t getMemAddrRange( TARGETING::TargetHandle_t i_mba, CenAddr & o_startAddr, CenAddr & o_endAddr ); */ @@ -321,7 +321,7 @@ int32_t getMemAddrRange( TARGETING::TargetHandle_t i_mba, CenAddr & o_startAddr, * @param i_slaveOnly true = slave rank only, false = master rank (default). * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t getMemAddrRange( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, CenAddr & o_startAddr, CenAddr & o_endAddr, bool i_slaveOnly = false ); @@ -347,7 +347,7 @@ TARGETING::TargetHandle_t getMasterCore( TARGETING::TargetHandle_t i_procTgt ); * spare can be on High nibble or low nibble. This function will * populate spare config information in o_spareConfig. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t getDimmSpareConfig( TARGETING::TargetHandle_t i_mba, CenRank i_rank, uint8_t i_ps, uint8_t & o_spareConfig ); */ @@ -377,7 +377,7 @@ void getDimmDqAttr( TARGETING::TargetHandle_t i_target, //## Maintenance Command class wrapper //############################################################################## -// TODO: RTC 136126 +// TODO: RTC 157888 ///** // * @brief This is a wrapper class for underlying maintenance class object // * @@ -473,7 +473,7 @@ void getDimmDqAttr( TARGETING::TargetHandle_t i_target, * that contains i_rank, but the target address range can be modified * with i_flags and/or i_sAddrOverride. */ -/* TODO RTC 136126 +/* TODO RTC 157888 mss_MaintCmdWrapper * createMssCmd( mss_MaintCmdWrapper::CmdType i_cmdType, TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, uint32_t i_stopCond, @@ -490,7 +490,7 @@ mss_MaintCmdWrapper * createMssCmd( mss_MaintCmdWrapper::CmdType i_cmdType, * @note This function allocates memory on heap for mss_MaintCmdWrapper * object. It is the caller's responsibilty to delete this object. */ -/* TODO RTC 136126 +/* TODO RTC 157888 mss_MaintCmdWrapper * createIncAddrMssCmd( TARGETING::TargetHandle_t i_mba ); */ diff --git a/src/usr/diag/prdf/common/plat/prdfRasServices_common.C b/src/usr/diag/prdf/common/plat/prdfRasServices_common.C index e92389e67..fd85d9c4e 100755 --- a/src/usr/diag/prdf/common/plat/prdfRasServices_common.C +++ b/src/usr/diag/prdf/common/plat/prdfRasServices_common.C @@ -37,7 +37,6 @@ #include <prdfCallouts.H> #include <prdfMemoryMru.H> #include <prdfPlatServices.H> -//#include <prdfCenMbaCaptureData.H> TODO: RTC 136126 // For compression routines #define PRDF_COMPRESSBUFFER_COMPRESS_FUNCTIONS diff --git a/src/usr/diag/prdf/common/plat/prdfTargetServices.C b/src/usr/diag/prdf/common/plat/prdfTargetServices.C index e4c481057..f9d2e4d60 100755 --- a/src/usr/diag/prdf/common/plat/prdfTargetServices.C +++ b/src/usr/diag/prdf/common/plat/prdfTargetServices.C @@ -44,7 +44,6 @@ // External includes #include <algorithm> -//#include <fapi.H> TODO RTC 136126 #include <targeting/common/targetservice.H> #include <targeting/common/utilFilter.H> diff --git a/src/usr/diag/prdf/common/plugins/prdfLogParse_common.C b/src/usr/diag/prdf/common/plugins/prdfLogParse_common.C index bd66e0e15..1de7cd64c 100644 --- a/src/usr/diag/prdf/common/plugins/prdfLogParse_common.C +++ b/src/usr/diag/prdf/common/plugins/prdfLogParse_common.C @@ -431,11 +431,13 @@ bool parseCaptureData( void * i_buffer, uint32_t i_buflen, { parseMemCeTable( sigData, sigDataSize, i_parser ); } -/* TODO: RTC 136126 +/* TODO: RTC 157888 else if ( Util::hashString("MEM_RCE_TABLE") == sigId ) { parseMemRceTable( sigData, sigDataSize, i_parser ); } +*/ +/* TODO: RTC 164707 else if ( Util::hashString("DRAM_REPAIRS_DATA") == sigId ) { parseDramRepairsData( sigData, sigDataSize, i_parser ); diff --git a/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C b/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C index 1ca7b06e6..0b7e4f17f 100644 --- a/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C +++ b/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C @@ -2774,7 +2774,7 @@ uint8_t dqSiteIdx2DramSiteIdx( uint8_t i_dqSiteIdx, bool i_isX4Dram ) // Helper functions //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 // Displays symbol value. If symbol is not valid, will display '--' in output. void getDramRepairSymbolStr( uint8_t i_value, char * o_str, uint32_t i_strSize ) { @@ -3176,7 +3176,7 @@ bool parseMemCeTable( uint8_t * i_buffer, uint32_t i_buflen, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 bool parseMemRceTable( uint8_t * i_buffer, uint32_t i_buflen, ErrlUsrParser & i_parser ) { @@ -3224,7 +3224,7 @@ bool parseMemRceTable( uint8_t * i_buffer, uint32_t i_buflen, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 bool parseDramRepairsData( uint8_t * i_buffer, uint32_t i_buflen, ErrlUsrParser & i_parser ) { @@ -3294,7 +3294,7 @@ bool parseDramRepairsData( uint8_t * i_buffer, uint32_t i_buflen, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 bool parseDramRepairsVpd( uint8_t * i_buffer, uint32_t i_buflen, ErrlUsrParser & i_parser ) { @@ -3320,7 +3320,7 @@ bool parseDramRepairsVpd( uint8_t * i_buffer, uint32_t i_buflen, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 bool parseBadDqBitmap( uint8_t * i_buffer, uint32_t i_buflen, ErrlUsrParser & i_parser ) { diff --git a/src/usr/diag/prdf/common/plugins/prdfParserEnums.H b/src/usr/diag/prdf/common/plugins/prdfParserEnums.H index 9390fc604..8d8f0c686 100644 --- a/src/usr/diag/prdf/common/plugins/prdfParserEnums.H +++ b/src/usr/diag/prdf/common/plugins/prdfParserEnums.H @@ -153,7 +153,7 @@ namespace RCE_TABLE } // namespace RCE_TABLE -/* TODO: RTC 136126 +/* TODO: RTC 164707 namespace DQ_BITMAP { enum diff --git a/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr_rt.C b/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr_rt.C index 6ace54515..638dc3d54 100644 --- a/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr_rt.C +++ b/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr_rt.C @@ -77,6 +77,10 @@ uint32_t MemTdCtlr<T>::handleTdEvent( STEP_CODE_DATA_STRUCT & io_sc, break; } + // Since we had to manually stop the maintenance command, refresh all + // relevant registers that may have changed since the initial capture. + // TODO: RTC 166837 + // Move onto the next step in the state machine. o_rc = nextStep( io_sc ); if ( SUCCESS != o_rc ) @@ -107,7 +111,7 @@ uint32_t MemTdCtlr<T>::initialize() if ( iv_initialized ) break; // nothing to do // Add any unverified chip marks to the TD queue - // TODO: RTC 136126 + // TODO: RTC 171866 // At this point, the TD controller is initialized. iv_initialized = true; @@ -139,6 +143,8 @@ uint32_t MemTdCtlr<T>::defaultStep( STEP_CODE_DATA_STRUCT & io_sc ) nextRank.getRank().getSlave() ); // Restart background scrubbing on the next rank. + // TODO: RTC 171875 Need mechanism to resume on next address (via HWP) + // if no targeted diagnostics have been run. o_rc = startBgScrub<T>( nextRank.getChip(), nextRank.getRank() ); if ( SUCCESS != o_rc ) { @@ -168,7 +174,7 @@ uint32_t MemTdCtlr<TYPE_MCBIST>::checkEcc( bool & o_errorsFound, o_errorsFound = false; - /* TODO: RTC 136126 + /* TODO: RTC 171915 MemRank rank = iv_stoppedRank.getRank(); do @@ -220,7 +226,7 @@ uint32_t MemTdCtlr<TYPE_MBA>::checkEcc( bool & o_errorsFound, o_errorsFound = false; - /* TODO: RTC 136126 + /* TODO: RTC 171915 MemRank rank = iv_stoppedRank.getRank(); o_rc = __checkEcc<TYPE_MBA>( iv_chip, rank, iv_queue, io_sc, diff --git a/src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C b/src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C index 50e0c3d00..13f054dca 100644 --- a/src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C +++ b/src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016 */ +/* Contributors Listed Below - COPYRIGHT 2016,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -35,7 +35,7 @@ namespace PRDF //------------------------------------------------------------------------------ -// TODO: RTC 136126 Actual implementation of this procedure will be done later. +// TODO: RTC 171914 Actual implementation of this procedure will be done later. template<> uint32_t TpsEvent<TYPE_MCA>::nextStep( STEP_CODE_DATA_STRUCT & io_sc, bool & o_done ) diff --git a/src/usr/diag/prdf/plat/mem/prdfMemVcm_rt.C b/src/usr/diag/prdf/plat/mem/prdfMemVcm_rt.C index 7f8717a3c..6952f40f5 100644 --- a/src/usr/diag/prdf/plat/mem/prdfMemVcm_rt.C +++ b/src/usr/diag/prdf/plat/mem/prdfMemVcm_rt.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016 */ +/* Contributors Listed Below - COPYRIGHT 2016,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -35,7 +35,7 @@ namespace PRDF //------------------------------------------------------------------------------ -// TODO: RTC 136126 Actual implementation of this procedure will be done later. +// TODO: RTC 171913 Actual implementation of this procedure will be done later. template<> uint32_t VcmEvent<TYPE_MCA>::nextStep( STEP_CODE_DATA_STRUCT & io_sc, bool & o_done ) diff --git a/src/usr/diag/prdf/plat/prdfPlatServices.C b/src/usr/diag/prdf/plat/prdfPlatServices.C index 08c1fba46..59600c116 100644 --- a/src/usr/diag/prdf/plat/prdfPlatServices.C +++ b/src/usr/diag/prdf/plat/prdfPlatServices.C @@ -310,7 +310,12 @@ uint32_t startBgScrub<TYPE_MCA>( ExtensibleChip * i_mcaChip, fapi2::Target<fapi2::TARGET_TYPE_MCBIST> fapiTrgt ( mcbChip->getTrgt() ); // Get the stop conditions. + // NOTE: If HBRT_PRD is not configured, we want to use the defaults so that + // background scrubbing never stops. mss::mcbist::stop_conditions stopCond; + + #ifdef CONFIG_HBRT_PRD + stopCond.set_thresh_nce_int(1) .set_thresh_nce_soft(1) .set_thresh_nce_hard(1) @@ -321,6 +326,8 @@ uint32_t startBgScrub<TYPE_MCA>( ExtensibleChip * i_mcaChip, // In MNFG mode, stop on RCE_ETE to get an accurate callout for IUEs. if ( mfgMode() ) stopCond.set_thresh_rce(1); + #endif + // Get the scrub speed. mss::mcbist::speed scrubSpeed = enableFastBgScrub() ? mss::mcbist::LUDICROUS : mss::mcbist::BG_SCRUB; @@ -535,7 +542,7 @@ uint32_t startBgScrub<TYPE_MBA>( ExtensibleChip * i_mbaChip, } // Start the background scrub command. - PRDF_ERR( PRDF_FUNC "function not implemented yet" ); // TODO RTC 136126 + PRDF_ERR( PRDF_FUNC "function not implemented yet" ); // TODO RTC 157888 } while (0); @@ -550,7 +557,7 @@ template<> uint32_t startVcmPhase1<TYPE_MBA>( ExtensibleChip * i_mbaChip, const MemRank & i_rank ) { - PRDF_ERR( "function not implemented yet" ); // TODO RTC 136126 + PRDF_ERR( "function not implemented yet" ); // TODO RTC 157888 return SUCCESS; } @@ -560,7 +567,7 @@ template<> uint32_t startVcmPhase2<TYPE_MBA>( ExtensibleChip * i_mbaChip, const MemRank & i_rank ) { - PRDF_ERR( "function not implemented yet" ); // TODO RTC 136126 + PRDF_ERR( "function not implemented yet" ); // TODO RTC 157888 return SUCCESS; } @@ -570,7 +577,7 @@ template<> uint32_t startTpsPhase1<TYPE_MBA>( ExtensibleChip * i_mbaChip, const MemRank & i_rank ) { - PRDF_ERR( "function not implemented yet" ); // TODO RTC 136126 + PRDF_ERR( "function not implemented yet" ); // TODO RTC 157888 return SUCCESS; } @@ -580,7 +587,7 @@ template<> uint32_t startTpsPhase2<TYPE_MBA>( ExtensibleChip * i_mbaChip, const MemRank & i_rank ) { - PRDF_ERR( "function not implemented yet" ); // TODO RTC 136126 + PRDF_ERR( "function not implemented yet" ); // TODO RTC 157888 return SUCCESS; } diff --git a/src/usr/diag/prdf/plat/prdfPlatServices.H b/src/usr/diag/prdf/plat/prdfPlatServices.H index 53509ec8e..bea0a3c6c 100644 --- a/src/usr/diag/prdf/plat/prdfPlatServices.H +++ b/src/usr/diag/prdf/plat/prdfPlatServices.H @@ -35,7 +35,7 @@ */ #include <lib/mcbist/memdiags.H> ///< MCBIST command interfaces -//#include <utility_procedures/mss_maint_cmds.H> TODO: RTC 136126 +//#include <utility_procedures/mss_maint_cmds.H> TODO: RTC 157888 // This must be included after all Hostboot specific includes. This will take // care of cases where a file must be included in the common code, but the diff --git a/src/usr/diag/prdf/plat/prdfPlatServices_ipl.C b/src/usr/diag/prdf/plat/prdfPlatServices_ipl.C index 3703de03a..8f5fdb34e 100644 --- a/src/usr/diag/prdf/plat/prdfPlatServices_ipl.C +++ b/src/usr/diag/prdf/plat/prdfPlatServices_ipl.C @@ -37,7 +37,7 @@ #include <prdfErrlUtil.H> #include <prdfTrace.H> -//#include <prdfCenDqBitmap.H> TODO RTC 136126 +//#include <prdfCenDqBitmap.H> TODO RTC 164707 #include <prdfMemScrubUtils.H> #include <diag/mdia/mdia.H> @@ -137,7 +137,7 @@ bool rcdParityErrorReconfigLoop() //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 164707 int32_t mssRestoreDramRepairs( TargetHandle_t i_mbaTarget, uint8_t & o_repairedRankMask, uint8_t & o_badDimmMask ) @@ -165,7 +165,7 @@ int32_t mssRestoreDramRepairs( TargetHandle_t i_mbaTarget, //------------------------------------------------------------------------------ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssIplUeIsolation( TargetHandle_t i_mba, const CenRank & i_rank, CenDqBitmap & o_bitmap ) { @@ -306,7 +306,7 @@ uint32_t startSfRead<TYPE_MBA>( ExtensibleChip * i_mbaChip, } // Start the background scrub command. - PRDF_ERR( PRDF_FUNC "function not implemented yet" ); // TODO RTC 136126 + PRDF_ERR( PRDF_FUNC "function not implemented yet" ); // TODO RTC 157888 } while (0); diff --git a/src/usr/diag/prdf/plat/prdfPlatServices_ipl.H b/src/usr/diag/prdf/plat/prdfPlatServices_ipl.H index 075f47133..5151f11b3 100644 --- a/src/usr/diag/prdf/plat/prdfPlatServices_ipl.H +++ b/src/usr/diag/prdf/plat/prdfPlatServices_ipl.H @@ -77,7 +77,7 @@ bool rcdParityErrorReconfigLoop(); * @param o_badDimm An encoded bitmask of bad DIMMs. * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 164707 int32_t mssRestoreDramRepairs( TARGETING::TargetHandle_t i_mbaTarget, uint8_t & o_repairedRankMask, uint8_t & o_badDimmMask ); @@ -91,7 +91,7 @@ int32_t mssRestoreDramRepairs( TARGETING::TargetHandle_t i_mbaTarget, * @param o_bitmap DQ bitmap container. * @return Non-SUCCESS in internal function fails, SUCCESS otherwise. */ -/* TODO RTC 136126 +/* TODO RTC 157888 int32_t mssIplUeIsolation( TARGETING::TargetHandle_t i_mba, const CenRank & i_rank, CenDqBitmap & o_bitmap ); diff --git a/src/usr/diag/prdf/plat/prdfPlatServices_rt.C b/src/usr/diag/prdf/plat/prdfPlatServices_rt.C index 241344e0a..687fc0b86 100644 --- a/src/usr/diag/prdf/plat/prdfPlatServices_rt.C +++ b/src/usr/diag/prdf/plat/prdfPlatServices_rt.C @@ -211,7 +211,7 @@ uint32_t stopBgScrub<TYPE_MBA>( ExtensibleChip * i_chip ) uint32_t rc = SUCCESS; PRDF_ERR( PRDF_FUNC "function not implemented yet" ); -/* TODO RTC 136126 +/* TODO RTC 157888 // It is safe to create a dummy command object because runtime commands do // not store anything for cleanupCmd() and the stopCmd() function is generic // for all command types. Also, since we are only stopping the command, all |