summaryrefslogtreecommitdiffstats
path: root/src/import/chips/p9/procedures/hwp/memory/lib/dimm
diff options
context:
space:
mode:
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/dimm')
-rw-r--r--src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/data_buffer_ddr4.H4
-rw-r--r--src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/pba.C6
2 files changed, 6 insertions, 4 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/data_buffer_ddr4.H b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/data_buffer_ddr4.H
index 4f1b2525f..d2bffc509 100644
--- a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/data_buffer_ddr4.H
+++ b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/data_buffer_ddr4.H
@@ -176,6 +176,8 @@ inline fapi2::ReturnCode insert_function_space_select(const uint64_t i_func_spac
const std::vector< cw_info >::iterator& i_iterator,
std::vector< cw_info >& io_vector)
{
+ // we use this function for PBA so we need to go with the PBA safe value
+ constexpr uint64_t PBA_SAFE_DELAY = 255;
FAPI_ASSERT(i_func_space <= MAX_FUNC_SPACE,
fapi2::MSS_LRDIMM_INSERT_FUNC_SPACE_OUT_OF_RANGE()
.set_MAX_FUNC_SPACE(MAX_FUNC_SPACE)
@@ -184,7 +186,7 @@ inline fapi2::ReturnCode insert_function_space_select(const uint64_t i_func_spac
i_func_space, MAX_FUNC_SPACE);
{
constexpr uint64_t FUNC_SPACE_LEN = 8;
- cw_info l_info( FUNC_SPACE_0, FUNC_SPACE_SELECT_CW, i_func_space, mss::tmrd(), FUNC_SPACE_LEN, cw_info::BCW );
+ cw_info l_info( FUNC_SPACE_0, FUNC_SPACE_SELECT_CW, i_func_space, PBA_SAFE_DELAY, FUNC_SPACE_LEN, cw_info::BCW );
io_vector.insert(i_iterator, l_info);
}
return fapi2::FAPI2_RC_SUCCESS;
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/pba.C b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/pba.C
index 710fe2cd8..c1cab4997 100644
--- a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/pba.C
+++ b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/pba.C
@@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
-/* Contributors Listed Below - COPYRIGHT 2018 */
+/* Contributors Listed Below - COPYRIGHT 2018,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
@@ -206,8 +206,8 @@ fapi2::ReturnCode execute_commands( const fapi2::Target<fapi2::TARGET_TYPE_DIMM>
l_program.iv_instructions.push_back(mss::ccs::des_command<fapi2::TARGET_TYPE_MCBIST>());
// Makes a copy of the vector, so we can do the function space swaps correctly
- auto l_bcws = convert_to_rcws(i_bcws, commands::BCW_DELAY);
-
+ auto l_bcws = i_bcws;
+ FAPI_TRY(insert_function_space_select(l_bcws));
FAPI_TRY(control_word_engine(i_target,
l_bcws,
OpenPOWER on IntegriCloud