PRDF:Added support for FIR after conclusion of review - part4

Updated action for some pending  bits of following FIR
      - COREFIR
      - TP_LFIR
      - OCCFIR
      - PBAFIR
      - PCINESTFIR

Change-Id: Ie2c5d61372989dc502a77048cc6576c649861f27
RTC:23127
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6095
Reviewed-by: Prem Shanker Jha <premjha2@in.ibm.com>
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/6236
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

3 files changed, 26 insertions, 47 deletions

diff --git a/src/usr/diag/prdf/common/plat/pegasus/Ex.rule b/src/usr/diag/prdf/common/plat/pegasus/Ex.rule
index df44c204b..eea21b9b9 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/Ex.rule
+++ b/src/usr/diag/prdf/common/plat/pegasus/Ex.rule
@@ -545,7 +545,6 @@ group gCoreFir filter singlebit
     /** COREFIR[1]
      *  IF_SETDELETE_ERR: set deleted
      */
-    #FIXME RTC 23127 a comment observed against bit 1
     (CoreFir, bit(1)) ? SelfHighThr1;
 
     /** COREFIR[2]
@@ -571,7 +570,7 @@ group gCoreFir filter singlebit
     /** COREFIR[6]
      *  IF_NOT_MT_REC_ERR: recoverable if not in MT window
      */
-    (CoreFir, bit(6)) ? checkAttnThrldOrCallout;
+    (CoreFir, bit(6)) ? SelfMedThr32PerDay;
 
     /** COREFIR[7]
      *  IF_CHKSTOP_ERR: system check stop
@@ -606,13 +605,11 @@ group gCoreFir filter singlebit
     /** COREFIR[13]
      *  SD_NOT_MT_REC_ERR: recoverable if not in MT window
      */
-    (CoreFir, bit(13)) ? checkAttnThrldOrCallout;
+    (CoreFir, bit(13)) ? SelfMedThr32PerDay;
 
     /** COREFIR[14]
      *  SD_MCHK_AND_ME_EQ_0: MCHK received while ME=0 non recoverable
      */
-    #FIXME RTC 23127  A side note observed against this bit regarding
-    # it's better handling
     (CoreFir, bit(14)) ? SelfHighThr1;
 
     /** COREFIR[15]
@@ -653,7 +650,7 @@ group gCoreFir filter singlebit
     /** COREFIR[22]
      *  FX_NOT_MT_REC_ERR: recoverable if not in MT window
      */
-    (CoreFir, bit(22)) ? checkAttnThrldOrCallout;
+    (CoreFir, bit(22)) ? SelfMedThr32PerDay;
 
     /** COREFIR[23]
      *  VS_VRF_REC_ERR: VRF recoverable error
@@ -693,7 +690,6 @@ group gCoreFir filter singlebit
     /** COREFIR[30]
      *  LS_SETDELETE_ERR: set deleted
      */
-    #FIXME RTC 23127  Observed ??? against this bit in spreadsheet
     (CoreFir, bit(30)) ? SelfHighThr1;
 
     /** COREFIR[31]
@@ -739,12 +735,12 @@ group gCoreFir filter singlebit
     /** COREFIR[39]
      *  LS_NOT_MT_REC_ERR: recoverable if not in MT window
      */
-    (CoreFir, bit(39)) ? checkAttnThrldOrCallout;
+    (CoreFir, bit(39)) ? SelfMedThr32PerDay;
 
     /** COREFIR[40]
      *  LS_NOT_CI_REC_ERR: recoverable if not in CI window
      */
-    (CoreFir, bit(40)) ? checkAttnThrldOrCallout;
+    (CoreFir, bit(40)) ? SelfMedThr32PerDay;
 
     /** COREFIR[41]
      *  LS_CHKSTOP_ERR: system check stop
@@ -849,7 +845,6 @@ group gCoreFir filter singlebit
     /** COREFIR[63]
      *  SPRD_PHYP_ERR_INJ: Phyp Xstop via SPRC / SPRD
      */
-    #FIXME RTC 23127  Needto clarify action Chip+SW Level 2IPP
     (CoreFir, bit(63)) ? callout2ndLvlMed;
 };
 
@@ -1529,15 +1524,6 @@ actionclass spareOrSelfHighThr1
     TBDDefaultCallout;
 };
 
-/** if attention is recoverable then threshold else callout and gard on first
- * instance*/
-
-actionclass checkAttnThrldOrCallout
-{
-    #FIXME RTC 23127 Need to clarify what is Threshold B
-    TBDDefaultCallout;
-};
-
 /** callout connected parent proc with high priority.*/
 actionclass calloutParentProcHigh
 {
diff --git a/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_PB.rule b/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_PB.rule
index 758bee5cb..7f6e49093 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_PB.rule
+++ b/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_PB.rule
@@ -1891,8 +1891,6 @@ group gPbaFir filter singlebit
     /** PBAFIR[3]
      *  PBAFIR_PB_SUE_FW
      */
-     # FIXME RTC 23127 Foreign Link shall be removed. It shall be changed to
-     # Chip + Level2 in spread sheet.
     (PbaFir, bit(3)) ? calloutProcLevel2MedThr1;
 
     /** PBAFIR[4]
@@ -2315,18 +2313,17 @@ group gPciNestFir filter singlebit
     /** PCINESTFIR_0[1]
      *  NONBAR_PE
      */
-    # FIXME RTC 23127 Should Phyp Threshold
-    (PciNestFir_0, bit(1)) ? TBDDefaultCallout;
+    (PciNestFir_0, bit(1)) ? calloutConnPci0Th32;
 
     /** PCINESTFIR_1[1]
      *  NONBAR_PE
      */
-    (PciNestFir_1, bit(1)) ? TBDDefaultCallout;
+    (PciNestFir_1, bit(1)) ? calloutConnPci1Th32;
 
     /** PCINESTFIR_2[1]
      *  NONBAR_PE
      */
-    (PciNestFir_2, bit(1)) ? TBDDefaultCallout;
+    (PciNestFir_2, bit(1)) ? calloutConnPci2Th32;
 
     /** PCINESTFIR_0[2]
      *  PB_TO_PEC_CE
@@ -2651,18 +2648,17 @@ group gPciNestFir filter singlebit
     /** PCINESTFIR_0[23]
      *  AIB_PE
      */
-    # FIXME RTC 23127 Should Phyp Threshold ?
-    (PciNestFir_0, bit(23)) ? TBDDefaultCallout;
+    (PciNestFir_0, bit(23)) ? calloutConnPci0Th32;
 
     /** PCINESTFIR_1[23]
      *  AIB_PE
      */
-    (PciNestFir_1, bit(23)) ? TBDDefaultCallout;
+    (PciNestFir_1, bit(23)) ? calloutConnPci1Th32;
 
     /** PCINESTFIR_2[23]
      *  AIB_PE
      */
-    (PciNestFir_2, bit(23)) ? TBDDefaultCallout;
+    (PciNestFir_2, bit(23)) ? calloutConnPci2Th32;
 
     /** PCINESTFIR_0[24]
      *  ASB_ERROR
@@ -2682,50 +2678,47 @@ group gPciNestFir filter singlebit
     /** PCINESTFIR_0[25]
      *  FOREIGN_LINK_FAIL
      */
-     # FIXME RTC 23127 Action TBD
-    (PciNestFir_0, bit(25)) ? TBDDefaultCallout;
+    (PciNestFir_0, bit(25)) ? defaultMaskedError;
 
     /** PCINESTFIR_1[25]
      *  FOREIGN_LINK_FAIL
      */
-    (PciNestFir_1, bit(25)) ? TBDDefaultCallout;
+    (PciNestFir_1, bit(25)) ? defaultMaskedError;
 
     /** PCINESTFIR_2[25]
      *  FOREIGN_LINK_FAIL
      */
-    (PciNestFir_2, bit(25)) ? TBDDefaultCallout;
+    (PciNestFir_2, bit(25)) ? defaultMaskedError;
 
     /** PCINESTFIR_0[26]
      *  FOREIGN_PB_HANG
      */
-    # FIXME RTC 23127 Action TBD
-    (PciNestFir_0, bit(26)) ? TBDDefaultCallout;
+    (PciNestFir_0, bit(26)) ? defaultMaskedError;
 
     /** PCINESTFIR_1[26]
      *  FOREIGN_PB_HANG
      */
-    (PciNestFir_1, bit(26)) ? TBDDefaultCallout;
+    (PciNestFir_1, bit(26)) ? defaultMaskedError;
 
     /** PCINESTFIR_2[26]
      *  FOREIGN_PB_HANG
      */
-    (PciNestFir_2, bit(26)) ? TBDDefaultCallout;
+    (PciNestFir_2, bit(26)) ? defaultMaskedError;
 
     /** PCINESTFIR_0[27]
      *  CAPP_ERROR
      */
-    # FIXME RTC 23127 Action TBD
-    (PciNestFir_0, bit(27)) ? TBDDefaultCallout;
+    (PciNestFir_0, bit(27)) ? defaultMaskedError;
 
     /** PCINESTFIR_1[27]
      *  CAPP_ERROR
      */
-    (PciNestFir_1, bit(27)) ? TBDDefaultCallout;
+    (PciNestFir_1, bit(27)) ? defaultMaskedError;
 
     /** PCINESTFIR_2[27]
      *  CAPP_ERROR
      */
-    (PciNestFir_2, bit(27)) ? TBDDefaultCallout;
+    (PciNestFir_2, bit(27)) ? defaultMaskedError;
 
     /** PCINESTFIR_0[28]
      *  SYNC_SCOM_ERR
@@ -3098,6 +3091,10 @@ actionclass callout2ndLvlMedThr1
  */
 actionclass  calloutPsiThr32
 {
+#FIXME RTC 23127 Discussion in progress on this.Based on the outcome of
+# discussion, there are chances that we may replace this and calloutPsiThr1
+# with default masked error.
+
     calloutPsiLink;
     threshold32pday;
 };
diff --git a/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_TP.rule b/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_TP.rule
index 270119600..976f1c3ad 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_TP.rule
+++ b/src/usr/diag/prdf/common/plat/pegasus/Proc_acts_TP.rule
@@ -224,8 +224,6 @@ group gTpLFir filter singlebit
     /** TP_LFIR[10]
      *  Local errors from Trace Array ( error)
      */
-    #FIXME RTC 23127 bit action suggests threshold 32per day but commnet on bit
-    # 10 suggests threshold of 1
     (TpLFir, bit(10)) ? SelfHighThr32PerDay;
 
     /** TP_LFIR[11]
@@ -241,7 +239,6 @@ group gTpLFir filter singlebit
     /** TP_LFIR[14]
      *  Local errors from PCB
      */
-    #FIXME RTC 23127 Comments not clear
     (TpLFir, bit(14)) ? SelfHighThr32PerDay;
 
     /** TP_LFIR[15]
@@ -355,7 +352,7 @@ rule OccFir
     SPECIAL:     OCCFIR & ~OCCFIR_MASK &  OCCFIR_ACT0 & ~OCCFIR_ACT1;
 };
 
-#based on spreadsheet p8dd1_mss_FFDC_51.xls
+#based on spreadsheet p8dd1_mss_FFDC_51/60.xls
 group gOccFir filter singlebit
 {
     /** OCCFIR[0]
@@ -381,8 +378,7 @@ group gOccFir filter singlebit
     /** OCCFIR[4]
      *  OCC_SCOM_OCCFIR_PMC_PORE_SW_MALF
      */
-    #RTC 23127 ? found in RAS spread sheet.Action need to be updated.
-    (OccFir, bit(4)) ? TBDDefaultCallout;
+    (OccFir, bit(4)) ? defaultMaskedError;
 
     /** OCCFIR[5]
      *  OCC_SCOM_OCCFIR_PMC_OCC_HB_MALF