summaryrefslogtreecommitdiffstats
path: root/src/usr
diff options
context:
space:
mode:
authorMike Jones <mjjones@us.ibm.com>2012-10-29 08:28:02 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2012-11-03 15:09:43 -0500
commit73b2637b406c590ba797e7f85308c146d2807f36 (patch)
tree682fd467521f853bb0e7cc1d52fa54972091315f /src/usr
parente73ffc9f16acad1f1fb69839322bc7f41ac4e11c (diff)
downloadtalos-hostboot-73b2637b406c590ba797e7f85308c146d2807f36.tar.gz
talos-hostboot-73b2637b406c590ba797e7f85308c146d2807f36.zip
HWPF: Improve tracing for initfile attribute get error
Change-Id: I54dea3e2fc57eef1832b25bbb9300d6771fdc439 Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/2156 Reviewed-by: Brian H. Horton <brianh@linux.ibm.com> Tested-by: Jenkins Server Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr')
-rwxr-xr-xsrc/usr/hwpf/fapi/fapiCreateIfAttrService.pl14
1 files changed, 12 insertions, 2 deletions
diff --git a/src/usr/hwpf/fapi/fapiCreateIfAttrService.pl b/src/usr/hwpf/fapi/fapiCreateIfAttrService.pl
index 89c110c9d..7de6215d8 100755
--- a/src/usr/hwpf/fapi/fapiCreateIfAttrService.pl
+++ b/src/usr/hwpf/fapi/fapiCreateIfAttrService.pl
@@ -39,6 +39,7 @@
# mjjones 02/08/12 Handle attribute files with 1 entry
# mjjones 06/12/12 Handle privileged attributes
# mjjones 09/28/12 Minor change to add FFDC on error
+# mjjones 10/26/12 Output attrId/targType on error
#
# End Change Log ******************************************************
@@ -281,13 +282,22 @@ if ($attCount > 0)
print ASFILE " else\n";
}
print ASFILE " {\n";
-print ASFILE " FAPI_ERR(\"fapiGetInitFileAttr: Unrecognized attr: %d\", i_id);\n";
+print ASFILE " FAPI_ERR(\"fapiGetInitFileAttr: Unrecognized attr ID: 0x%x\", i_id);\n";
print ASFILE " l_rc.setFapiError(FAPI_RC_INVALID_ATTR_GET);\n";
print ASFILE " l_rc.addEIFfdc(0, &i_id, sizeof(i_id));\n";
print ASFILE " }\n\n";
print ASFILE " if (l_rc)\n";
print ASFILE " {\n";
-print ASFILE " FAPI_ERR(\"fapiGetInitFileAttr: Error getting attr\");\n";
+print ASFILE " if (i_pTarget)\n";
+print ASFILE " {\n";
+print ASFILE " FAPI_ERR(\"fapiGetInitFileAttr: Error getting attr ID 0x%x from targType 0x%x\",\n";
+print ASFILE " i_id, i_pTarget->getType());\n";
+print ASFILE " }\n";
+print ASFILE " else\n";
+print ASFILE " {\n";
+print ASFILE " FAPI_ERR(\"fapiGetInitFileAttr: Error getting attr ID 0x%x from system target\",\n";
+print ASFILE " i_id);\n";
+print ASFILE " }\n";
print ASFILE " }\n\n";
print ASFILE " return l_rc;\n";
print ASFILE "}\n\n";
OpenPOWER on IntegriCloud