diff options
author | Prachi Gupta <pragupta@us.ibm.com> | 2015-11-13 10:35:37 -0600 |
---|---|---|
committer | Patrick Williams <iawillia@us.ibm.com> | 2015-12-11 15:30:28 -0600 |
commit | 3273e7387ba43cce84e8431acc414a943a687f36 (patch) | |
tree | 2de7206a9aa6e2b7a6cc134de09d6afc4ee68ab4 /src/usr | |
parent | b06ecf7fa73668849af09d5f4a372629516f3565 (diff) | |
download | talos-hostboot-3273e7387ba43cce84e8431acc414a943a687f36.tar.gz talos-hostboot-3273e7387ba43cce84e8431acc414a943a687f36.zip |
Remove all compile dependencies on old fapi
Change-Id: Ia1633645fe2b294fecd15a8ede67983b86d3549c
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/22283
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr')
-rw-r--r-- | src/usr/devtree/bld_devtree.C | 10 | ||||
-rw-r--r-- | src/usr/hwas/test/hwas1test.H | 4 | ||||
-rw-r--r-- | src/usr/initservice/extinitsvc/extinitsvctasks.H | 96 | ||||
-rw-r--r-- | src/usr/initservice/istepdispatcher/istepdispatcher.C | 24 | ||||
-rw-r--r-- | src/usr/isteps/istep08/call_host_slave_sbe_config.C | 5 | ||||
-rw-r--r-- | src/usr/isteps/istep09/call_host_startprd_pbus.C | 4 | ||||
-rw-r--r-- | src/usr/isteps/istep10/call_host_slave_sbe_update.C | 4 | ||||
-rw-r--r-- | src/usr/makefile | 9 | ||||
-rw-r--r-- | src/usr/mbox/ipcSp.C | 7 | ||||
-rw-r--r-- | src/usr/runtime/hdatservice.C | 3 | ||||
-rw-r--r-- | src/usr/runtime/makefile | 14 | ||||
-rw-r--r-- | src/usr/runtime/test/makefile | 15 | ||||
-rw-r--r-- | src/usr/scom/runtime/handleSpecialWakeup.C | 9 | ||||
-rw-r--r-- | src/usr/targeting/attrPlatOverride.C | 10 | ||||
-rw-r--r-- | src/usr/targeting/common/test/testcommontargeting.H | 14 | ||||
-rw-r--r-- | src/usr/targeting/makefile | 3 | ||||
-rw-r--r-- | src/usr/targeting/runtime/attrPlatOverride_rt.C | 8 | ||||
-rw-r--r-- | src/usr/targeting/runtime/makefile | 3 | ||||
-rw-r--r-- | src/usr/targeting/test/makefile | 4 | ||||
-rw-r--r-- | src/usr/targeting/test/testtargeting.H | 12 |
20 files changed, 103 insertions, 155 deletions
diff --git a/src/usr/devtree/bld_devtree.C b/src/usr/devtree/bld_devtree.C index 5c06a666d..aca3f3562 100644 --- a/src/usr/devtree/bld_devtree.C +++ b/src/usr/devtree/bld_devtree.C @@ -49,8 +49,10 @@ #include <i2c/i2cif.H> #include <i2c/eepromif.H> #include <ipmi/ipmisensor.H> -#include <fapi.H> -#include <fapiPlatHwpInvoker.H> // for fapi::fapiRcToErrl() + +//@TODO RTC:143092 +//#include <fapi.H> +//#include <fapiPlatHwpInvoker.H> // for fapi::fapiRcToErrl() #include <vpd/mvpdenums.H> trace_desc_t *g_trac_devtree = NULL; @@ -1944,6 +1946,9 @@ errlHndl_t bld_fdt_vpd(devTree * i_dt, bool i_smallTree) /***************************************************************/ /* Add the #V bucket for each functional core */ /***************************************************************/ + + //@TODO RTC:143092 +#if 0 TARGETING::TargetHandleList l_exlist; fapi::Target l_pFapiProc(fapi::TARGET_TYPE_PROC_CHIP, (const_cast<TARGETING::Target*>(l_pProc) )); @@ -1988,6 +1993,7 @@ errlHndl_t bld_fdt_vpd(devTree * i_dt, bool i_smallTree) { break; } +#endif } if(errhdl) { diff --git a/src/usr/hwas/test/hwas1test.H b/src/usr/hwas/test/hwas1test.H index cb102e3f3..0d5822c8c 100644 --- a/src/usr/hwas/test/hwas1test.H +++ b/src/usr/hwas/test/hwas1test.H @@ -41,10 +41,6 @@ // CXXTEST #include <cxxtest/TestSuite.H> -#include <hwpf/plat/fapiPlatAttributeService.H> -#include <fapiReturnCode.H> -#include <fapiAttributeIds.H> -#include <fapiAttributeService.H> #include <errl/errlmanager.H> #include <hwas/common/hwas.H> diff --git a/src/usr/initservice/extinitsvc/extinitsvctasks.H b/src/usr/initservice/extinitsvc/extinitsvctasks.H index 959f19b68..964649179 100644 --- a/src/usr/initservice/extinitsvc/extinitsvctasks.H +++ b/src/usr/initservice/extinitsvc/extinitsvctasks.H @@ -240,89 +240,8 @@ const TaskInfo g_exttaskinfolist[] = { EXT_IMAGE, // Extended Module } }, - /** - * @brief ecmddatabuffer task, - */ - { - "libecmddatabuffer.so" , // taskname - NULL, // no pointer to fn - { - INIT_TASK, // task type - EXT_IMAGE, // Extended Module - } - }, - - /** - * @brief fapi task, - */ - { - "libfapi.so" , // taskname - NULL, // no pointer to fn - { - INIT_TASK, // task type - EXT_IMAGE, // Extended Module - } - }, - - /** - * @brief hwp task, - */ - { - "libhwp.so" , // taskname - NULL, // no pointer to fn - { - INIT_TASK, // task type - EXT_IMAGE, // Extended Module - } - }, - - /** - * @brief plat task, - */ - { - "libplat.so" , // taskname - NULL, // no pointer to fn - { - START_TASK, // task type - EXT_IMAGE, // Extended Module - } - }, - // @todo RTC:137627 - remove for p9 bringup #if (0) - /** - * @brief Start slave threads - */ - { - "libthread_activate.so" , // taskname - NULL, // no pointer to fn - { - START_TASK, // task type - EXT_IMAGE, // Extended Module - } - }, - { - "libthread_activate.so" , // taskname - NULL, // no pointer to fn - { - UNINIT_TASK, // task type - EXT_IMAGE, // Extended Module - } - }, -#endif - - /** - * @brief bus_training library. - */ - { - "libbus_training.so", // library name - NULL, // no function to run - { - INIT_TASK, // init only - EXT_IMAGE, // extended image module - } - }, - // No mdia in VPO #ifndef CONFIG_VPO_COMPILE /** @@ -362,6 +281,7 @@ const TaskInfo g_exttaskinfolist[] = { } }, +#endif #ifdef CONFIG_GPIODD /** * @brief GPIO code library @@ -390,7 +310,19 @@ const TaskInfo g_exttaskinfolist[] = { }, #endif - + /** + * @brief Common istep functions + * + * + */ + { + "libisteps.so" , // taskname + NULL, // no pointer to fn + { + INIT_TASK, // task type + EXT_IMAGE, // Extended Module + } + }, // !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! // NOTE: libistepdisp.so needs to always be last in this list!! diff --git a/src/usr/initservice/istepdispatcher/istepdispatcher.C b/src/usr/initservice/istepdispatcher/istepdispatcher.C index 79fadae42..0fd9d5f94 100644 --- a/src/usr/initservice/istepdispatcher/istepdispatcher.C +++ b/src/usr/initservice/istepdispatcher/istepdispatcher.C @@ -48,7 +48,8 @@ #include <targeting/common/targetservice.H> #include <targeting/attrsync.H> #include <establish_system_smp.H> -#include <hwpf/plat/fapiPlatAttributeService.H> +//@TODO RTC:128106 port to fapi2 plat attribute service +//#include <hwpf/plat/fapiPlatAttributeService.H> #include <mbox/mbox_queues.H> // HB_ISTEP_MSGQ #include <mbox/mboxif.H> // register mailbox #include <intr/interrupt.H> @@ -275,7 +276,8 @@ void IStepDispatcher::init(errlHndl_t &io_rtaskRetErrl) if (l_attrOverridesExist) { - fapi::theAttrOverrideSync().getAttrOverridesFromFsp(); + //@TODO RTC:128106 port to fapi2 plat attribute service + //fapi::theAttrOverrideSync().getAttrOverridesFromFsp(); } // Start a new thread to handle non-IStep messages from the FSP @@ -342,7 +344,8 @@ void IStepDispatcher::init(errlHndl_t &io_rtaskRetErrl) // Attributes to sync to the FSP if(iv_spBaseServicesEnabled) { - fapi::theAttrOverrideSync().sendAttrOverridesAndSyncsToFsp(); + //@TODO RTC:128106 port to fapi2 plat attribute service + //fapi::theAttrOverrideSync().sendAttrOverridesAndSyncsToFsp(); } } } while(0); @@ -1574,7 +1577,8 @@ void IStepDispatcher::handleIStepRequestMsg(msg_t * & io_pMsg) // Send the potentially modified set of Attribute overrides and any // Attributes to sync (to Cronus) to the FSP - fapi::theAttrOverrideSync().sendAttrOverridesAndSyncsToFsp(); + //@TODO RTC:128106 port to fapi2 plat attribute service + //fapi::theAttrOverrideSync().sendAttrOverridesAndSyncsToFsp(); // Transfer ownership of the message pointer back from iv_pIstepMsg mutex_lock(&iv_mutex); @@ -1676,8 +1680,10 @@ void IStepDispatcher::handleProcFabIovalidMsg(msg_t * & io_pMsg) // Create child thread so that if there are problems, the istep // dispatcher code continues - tid_t l_progTid = task_create( - ESTABLISH_SYSTEM_SMP::host_sys_fab_iovalid_processing,io_pMsg); + // @TODO RTC:133831 + //tid_t l_progTid = task_create( + // ESTABLISH_SYSTEM_SMP::host_sys_fab_iovalid_processing,io_pMsg); + tid_t l_progTid = 1; assert( l_progTid > 0 ); // wait here for the task to end. // status of the task ( OK or Crashed ) is returned in l_childsts @@ -1733,7 +1739,8 @@ void IStepDispatcher::handleProcFabIovalidMsg(msg_t * & io_pMsg) } // Re-enable p8_cpu_special_wakeup - err = ESTABLISH_SYSTEM_SMP::enableSpecialWakeup(); + // @TODO RTC:133831 + //err = ESTABLISH_SYSTEM_SMP::enableSpecialWakeup(); if (err) { TRACFCOMP( g_trac_initsvc, @@ -2011,7 +2018,8 @@ errlHndl_t IStepDispatcher::handleCoalesceHostMsg() } else { - err = ESTABLISH_SYSTEM_SMP::call_host_coalesce_host(); + //@TODO RTC:133831 + //err = ESTABLISH_SYSTEM_SMP::call_host_coalesce_host(); if (err) { TRACFCOMP(g_trac_initsvc, "handleCoalesceHostMsg: Error with " diff --git a/src/usr/isteps/istep08/call_host_slave_sbe_config.C b/src/usr/isteps/istep08/call_host_slave_sbe_config.C index ee4ba9480..322038448 100644 --- a/src/usr/isteps/istep08/call_host_slave_sbe_config.C +++ b/src/usr/isteps/istep08/call_host_slave_sbe_config.C @@ -187,6 +187,8 @@ void* call_host_slave_sbe_config(void *io_pArgs) } // Resolve the side characteristics of the Processor SBE Seeproms +#if 0 + //@TODO RTC:142091 errlHndl_t err = SBE::resolveProcessorSbeSeeproms(); if ( err ) { @@ -196,8 +198,7 @@ void* call_host_slave_sbe_config(void *io_pArgs) // Commit Error errlCommit( err, HWPF_COMP_ID ); } - - +#endif TRACDCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "call_host_slave_sbe_config exit" ); diff --git a/src/usr/isteps/istep09/call_host_startprd_pbus.C b/src/usr/isteps/istep09/call_host_startprd_pbus.C index a3d0b6b18..c4e6d13a8 100644 --- a/src/usr/isteps/istep09/call_host_startprd_pbus.C +++ b/src/usr/isteps/istep09/call_host_startprd_pbus.C @@ -6,6 +6,7 @@ /* OpenPOWER HostBoot Project */ /* */ /* Contributors Listed Below - COPYRIGHT 2012,2015 */ +/* [+] Google Inc. */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -87,7 +88,8 @@ void* call_host_startprd_pbus( void *io_pArgs ) do { - l_errl = PRDF::initialize(); + //@TODO RTC:134079 + //l_errl = PRDF::initialize(); if (l_errl) { TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace, diff --git a/src/usr/isteps/istep10/call_host_slave_sbe_update.C b/src/usr/isteps/istep10/call_host_slave_sbe_update.C index 4a82043cc..1d466a820 100644 --- a/src/usr/isteps/istep10/call_host_slave_sbe_update.C +++ b/src/usr/isteps/istep10/call_host_slave_sbe_update.C @@ -6,6 +6,7 @@ /* OpenPOWER HostBoot Project */ /* */ /* Contributors Listed Below - COPYRIGHT 2015 */ +/* [+] Google Inc. */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -69,7 +70,8 @@ void* call_host_slave_sbe_update (void *io_pArgs) // Call to check state of Processor SBE SEEPROMs and // make any necessary updates - l_errl = SBE::updateProcessorSbeSeeproms(); + // @TODO RTC:142091 add it after SBE is ported to fapi2 + //l_errl = SBE::updateProcessorSbeSeeproms(); if (l_errl) { diff --git a/src/usr/makefile b/src/usr/makefile index 1f7362c1e..0e5f18806 100644 --- a/src/usr/makefile +++ b/src/usr/makefile @@ -40,8 +40,6 @@ SUBDIRS += scom.d SUBDIRS += xscom.d SUBDIRS += targeting.d SUBDIRS += initservice.d -SUBDIRS += hwpf.d -SUBDIRS += ecmddatabuffer.d SUBDIRS += pnor.d SUBDIRS += i2c.d SUBDIRS += vfs.d @@ -49,10 +47,8 @@ SUBDIRS += fsi.d SUBDIRS += hwas.d SUBDIRS += fsiscom.d SUBDIRS += intr.d -SUBDIRS += pore.d SUBDIRS += util.d SUBDIRS += mbox.d -SUBDIRS += diag.d SUBDIRS += vpd.d SUBDIRS += scan.d SUBDIRS += runtime.d @@ -60,12 +56,13 @@ SUBDIRS += ibscom.d SUBDIRS += dump.d SUBDIRS += secureboot.d SUBDIRS += devtree.d -SUBDIRS += sbe.d +#@TODO RTC:142091 +#SUBDIRS += sbe.d SUBDIRS += gpio.d SUBDIRS += lpc.d SUBDIRS += console.d SUBDIRS += errldisplay.d SUBDIRS += ipmi.d -SUBDIRS += htmgt.d +#SUBDIRS += htmgt.d include ${ROOTPATH}/config.mk diff --git a/src/usr/mbox/ipcSp.C b/src/usr/mbox/ipcSp.C index 6f86f7962..f2f3cd26e 100644 --- a/src/usr/mbox/ipcSp.C +++ b/src/usr/mbox/ipcSp.C @@ -112,10 +112,11 @@ void IpcSp::msgHandler() } if(!err) { - RUNTIME::setPayloadBaseAddress - (reinterpret_cast<uint64_t>(msg->extra_data)); + //@TODO RTC:132750 + //RUNTIME::setPayloadBaseAddress + // (reinterpret_cast<uint64_t>(msg->extra_data)); - err = RUNTIME::populate_node_attributes( msg->data[0] ); + //err = RUNTIME::populate_node_attributes( msg->data[0] ); } if (err) diff --git a/src/usr/runtime/hdatservice.C b/src/usr/runtime/hdatservice.C index 0084a54fe..4f3a94fb7 100644 --- a/src/usr/runtime/hdatservice.C +++ b/src/usr/runtime/hdatservice.C @@ -41,7 +41,8 @@ //#define REAL_HDAT_TEST -extern trace_desc_t* g_trac_runtime; +trace_desc_t *g_trac_runtime = NULL; +TRAC_INIT(&g_trac_runtime, RUNTIME_COMP_NAME, KILOBYTE); #define TRACUCOMP TRACDCOMP diff --git a/src/usr/runtime/makefile b/src/usr/runtime/makefile index d1ab8bc1b..e8ecca91c 100644 --- a/src/usr/runtime/makefile +++ b/src/usr/runtime/makefile @@ -5,7 +5,9 @@ # # OpenPOWER HostBoot Project # -# COPYRIGHT International Business Machines Corp. 2012,2014 +# Contributors Listed Below - COPYRIGHT 2012,2015 +# [+] International Business Machines Corp. +# # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -30,8 +32,8 @@ ROOTPATH = ../../.. MODULE = runtime - -OBJS += populate_attributes.o +#@TODO RTC:132750 +#OBJS += populate_attributes.o OBJS += hdatservice.o OBJS += fakepayload.o OBJS += tce.o @@ -39,10 +41,4 @@ OBJS += errlud_hdat.o SUBDIRS += test.d -## support for fapi -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/ecmddatabuffer -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/hwpf/fapi -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/hwpf/plat -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/hwpf/hwp - include ${ROOTPATH}/config.mk diff --git a/src/usr/runtime/test/makefile b/src/usr/runtime/test/makefile index 5833f8092..a0a1c5c5c 100644 --- a/src/usr/runtime/test/makefile +++ b/src/usr/runtime/test/makefile @@ -5,7 +5,9 @@ # # OpenPOWER HostBoot Project # -# COPYRIGHT International Business Machines Corp. 2012,2014 +# Contributors Listed Below - COPYRIGHT 2012,2015 +# [+] International Business Machines Corp. +# # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -23,13 +25,12 @@ ROOTPATH = ../../../.. MODULE = testruntime -TESTS = *.H +TESTS += hdatservicetest.H +TESTS += tcetest.H + +#@TODO RTC:132750 +#TESTS += runtimeattrtest.H -# support for fapi -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/ecmddatabuffer -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/hwpf/fapi -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/hwpf/plat -EXTRAINCDIR += ${ROOTPATH}/src/include/usr/hwpf/hwp EXTRAINCDIR += ${ROOTPATH}/src/include/usr/runtime/ include ${ROOTPATH}/config.mk diff --git a/src/usr/scom/runtime/handleSpecialWakeup.C b/src/usr/scom/runtime/handleSpecialWakeup.C index e62721d5b..0a97b41dd 100644 --- a/src/usr/scom/runtime/handleSpecialWakeup.C +++ b/src/usr/scom/runtime/handleSpecialWakeup.C @@ -1,11 +1,12 @@ /* IBM_PROLOG_BEGIN_TAG */ /* This is an automatically generated prolog. */ /* */ -/* $Source: src/usr/scom/disableSW.C $ */ +/* $Source: src/usr/scom/runtime/handleSpecialWakeup.C $ */ /* */ /* OpenPOWER HostBoot Project */ /* */ /* Contributors Listed Below - COPYRIGHT 2015 */ +/* [+] Google Inc. */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -33,9 +34,6 @@ #include <targeting/common/utilFilter.H> #include <targeting/common/util.H> -#include <fapi.H> -#include <fapiPlatHwpInvoker.H> -#include "p8_cpu_special_wakeup.H" extern "C" { @@ -51,6 +49,8 @@ errlHndl_t handleSpecialWakeup(TARGETING::Target* i_exTarget, { errlHndl_t l_errl = NULL; + //@TODO RTC:132413 Add it back once we have fapi2 support +#if 0 fapi::Target l_fapi_ex_target(TARGET_TYPE_EX_CHIPLET, (const_cast<TARGETING::Target*>(i_exTarget)) ); @@ -84,6 +84,7 @@ errlHndl_t handleSpecialWakeup(TARGETING::Target* i_exTarget, // capture the target data in the elog ERRORLOG::ErrlUserDetailsTarget(i_exTarget).addToLog( l_errl ); } +#endif return l_errl; } diff --git a/src/usr/targeting/attrPlatOverride.C b/src/usr/targeting/attrPlatOverride.C index 9368c4af1..2b11fbd5e 100644 --- a/src/usr/targeting/attrPlatOverride.C +++ b/src/usr/targeting/attrPlatOverride.C @@ -23,7 +23,8 @@ /* */ /* IBM_PROLOG_END_TAG */ #include <targeting/attrPlatOverride.H> -#include <hwpf/plat/fapiPlatAttrOverrideSync.H> +//@TODO RTC:128106 +//#include <hwpf/plat/fapiPlatAttrOverrideSync.H> #include <targeting/common/trace.H> #include <targeting/common/targreasoncodes.H> #include <errl/errlmanager.H> @@ -37,9 +38,9 @@ errlHndl_t getAttrOverrides(PNOR::SectionInfo_t &i_sectionInfo, TRACFCOMP(g_trac_targeting,"attrPlatOverride::getAttrOverrides ENTER"); // Create local permanent override tank and array of tanks + errlHndl_t l_err = NULL; AttributeTank l_PermTank; AttributeTank* l_overTanks[AttributeTank::TANK_LAYER_LAST]; - errlHndl_t l_err = NULL; // Local pointer to array containing each tank layer or io_tanks AttributeTank* *l_pOverTanks; @@ -49,8 +50,9 @@ errlHndl_t getAttrOverrides(PNOR::SectionInfo_t &i_sectionInfo, if (io_tanks == NULL) { // All indexes are -1 due to the first enum being TANK_LAYER_NONE, - l_overTanks[AttributeTank::TANK_LAYER_FAPI-1] = - &fapi::theAttrOverrideSync().iv_overrideTank; + //@TODO RTC:128106 + //l_overTanks[AttributeTank::TANK_LAYER_FAPI-1] = + // &fapi::theAttrOverrideSync().iv_overrideTank; l_overTanks[AttributeTank::TANK_LAYER_TARG-1] = &Target::theTargOverrideAttrTank(); l_overTanks[AttributeTank::TANK_LAYER_PERM-1] = &l_PermTank; diff --git a/src/usr/targeting/common/test/testcommontargeting.H b/src/usr/targeting/common/test/testcommontargeting.H index 6bb22857c..1a61da3ea 100644 --- a/src/usr/targeting/common/test/testcommontargeting.H +++ b/src/usr/targeting/common/test/testcommontargeting.H @@ -41,10 +41,6 @@ #include <sys/time.h> // CXXTEST -#include <hwpf/plat/fapiPlatAttributeService.H> -#include <fapiReturnCode.H> -#include <fapiAttributeIds.H> -#include <fapiAttributeService.H> #include <targeting/common/error.H> // This component @@ -1298,7 +1294,6 @@ class CommonTargetingTestSuite: public CxxTest::TestSuite TARG_TS_TRACE(INFO_MRK "Now using direct access macros"); using namespace TARGETING; - using namespace fapi; TargetService& l_targetService = targetService(); @@ -1345,6 +1340,9 @@ class CommonTargetingTestSuite: public CxxTest::TestSuite TARG_TS_TRACE(INFO_MRK "Now using FAPI get macros"); memset(l_dummyRw,0x00,sizeof(l_dummyRw)); + +#if 0 + //@TODO RTC:142602 fapi::ReturnCode l_rc = FAPI_ATTR_GET( ATTR_DUMMY_SCRATCH_PLAT_INIT_UINT8, NULL, l_dummyRw); if(l_rc != 0) @@ -1361,6 +1359,7 @@ class CommonTargetingTestSuite: public CxxTest::TestSuite TARG_TS_TRACE(INFO_MRK "Now using FAPI set macros"); l_dummyRw[0][2][3] = 6; + l_rc = FAPI_ATTR_SET(ATTR_DUMMY_SCRATCH_PLAT_INIT_UINT8, NULL, l_dummyRw); if(l_rc != 0) @@ -1392,7 +1391,7 @@ class CommonTargetingTestSuite: public CxxTest::TestSuite { TARG_TS_FAIL("Node 0 target handle should not be NULL"); } - + //@TODO RTC:142602 fapi::Target* l_pFapiTarget = new fapi::Target( fapi::TARGET_TYPE_PROC_CHIP, l_pTarget); l_rc = FAPI_ATTR_GET(ATTR_DUMMY_SCRATCH_PLAT_INIT_UINT8, @@ -1406,13 +1405,13 @@ class CommonTargetingTestSuite: public CxxTest::TestSuite { TARG_TS_FAIL("Should have been a platform handled error"); } - // The error log will get deleted when the ReturnCode is destructed. The // error log is not committed here to avoid it getting interpreted as a // real problem delete l_pFapiTarget; l_pFapiTarget = NULL; +#endif TARG_TS_TRACE(EXIT_MRK "testFapiToHbMacros" ); } @@ -1422,7 +1421,6 @@ class CommonTargetingTestSuite: public CxxTest::TestSuite TARG_TS_TRACE(ENTER_MRK "testPodNumericalTypes" ); using namespace TARGETING; - using namespace fapi; TargetService& l_targetService = targetService(); diff --git a/src/usr/targeting/makefile b/src/usr/targeting/makefile index eaa6dbb8d..5330b963c 100644 --- a/src/usr/targeting/makefile +++ b/src/usr/targeting/makefile @@ -65,7 +65,8 @@ OBJS += ${HOSTBOOT_SPECIFIC_OBJS} SUBDIRS += test.d SUBDIRS += xmltohb.d SUBDIRS += runtime.d -SUBDIRS += attroverride.d +#@TODO RTC:128106 +#SUBDIRS += attroverride.d include ${ROOTPATH}/config.mk diff --git a/src/usr/targeting/runtime/attrPlatOverride_rt.C b/src/usr/targeting/runtime/attrPlatOverride_rt.C index 98d063fa0..9a5498111 100644 --- a/src/usr/targeting/runtime/attrPlatOverride_rt.C +++ b/src/usr/targeting/runtime/attrPlatOverride_rt.C @@ -1,7 +1,7 @@ /* IBM_PROLOG_BEGIN_TAG */ /* This is an automatically generated prolog. */ /* */ -/* $Source: src/usr/targeting/attrPlatOverride.C $ */ +/* $Source: src/usr/targeting/runtime/attrPlatOverride_rt.C $ */ /* */ /* OpenPOWER HostBoot Project */ /* */ @@ -27,7 +27,8 @@ #include <runtime/rt_targeting.H> #include <targeting/common/commontargeting.H> #include <targeting/attrPlatOverride.H> -#include <hwpf/plat/fapiPlatAttrOverrideSync.H> +//@TODO RTC:132750 +//#include <hwpf/plat/fapiPlatAttrOverrideSync.H> #include <targeting/common/trace.H> #include <errl/errlmanager.H> @@ -40,6 +41,8 @@ int apply_attr_override(uint8_t* i_data, size_t i_size ) { int rc = 0; +//@TODO RTC:132750 +#if 0 errlHndl_t l_errl = NULL; TRACFCOMP(g_trac_targeting, "enter apply_attr_override"); @@ -83,6 +86,7 @@ int apply_attr_override(uint8_t* i_data, { TRACFCOMP(g_trac_targeting, "apply_attr_override succeed"); } +#endif return rc; } diff --git a/src/usr/targeting/runtime/makefile b/src/usr/targeting/runtime/makefile index 1c78cbd98..4dd9806d0 100644 --- a/src/usr/targeting/runtime/makefile +++ b/src/usr/targeting/runtime/makefile @@ -26,7 +26,8 @@ HOSTBOOT_RUNTIME = 1 ROOTPATH = ../../../.. MODULE = targeting_rt -SUBDIRS += test.d +#@TODO RTC:132750 +#SUBDIRS += test.d TARGETING_REL_PATH = .. include ${TARGETING_REL_PATH}/hostboot_common.mk diff --git a/src/usr/targeting/test/makefile b/src/usr/targeting/test/makefile index ae56feb31..b8d466539 100644 --- a/src/usr/targeting/test/makefile +++ b/src/usr/targeting/test/makefile @@ -5,7 +5,9 @@ # # OpenPOWER HostBoot Project # -# COPYRIGHT International Business Machines Corp. 2011,2014 +# Contributors Listed Below - COPYRIGHT 2011,2015 +# [+] International Business Machines Corp. +# # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. diff --git a/src/usr/targeting/test/testtargeting.H b/src/usr/targeting/test/testtargeting.H index 695836496..fdd4702da 100644 --- a/src/usr/targeting/test/testtargeting.H +++ b/src/usr/targeting/test/testtargeting.H @@ -5,7 +5,9 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* COPYRIGHT International Business Machines Corp. 2012,2014 */ +/* Contributors Listed Below - COPYRIGHT 2012,2015 */ +/* [+] International Business Machines Corp. */ +/* */ /* */ /* Licensed under the Apache License, Version 2.0 (the "License"); */ /* you may not use this file except in compliance with the License. */ @@ -40,10 +42,7 @@ // CXXTEST #include <cxxtest/TestSuite.H> -#include <hwpf/plat/fapiPlatAttributeService.H> -#include <fapiReturnCode.H> -#include <fapiAttributeIds.H> -#include <fapiAttributeService.H> + #include <errl/errlmanager.H> #include <sys/sync.h> #include <sys/task.h> @@ -103,7 +102,6 @@ class TargetingTestSuite : public CxxTest::TestSuite TS_TRACE(ENTER_MRK "testHbMutexAttr" ); using namespace TARGETING; - using namespace fapi; do { @@ -207,7 +205,6 @@ class TargetingTestSuite : public CxxTest::TestSuite using namespace ERRORLOG; using namespace TARGETING; - using namespace fapi; // Get a reference to the target service TargetService& l_service = targetService(); @@ -253,7 +250,6 @@ class TargetingTestSuite : public CxxTest::TestSuite // is resolved using namespace ERRORLOG; using namespace TARGETING; - using namespace fapi; TargetHandleList l_targs; |