diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-04-13 11:46:00 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-04-18 11:55:58 -0400 |
| commit | c894380c8e13c749bcd5e58591a4b37047f43953 (patch) | |
| tree | 80f28420ab9bf7e479901889ad1f0d0628194189 /src/usr | |
| parent | fbb76571779d5b284e8da0c8bac7bc22f0c4851a (diff) | |
| download | talos-hostboot-c894380c8e13c749bcd5e58591a4b37047f43953.tar.gz talos-hostboot-c894380c8e13c749bcd5e58591a4b37047f43953.zip | |
Ensure that we only attempt to recover from vital attn on BMC systems
On an FSP system PRD should never get triggered on an SBE vital attn.
However if for any reason PRD attempts to handle a vital attn on an
FSP system HB should not actually perform any recovery and we should
just return an error back to PRD signaling that we could not recover.
PRD should stop mask off the error after the handler returns with
an error saying we could not recover.
Change-Id: If1666bd028da9a94bed34d79da34f6264beb0fbf
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57176
CI-Ready: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr')
| -rw-r--r-- | src/usr/sbeio/common/sbe_attn.C | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/usr/sbeio/common/sbe_attn.C b/src/usr/sbeio/common/sbe_attn.C index 2fb0cf1da..338dc62c9 100644 --- a/src/usr/sbeio/common/sbe_attn.C +++ b/src/usr/sbeio/common/sbe_attn.C @@ -73,7 +73,14 @@ namespace SBEIO SbeRetryHandler l_sbeObj = SbeRetryHandler( SbeRetryHandler::SBE_MODE_OF_OPERATION::ATTEMPT_REBOOT); + // We only want to handle vital attentions on BMC based systems. + // If we have a FSP we should be ignoring Vital attentions and + // the handleVitalAttn should have never been called. This + // check just ensures on an FSP system we will not disrupt other + // code that is attempting to handle the SBE fail +#ifndef CONFIG_FSP_BUILD l_sbeObj.main_sbe_handler(i_procTarg); +#endif // Check if the SBE made it back to runtime, this tells us if the retry was a // success or not |
