diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-04-09 13:15:51 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-04-16 16:15:34 -0400 |
| commit | 02658fce02d3705e17596d92f3fa8424fe43868e (patch) | |
| tree | 26a6a127b9517f65ecedbe528d999dd5a22124ff /src/usr | |
| parent | 739ec89c67cde105301ab9aa11adf2c420efa6eb (diff) | |
| download | talos-hostboot-02658fce02d3705e17596d92f3fa8424fe43868e.tar.gz talos-hostboot-02658fce02d3705e17596d92f3fa8424fe43868e.zip | |
Change sbe restart fail hwCallouts from GARDs to DECONFIG
During the hreset and start_cbs hwps if we get an error (likely scom
or cfam error) then we want to callout the processor. Previously we
were GARDing out the processor if this occurred. It was pointed out this
might be a little harsh so instead we are going to deconfigure the
processor
Change-Id: Id5bfe0af392a4863ef2d225777bc17f3c308340e
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56960
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/usr')
| -rw-r--r-- | src/usr/sbeio/common/sbe_retry_handler.C | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/usr/sbeio/common/sbe_retry_handler.C b/src/usr/sbeio/common/sbe_retry_handler.C index 14725e93a..e4b94ed55 100644 --- a/src/usr/sbeio/common/sbe_retry_handler.C +++ b/src/usr/sbeio/common/sbe_retry_handler.C @@ -23,7 +23,7 @@ /* */ /* IBM_PROLOG_END_TAG */ /** - * @file sbe_extract_dd.C + * @file sbe_retry_handler.C * * Handle a SBE extract rc error. We use a switch-case to determine * what action to take, and a finite state machine to control the @@ -402,11 +402,11 @@ void SbeRetryHandler::main_sbe_handler( TARGETING::Target * i_target ) l_errl->collectTrace( "ISTEPS_TRACE", 256 ); l_errl->collectTrace( SBEIO_COMP_NAME, 256 ); - // Gard the target, when SBE Retry fails + // Deconfig the target when SBE Retry fails l_errl->addHwCallout(i_target, - HWAS::SRCI_PRIORITY_HIGH, - HWAS::NO_DECONFIG, - HWAS::GARD_Predictive); + HWAS::SRCI_PRIORITY_LOW, + HWAS::DELAYED_DECONFIG, + HWAS::GARD_NULL); // Set the PLID of the error log to master PLID // if the master PLID is set @@ -434,11 +434,11 @@ void SbeRetryHandler::main_sbe_handler( TARGETING::Target * i_target ) l_errl->plid() ); l_errl->collectTrace( SBEIO_COMP_NAME, 256 ); - // Gard the target, when SBE Retry fails + // Deconfig the target when SBE Retry fails l_errl->addHwCallout(i_target, - HWAS::SRCI_PRIORITY_HIGH, - HWAS::NO_DECONFIG, - HWAS::GARD_Predictive); + HWAS::SRCI_PRIORITY_LOW, + HWAS::DELAYED_DECONFIG, + HWAS::GARD_NULL); // Set the PLID of the error log to master PLID // if the master PLID is set |
