diff options
| author | Mike Jones <mjjones@us.ibm.com> | 2012-05-02 15:44:12 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-05-07 11:43:59 -0500 |
| commit | 32749fd1bcf7c34241f2ccee242c1cb611a65928 (patch) | |
| tree | f8b70a26af73dbffea8d7e250074f0520adccfd8 /src/usr | |
| parent | ca1f509428df6418258b8e16b30b49265fd33817 (diff) | |
| download | talos-hostboot-32749fd1bcf7c34241f2ccee242c1cb611a65928.tar.gz talos-hostboot-32749fd1bcf7c34241f2ccee242c1cb611a65928.zip | |
HWPF: Add support for reporting ADU locked error
This allows platforms to report that a SCOM error was due to ADU locked.
The FSP HWPs that do ADU operations (proc_adu_getmem_coherent and
proc_adu_putmem_coherent) need to look for this error so that they can
retry appropriately.
Change-Id: I8caa7efaf98131cc5ec2e8c36c069f86e329cf05
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/982
Tested-by: Jenkins Server
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr')
| -rw-r--r-- | src/usr/hwpf/fapi/fapiReturnCode.C | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/usr/hwpf/fapi/fapiReturnCode.C b/src/usr/hwpf/fapi/fapiReturnCode.C index d23a89dbe..3a2f0e3ed 100644 --- a/src/usr/hwpf/fapi/fapiReturnCode.C +++ b/src/usr/hwpf/fapi/fapiReturnCode.C @@ -43,6 +43,7 @@ * mjjones 02/22/2012 Allow user to add Target FFDC * mjjones 03/16/2012 Add type to FFDC data * mjjones 03/16/2012 Allow different PLAT errors + * mjjones 05/02/2012 Only trace setEcmdError on err */ #include <fapiReturnCode.H> @@ -168,7 +169,13 @@ void ReturnCode::setFapiError(const ReturnCodes i_rcValue) //****************************************************************************** void ReturnCode::setEcmdError(const uint32_t i_rcValue) { - FAPI_ERR("setEcmdError: Creating ECMD error 0x%x", i_rcValue); + // Some HWPs perform an ecmdDataBaseBufferBase operation, then call this + // function then check if the ReturnCode indicates an error. Therefore only + // trace an error if there actually is an error + if (i_rcValue != 0) + { + FAPI_ERR("setEcmdError: Creating ECMD error 0x%x", i_rcValue); + } iv_rcValue = i_rcValue; // Forget about any associated data (this is a new error) |
