diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2014-01-07 09:30:51 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-01-10 16:19:14 -0600 |
| commit | aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3 (patch) | |
| tree | d6a587a8582ac9d085b08e028c757a0ea94bb825 /src/usr/util | |
| parent | ea2a49ff0cd3827458025f75d5b6bd7054d18779 (diff) | |
| download | talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.tar.gz talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.zip | |
Remove leftover fixme/todo and update error callouts
Remove all untagged fixme/todo comments
Adde new parm to error log constructor to avoid extra code in
common software error case
Update error callouts
Add strncpy
Change-Id: I8bd8f48193a96b79db91ed35c4fd485e6da38dba
RTC: 67921
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/7921
Tested-by: Jenkins Server
Reviewed-by: Michael Baiocchi <baiocchi@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/util')
| -rw-r--r-- | src/usr/util/utilbase.C | 5 | ||||
| -rw-r--r-- | src/usr/util/utillidmgr.C | 13 | ||||
| -rw-r--r-- | src/usr/util/utilmem.C | 8 |
3 files changed, 13 insertions, 13 deletions
diff --git a/src/usr/util/utilbase.C b/src/usr/util/utilbase.C index 48c2c4595..42e137425 100644 --- a/src/usr/util/utilbase.C +++ b/src/usr/util/utilbase.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2012 */ +/* COPYRIGHT International Business Machines Corp. 2012,2014 */ /* */ /* p1 */ /* */ @@ -22,9 +22,10 @@ /* IBM_PROLOG_END_TAG */ #include "utilbase.H" #include <limits.h> +#include <hbotcompid.H> namespace Util { trace_desc_t* g_util_trace; - TRAC_INIT(&g_util_trace, "UTIL", KILOBYTE); + TRAC_INIT(&g_util_trace, UTIL_COMP_NAME, KILOBYTE); }; diff --git a/src/usr/util/utillidmgr.C b/src/usr/util/utillidmgr.C index 73cac29b0..2baee4ca3 100644 --- a/src/usr/util/utillidmgr.C +++ b/src/usr/util/utillidmgr.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2013 */ +/* COPYRIGHT International Business Machines Corp. 2013,2014 */ /* */ /* p1 */ /* */ @@ -257,9 +257,8 @@ errlHndl_t UtilLidMgr::getLidPnor(void* i_dest, Util::UTIL_LIDMGR_INVAL_SIZE, TWO_UINT32_TO_UINT64(lidSize, i_destSize), - iv_lidId); - errl->addProcedureCallout(HWAS::EPUB_PRC_HB_CODE, - HWAS::SRCI_PRIORITY_MED); + iv_lidId, + true /*Add HB Software Callout*/); break; } @@ -431,12 +430,10 @@ errlHndl_t UtilLidMgr::getLid(void* i_dest, size_t i_destSize) Util::UTIL_LIDMGR_INVAL_SIZE, TWO_UINT32_TO_UINT64(i_destSize, needed_size), - iv_lidId + iv_lidId, + true /*Add HB Software Callout*/ ); - errl->addProcedureCallout(HWAS::EPUB_PRC_HB_CODE, - HWAS::SRCI_PRIORITY_HIGH); - free(l_pMsg->extra_data); l_pMsg->extra_data = NULL; break; diff --git a/src/usr/util/utilmem.C b/src/usr/util/utilmem.C index a3d015f30..6d6e8e6cb 100644 --- a/src/usr/util/utilmem.C +++ b/src/usr/util/utilmem.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2003,2013 */ +/* COPYRIGHT International Business Machines Corp. 2003,2014 */ /* */ /* p1 */ /* */ @@ -227,7 +227,8 @@ uint32_t UtilMem::read( UTIL_MOD_MEM_READ, l_erc, TWO_UINT32_TO_UINT64(task_gettid(), iv_eof), - reinterpret_cast<uint64_t>(iv_memStart) + reinterpret_cast<uint64_t>(iv_memStart), + true /*Add HB Software Callout*/ ); // collect some trace by default @@ -332,7 +333,8 @@ uint32_t UtilMem::write( UTIL_MOD_MEM_WRITE, l_erc, TWO_UINT32_TO_UINT64(task_gettid(), iv_eof), - reinterpret_cast<uint64_t>(iv_memStart) + reinterpret_cast<uint64_t>(iv_memStart), + true /*Add HB Software Callout*/ ); // collect some trace by default |
