diff options
| author | Mike Baiocchi <mbaiocch@us.ibm.com> | 2018-02-07 21:57:16 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-09 12:54:41 -0500 |
| commit | 4f3656309da631e6a5fcf4d6cb8fe5241c61e1de (patch) | |
| tree | 2b9e8539b3dab39f37a465358b87a5444031db4d /src/usr/util | |
| parent | de8120523a0cf74b2c682b1f8723b99cb0388a4e (diff) | |
| download | talos-hostboot-4f3656309da631e6a5fcf4d6cb8fe5241c61e1de.tar.gz talos-hostboot-4f3656309da631e6a5fcf4d6cb8fe5241c61e1de.zip | |
Remove Attribute Check For TCE Settings
This commit removes hostboot checking ATTR_USE_TCES_FOR_DMAS when
determining whether to enable TCEs or not. The default now it to
always use TCEs on FSP-based systems regardless of this attribute's
setting.
Change-Id: I08bcb3b7c2643b857b0b74732b1334403139c780
RTC:168745
Backport:release-fips910
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53611
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/util')
| -rw-r--r-- | src/usr/util/utiltcemgr.C | 22 |
1 files changed, 6 insertions, 16 deletions
diff --git a/src/usr/util/utiltcemgr.C b/src/usr/util/utiltcemgr.C index e61ae4ca5..6337714c4 100644 --- a/src/usr/util/utiltcemgr.C +++ b/src/usr/util/utiltcemgr.C @@ -55,9 +55,8 @@ TRAC_INIT(&g_trac_tce, UTILTCE_TRACE_NAME, 4*KILOBYTE); // ------------------------ // Macros for unit testing - leave extra trace enabled for now -// @TODO RTC 168745 - Disable TRACUCOMP as the default -#define TRACUCOMP(args...) TRACFCOMP(args) -//#define TRACUCOMP(args...) +//#define TRACUCOMP(args...) TRACFCOMP(args) +#define TRACUCOMP(args...) namespace TCE @@ -1190,13 +1189,13 @@ UtilTceMgr::~UtilTceMgr() // Debug for printing out iv_allocatedAddrs map void UtilTceMgr::printIvMap(void) const { - TRACUCOMP(g_trac_tce,"UtilTceMgr::printIvMap: size=%d", iv_allocatedAddrs.size()); + TRACFCOMP(g_trac_tce,"UtilTceMgr::printIvMap: size=%d", iv_allocatedAddrs.size()); + // To avoid map_itr below being an unused variable for ( auto const& map_itr : iv_allocatedAddrs ) { - TRACUCOMP(g_trac_tce,"UtilTceMgr: printIvMap: token=0x%.8X, addr=0x%.16llX, size=0x%X", map_itr.first, map_itr.second.start_addr, map_itr.second.size); + TRACFCOMP(g_trac_tce,"UtilTceMgr: printIvMap: token=0x%.8X, addr=0x%.16llX, size=0x%X", map_itr.first, map_itr.second.start_addr, map_itr.second.size); } - } @@ -1371,16 +1370,7 @@ bool utilUseTcesForDmas(void) if (INITSERVICE::spBaseServicesEnabled()) { - // @TODO RTC 168745 - Eventually this will default to true in all cases - // where was have a FSP - - // Get Target Service and the system target to get ATTR_USE_TCES_FOR_DMA - TARGETING::TargetService& tS = TARGETING::targetService(); - TARGETING::Target* sys = nullptr; - (void) tS.getTopLevelTarget( sys ); - assert(sys, "utilUseTcesForDmas() system target is NULL"); - - retVal = sys->getAttr<TARGETING::ATTR_USE_TCES_FOR_DMAS>(); + retVal = true; } TRACFCOMP(g_trac_tce,INFO_MRK"utilUseTcesForDmas: %s", |
