diff options
| author | Marty Gloff <mgloff@us.ibm.com> | 2017-07-18 15:39:40 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-07-26 00:10:10 -0400 |
| commit | 8c38babde5c9ca518817c54d05ac2179708f0eef (patch) | |
| tree | 3c398573730b81ec0053b2a4df93f93611d80550 /src/usr/targeting/targetservicestart.C | |
| parent | 03f9b6c4cb3a05d8d630461a8a70405ade923199 (diff) | |
| download | talos-hostboot-8c38babde5c9ca518817c54d05ac2179708f0eef.tar.gz talos-hostboot-8c38babde5c9ca518817c54d05ac2179708f0eef.zip | |
Bringup memory remapping Fix LPC and XSCOM BAR asserts
The LPC and XSCOM BAR values are checked and an assert coded in the
failure leg. The condition for these asserts is being fixed. Also
the LPC BAR check is being fixed to subtract out the start offset.
Change-Id: I09f9989a51f6581c5b12a4a5057a4fcfa3412566
RTC:149250
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43286
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/targeting/targetservicestart.C')
| -rwxr-xr-x | src/usr/targeting/targetservicestart.C | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/usr/targeting/targetservicestart.C b/src/usr/targeting/targetservicestart.C index b32f4db53..4ced5dd2d 100755 --- a/src/usr/targeting/targetservicestart.C +++ b/src/usr/targeting/targetservicestart.C @@ -620,7 +620,7 @@ static void adjustMemoryMap( TargetService& i_targetService ) TARG_ERR( "LPC attribute=%.16llX, live=%.16llX", l_pMasterProcChip->getAttr<ATTR_LPC_BUS_ADDR>(), LPC::get_lpc_bar() ); - TARG_ASSERT( true, "LPC BARs are inconsistent" ); + TARG_ASSERT( false, "LPC BARs are inconsistent" ); } if( l_pMasterProcChip->getAttr<ATTR_XSCOM_BASE_ADDRESS>() != XSCOM::get_master_bar() ) @@ -628,7 +628,7 @@ static void adjustMemoryMap( TargetService& i_targetService ) TARG_ERR( "XSCOM attribute=%.16llX, live=%.16llX", l_pMasterProcChip->getAttr<ATTR_XSCOM_BASE_ADDRESS>(), XSCOM::get_master_bar() ); - TARG_ASSERT( true, "XSCOM BARs are inconsistent" ); + TARG_ASSERT( false, "XSCOM BARs are inconsistent" ); } } |
