diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2019-03-08 17:03:12 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-03-11 16:56:24 -0500 |
| commit | 4636db0ab1ec255b51950e24e742e503411bceb8 (patch) | |
| tree | 258ee07110a7ff5f41952e7c8f4071ed7f5fdcb0 /src/usr/targeting/common/xmltohb/attribute_types.xml | |
| parent | 552339eb7f7855f907dd0836c9cb2730887306a8 (diff) | |
| download | talos-hostboot-4636db0ab1ec255b51950e24e742e503411bceb8.tar.gz talos-hostboot-4636db0ab1ec255b51950e24e742e503411bceb8.zip | |
Always use original defaults for attribute fields with no value
When a complex attribute is modified to add new fields, it is
possible for the system xml to get generated with blank values
for the new fields. This value will then get pushed into the
final binary instead of a valid default from the metadata xml
files.
Change-Id: I26d5434c7039d62486b52eb79b395c6dd3d77db7
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/73089
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/targeting/common/xmltohb/attribute_types.xml')
| -rw-r--r-- | src/usr/targeting/common/xmltohb/attribute_types.xml | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/src/usr/targeting/common/xmltohb/attribute_types.xml b/src/usr/targeting/common/xmltohb/attribute_types.xml index 0a51d45b8..c268ab413 100644 --- a/src/usr/targeting/common/xmltohb/attribute_types.xml +++ b/src/usr/targeting/common/xmltohb/attribute_types.xml @@ -5902,6 +5902,7 @@ <id>PRIMARY_CAPABILITIES</id> <persistency>non-volatile</persistency> <readable/> + <no_export/> </attribute> <attribute> @@ -6979,12 +6980,14 @@ <attribute> <complexType> - <description>Structure which defines a system's SP functions. + <description> + Structure which defines a system's SP functions. Applicable for System target only. Structure is read-only. - </description> + Default values match OpenBMC implementation. + </description> <field> <bits>1</bits> - <default>1</default> + <default>0</default> <description> If this flag is set then mailboxEnabled MUST also be set @@ -6996,7 +6999,7 @@ </field> <field> <bits>1</bits> - <default>1</default> + <default>0</default> <description> 0b0: SP does not initialize FSI slave logic, Hostboot must; 0b1: SP does initialize FSI slave logic so Hostboot should not @@ -7016,7 +7019,7 @@ </field> <field> <bits>1</bits> - <default>1</default> + <default>0</default> <description> 0b0: SP does not initialize FSI master logic, Hostboot must; 0b1: SP does initialize FSI master logic so Hostboot should not @@ -7026,7 +7029,7 @@ </field> <field> <bits>1</bits> - <default>1</default> + <default>0</default> <description> 0b0: SP does not perform hardware change detection, Hostboot must; 0b1: SP does perform hardware change detection (HCDB) so Hostboot should not @@ -7036,7 +7039,7 @@ </field> <field> <bits>1</bits> - <default>1</default> + <default>0</default> <description> 0b0: SP does not perform Power Line Disturbance (PLD) detection, Hostboot must; 0b1: SP does perform Power Line Disturbance (PLD) detection so Hostboot should not |
