diff options
author | Brian Horton <brianh@linux.ibm.com> | 2012-08-01 16:34:47 -0500 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-09-05 15:18:42 -0500 |
commit | 348e054c2d70697169a4ecbdc2eaab1932bd322c (patch) | |
tree | 2aab9491574d337151633861852e1f400621cea6 /src/usr/targeting/common/entitypath.C | |
parent | 53643b771cfa77708539de18b5fc9a2a4b19a141 (diff) | |
download | talos-hostboot-348e054c2d70697169a4ecbdc2eaab1932bd322c.tar.gz talos-hostboot-348e054c2d70697169a4ecbdc2eaab1932bd322c.zip |
Performance and size optimizations - inline simple methods
Move the code for some of the 'simple' methods (ie, {}, or simple
methods that just set a value or return a value) from the .C file
into the .H file, so that they're inlined. Saves in both size and
performance. Didn't measure performance gains (not sure I can in a
simulated environment..) but generated .list files look much better.
Size - hbicore_extended.bin dropped from 1442928 to 1426544 (16K, 1%)
Change-Id: I6915cba77520b4a28237c557760ababcca781804
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/1464
Tested-by: Jenkins Server
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/targeting/common/entitypath.C')
-rw-r--r-- | src/usr/targeting/common/entitypath.C | 82 |
1 files changed, 22 insertions, 60 deletions
diff --git a/src/usr/targeting/common/entitypath.C b/src/usr/targeting/common/entitypath.C index af1c30ff8..46ba7d88a 100644 --- a/src/usr/targeting/common/entitypath.C +++ b/src/usr/targeting/common/entitypath.C @@ -1,26 +1,25 @@ -// IBM_PROLOG_BEGIN_TAG -// This is an automatically generated prolog. -// -// $Source: src/usr/targeting/entitypath.C $ -// -// IBM CONFIDENTIAL -// -// COPYRIGHT International Business Machines Corp. 2011 -// -// p1 -// -// Object Code Only (OCO) source materials -// Licensed Internal Code Source Materials -// IBM HostBoot Licensed Internal Code -// -// The source code for this program is not published or other- -// wise divested of its trade secrets, irrespective of what has -// been deposited with the U.S. Copyright Office. -// -// Origin: 30 -// -// IBM_PROLOG_END - +/* IBM_PROLOG_BEGIN_TAG */ +/* This is an automatically generated prolog. */ +/* */ +/* $Source: src/usr/targeting/common/entitypath.C $ */ +/* */ +/* IBM CONFIDENTIAL */ +/* */ +/* COPYRIGHT International Business Machines Corp. 2011,2012 */ +/* */ +/* p1 */ +/* */ +/* Object Code Only (OCO) source materials */ +/* Licensed Internal Code Source Materials */ +/* IBM HostBoot Licensed Internal Code */ +/* */ +/* The source code for this program is not published or otherwise */ +/* divested of its trade secrets, irrespective of what has been */ +/* deposited with the U.S. Copyright Office. */ +/* */ +/* Origin: 30 */ +/* */ +/* IBM_PROLOG_END_TAG */ /** * @file targeting/common/entitypath.C * @@ -84,17 +83,6 @@ EntityPath::EntityPath() } //****************************************************************************** -// EntityPath::~EntityPath -//****************************************************************************** - -EntityPath::~EntityPath() -{ - #define TARG_FN "~EntityPath()" - - #undef TARG_FN -} - -//****************************************************************************** // EntityPath::removeLast //****************************************************************************** @@ -262,19 +250,6 @@ const EntityPath::PathElement EntityPath::pathElementOfType( } //****************************************************************************** -// EntityPath::size -//****************************************************************************** - -uint32_t EntityPath::size() const -{ - #define TARG_FN "size()" - - return iv_size; - - #undef TARG_FN -} - -//****************************************************************************** // EntityPath::setType //****************************************************************************** @@ -289,19 +264,6 @@ void EntityPath::setType( } //****************************************************************************** -// EntityPath::type -//****************************************************************************** - -EntityPath::PATH_TYPE EntityPath::type() const -{ - #define TARG_FN "type()" - - return iv_type; - - #undef TARG_FN -} - -//****************************************************************************** // EntityPath::pathTypeAsString (DEBUG) //****************************************************************************** |