diff options
| author | Marty Gloff <mgloff@us.ibm.com> | 2017-07-18 15:39:40 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-07-26 00:10:10 -0400 |
| commit | 8c38babde5c9ca518817c54d05ac2179708f0eef (patch) | |
| tree | 3c398573730b81ec0053b2a4df93f93611d80550 /src/usr/lpc | |
| parent | 03f9b6c4cb3a05d8d630461a8a70405ade923199 (diff) | |
| download | talos-hostboot-8c38babde5c9ca518817c54d05ac2179708f0eef.tar.gz talos-hostboot-8c38babde5c9ca518817c54d05ac2179708f0eef.zip | |
Bringup memory remapping Fix LPC and XSCOM BAR asserts
The LPC and XSCOM BAR values are checked and an assert coded in the
failure leg. The condition for these asserts is being fixed. Also
the LPC BAR check is being fixed to subtract out the start offset.
Change-Id: I09f9989a51f6581c5b12a4a5057a4fcfa3412566
RTC:149250
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43286
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/lpc')
| -rw-r--r-- | src/usr/lpc/lpcdd.C | 4 | ||||
| -rw-r--r-- | src/usr/lpc/lpcdd.H | 10 |
2 files changed, 13 insertions, 1 deletions
diff --git a/src/usr/lpc/lpcdd.C b/src/usr/lpc/lpcdd.C index 543086a28..e10d3c975 100644 --- a/src/usr/lpc/lpcdd.C +++ b/src/usr/lpc/lpcdd.C @@ -387,8 +387,10 @@ void block_lpc_ops( bool i_block ) */ uint64_t get_lpc_bar( void ) { + LpcDD l_LpcDD = Singleton<LpcDD>::instance(); return mm_virt_to_phys( reinterpret_cast<void*>( - Singleton<LpcDD>::instance().getLPCBaseAddr() )); + l_LpcDD.getLPCBaseAddr() )) - + l_LpcDD.getLPCStartAddr(); } diff --git a/src/usr/lpc/lpcdd.H b/src/usr/lpc/lpcdd.H index f4bd04176..3cebf07bd 100644 --- a/src/usr/lpc/lpcdd.H +++ b/src/usr/lpc/lpcdd.H @@ -132,6 +132,16 @@ class LpcDD }; /** + * @brief Get the start offset in the LPC space + * + * @return Offset to LPC start address + */ + uint64_t getLPCStartAddr(void) + { + return LPC_ADDR_START; + }; + + /** * @brief Block/unblock all LPC operations * @param[in] i_block true: block ops, false: allow ops */ |
