diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2017-08-16 15:23:56 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-08-17 11:32:59 -0400 |
| commit | e8ac167fca7ba17db843fb16174b32f0f90c497d (patch) | |
| tree | 27efed4ef6401a25be8354438d02db74b6d94d81 /src/usr/lpc/lpcdd.C | |
| parent | be278aca06ad5dd7af01053bc9de6951f68eec15 (diff) | |
| download | talos-hostboot-e8ac167fca7ba17db843fb16174b32f0f90c497d.tar.gz talos-hostboot-e8ac167fca7ba17db843fb16174b32f0f90c497d.zip | |
Fix off-by-one error in LPC driver for pnor mbox windows
Found a bug where we fail if we use a window all the way up to
the edge of the allocated window.
Change-Id: I1e663089a3ba6b2e4d9a7dbc67ae98db0fd2524e
CQ: SW398471
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44703
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/lpc/lpcdd.C')
| -rw-r--r-- | src/usr/lpc/lpcdd.C | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/usr/lpc/lpcdd.C b/src/usr/lpc/lpcdd.C index e10d3c975..b0dd00fd7 100644 --- a/src/usr/lpc/lpcdd.C +++ b/src/usr/lpc/lpcdd.C @@ -777,7 +777,7 @@ errlHndl_t LpcDD::_readLPC(LPC::TransType i_type, *o_ptr = *l_ptr; } else if ( i_type == LPC::TRANS_FW - && (i_addr + io_buflen) < LPC::FW_WINDOW_SIZE) + && (i_addr + io_buflen) <= LPC::FW_WINDOW_SIZE) { memcpy( o_buffer, reinterpret_cast<void*>(l_addr), io_buflen ); } |
