diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-02-12 14:59:05 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-19 09:43:09 -0500 |
| commit | 8d28433bcc3c927ee76cdc4231099660545b1bfa (patch) | |
| tree | c6f3810c0b2d69a55d8309ae1c35a8c1c7fdf5c1 /src/usr/isteps | |
| parent | 28927a78ca4144aa8214d35b7ad7e2ddba5ada4e (diff) | |
| download | talos-hostboot-8d28433bcc3c927ee76cdc4231099660545b1bfa.tar.gz talos-hostboot-8d28433bcc3c927ee76cdc4231099660545b1bfa.zip | |
Fix bugs in FSP->HBRT message path for SBE errors
Hostboot was expecting the incorrect order of data in messages sent
from the FSP -> PHYP -> HBRT where the SBE is requesting that HBRT
reset the SBE. This commit corrects the order and renames the struct
for the specific role its used in. Also this commit fixes the values
for the MESSAGE type sent by the FSP.
CQ: SW415675
Change-Id: I08f44486054e7d0113fd7606bb40ced577080d0c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53883
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/isteps')
| -rw-r--r-- | src/usr/isteps/pm/runtime/test/firmwareRequestTest.H | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/usr/isteps/pm/runtime/test/firmwareRequestTest.H b/src/usr/isteps/pm/runtime/test/firmwareRequestTest.H index 152b9f197..6c8aead3e 100644 --- a/src/usr/isteps/pm/runtime/test/firmwareRequestTest.H +++ b/src/usr/isteps/pm/runtime/test/firmwareRequestTest.H @@ -194,7 +194,7 @@ class FirmwareRequestTest : public CxxTest::TestSuite uint64_t l_req_fw_msg_size(0), l_resp_fw_msg_size(0); // Create the dynamic firmware messages - createGenericFspMsg(sizeof(HbrtFspData_t), + createGenericFspMsg(sizeof(SbeRetryReqData_t), l_fsp_data_size, l_req_fw_msg_size, l_req_fw_msg, @@ -208,11 +208,11 @@ class FirmwareRequestTest : public CxxTest::TestSuite // Create a useful struct to populate the generic_msg::data field // Setting the PLID and userData - HbrtFspData_t* l_fspData = - reinterpret_cast<HbrtFspData_t*> + SbeRetryReqData_t* l_fspData = + reinterpret_cast<SbeRetryReqData_t*> (&(l_req_fw_msg->generic_msg.data)); + l_fspData->huid = 0x700; l_fspData->plid = 0x600; - l_fspData->userData = 0x700; if (l_req_fw_msg->generic_msg.magic != GenericFspMboxMessage_t::MAGIC_NUMBER) |
