Zeppelin BUP updates

- targeting: skip over ATTR_BAD_DQ_BITMAP during fapi attriubte dump
             as it is not looked up correctly for cumulus.
             Need to add it back in future.
- istep changes:
    - remove p9_throttle_sync from istep 13, it is already getting
      called in istep 14
    - add support for memdiags on cumulus
- centaur pibrc errors: mask out PROTECTION_BIT for centaur scoms as it is
                        irrelevant for centaurs
- configureHbrtHypIds: correctly setup DMI information

Change-Id: Ifeaca2f58e16b7ecac9e1329409b98bc6a2f38e7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49382
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Thomas R. Sand <trsand@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>

3 files changed, 6 insertions, 49 deletions

diff --git a/src/usr/isteps/istep06/host_discover_targets.C b/src/usr/isteps/istep06/host_discover_targets.C
index 26ebc57af..f503576b8 100644
--- a/src/usr/isteps/istep06/host_discover_targets.C
+++ b/src/usr/isteps/istep06/host_discover_targets.C
@@ -146,6 +146,7 @@ void print_system_info(void)
 
     //Add all the target types that you want to see in the output to this vector
     types_to_print.push_back(TARGETING::TYPE_PROC);
+    types_to_print.push_back(TARGETING::TYPE_MEMBUF);
     types_to_print.push_back(TARGETING::TYPE_MCS);
     types_to_print.push_back(TARGETING::TYPE_MCA);
     types_to_print.push_back(TARGETING::TYPE_MCBIST);
diff --git a/src/usr/isteps/istep13/call_mss_scominit.C b/src/usr/isteps/istep13/call_mss_scominit.C
index 783ae2a97..966bde9fa 100644
--- a/src/usr/isteps/istep13/call_mss_scominit.C
+++ b/src/usr/isteps/istep13/call_mss_scominit.C
@@ -160,49 +160,6 @@ void* call_mss_scominit (void *io_pArgs)
             break;
         }
 
-        // Run proc throttle sync
-        // Get all functional proc chip targets
-        TARGETING::TargetHandleList l_cpuTargetList;
-        getAllChips(l_cpuTargetList, TYPE_PROC);
-
-        for (const auto & l_procChip: l_cpuTargetList)
-        {
-            const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>
-                l_fapi_cpu_target(l_procChip);
-
-            TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-                   "Running p9_throttle_sync HWP on "
-                   "target HUID %.8X", TARGETING::get_huid(l_procChip));
-
-            // Call proc_throttle_sync
-            FAPI_INVOKE_HWP( l_err, p9_throttle_sync, l_fapi_cpu_target );
-
-            if (l_err)
-            {
-                TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
-                          "ERROR 0x%.8X: p9_throttle_sync HWP returns error",
-                          l_err->reasonCode());
-
-                // Capture the target data in the elog
-                ErrlUserDetailsTarget(l_procChip).addToLog(l_err);
-
-                // Create IStep error log and cross reference
-                // to error that occurred
-                l_stepError.addErrorDetails( l_err );
-
-                // Commit Error
-                errlCommit( l_err, HWPF_COMP_ID );
-
-                break;
-            }
-            else
-            {
-                TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-                           "SUCCESS running p9_throttle_sync HWP on "
-                           "target HUID %.8X", TARGETING::get_huid(l_procChip));
-            }
-        }
-
     } while (0);
 
     TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "call_mss_scominit exit" );
diff --git a/src/usr/isteps/istep14/call_mss_memdiag.C b/src/usr/isteps/istep14/call_mss_memdiag.C
index 949cd731f..46793b35d 100644
--- a/src/usr/isteps/istep14/call_mss_memdiag.C
+++ b/src/usr/isteps/istep14/call_mss_memdiag.C
@@ -143,12 +143,11 @@ void* call_mss_memdiag (void* io_pArgs)
         }
         else if ( MODEL_CUMULUS == procType )
         {
-//@TODO RTC:175770
-//            TargetHandleList trgtList; getAllChiplets( trgtList, TYPE_MBA );
-//
-//            // Start Memory Diagnostics
-//            errl = __runMemDiags( trgtList );
-//            if ( nullptr != errl ) break;
+            TargetHandleList trgtList; getAllChiplets( trgtList, TYPE_MBA );
+
+            // Start Memory Diagnostics
+            errl = __runMemDiags( trgtList );
+            if ( nullptr != errl ) break;
 
             // No need to unmask or turn off FIFO. That is already contained
             // within the other Centaur HWPs.