diff options
author | Andrew Geissler <andrewg@us.ibm.com> | 2016-05-11 13:01:03 -0500 |
---|---|---|
committer | Matthew A. Ploetz <maploetz@us.ibm.com> | 2016-05-16 14:11:30 -0400 |
commit | 9ce9b2574c96f93d6795c65d6b71f66bc3c95a4e (patch) | |
tree | cdd780e3013dd1be8b4423a67dc0a12794f44fd8 /src/usr/isteps | |
parent | 02eeaa234cffc6463b27b68d8eef908aec30327d (diff) | |
download | talos-hostboot-9ce9b2574c96f93d6795c65d6b71f66bc3c95a4e.tar.gz talos-hostboot-9ce9b2574c96f93d6795c65d6b71f66bc3c95a4e.zip |
Some TODO cleanup in istep 8
Changed the TODO's to point to the Cumulus story for
related changes there and to the appropriate post-PON
stories for the other non-critical work.
Change-Id: Ib53319044fb203d457a44c6ae63c6ee1290b7c1b
RTC: 134078
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/24385
Tested-by: Jenkins Server
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: FSP CI Jenkins
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com>
Diffstat (limited to 'src/usr/isteps')
4 files changed, 12 insertions, 15 deletions
diff --git a/src/usr/isteps/istep08/call_host_slave_sbe_config.C b/src/usr/isteps/istep08/call_host_slave_sbe_config.C index e77133eb6..ced8e3dd5 100644 --- a/src/usr/isteps/istep08/call_host_slave_sbe_config.C +++ b/src/usr/isteps/istep08/call_host_slave_sbe_config.C @@ -98,7 +98,7 @@ errlHndl_t set_proc_boot_voltage_vid() targetService().end(), &l_procs ); - //@TODO: RTC:133836 add this get ATTR + //@TODO: RTC:153745 add this get ATTR /* ATTR_BOOT_FREQ_MHZ_type l_boot_freq_mhz = l_pTopLevelTarget->getAttr<ATTR_BOOT_FREQ_MHZ>(); @@ -145,9 +145,6 @@ void* call_host_slave_sbe_config(void *io_pArgs) TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "call_host_slave_sbe_config entry" ); - //@TODO RTC:134078 - // execute proc_read_nest_freq.C //NOTE: Is this needed? Not documented - // execute p9_setup_sbe_config.C for non-primary processor targets TARGETING::TargetHandleList l_cpuTargetList; getAllChips(l_cpuTargetList, TYPE_PROC); @@ -220,14 +217,14 @@ void* call_host_slave_sbe_config(void *io_pArgs) targetService().getTopLevelTarget(l_sys); assert( l_sys != NULL ); - //@TODO: RTC:133836 Add this set ATTR call + //@TODO: RTC:153745 Add this set ATTR call //TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace, "Enabling SBE interrupt for OP systems"); //l_sys->setAttr<ATTR_FORCE_SKIP_SBE_MASTER_INTR_SERVICE>(0); } // Resolve the side characteristics of the Processor SBE Seeproms #if 0 - //@TODO-RTC:142091 + //@TODO-RTC:138226 errlHndl_t err = SBE::resolveProcessorSbeSeeproms(); if ( err ) { diff --git a/src/usr/isteps/istep08/call_proc_abus_scominit.C b/src/usr/isteps/istep08/call_proc_abus_scominit.C index aa789e016..7d5c464cd 100644 --- a/src/usr/isteps/istep08/call_proc_abus_scominit.C +++ b/src/usr/isteps/istep08/call_proc_abus_scominit.C @@ -136,7 +136,7 @@ void* call_proc_abus_scominit( void *io_pArgs ) TARGETING::get_huid(l_thisAbusTarget), TARGETING::get_huid(l_connectedAbusTarget)); - //@TODO RTC:134078 + //@TODO RTC:144076 //FAPI_INVOKE_HWP(l_err, p9_io_abus_scominit, // l_thisAbusFapi2Target, // l_connectedAbusFapi2Target); diff --git a/src/usr/isteps/istep08/call_proc_cen_ref_clk_enable.C b/src/usr/isteps/istep08/call_proc_cen_ref_clk_enable.C index bdf1b63f1..d418a693e 100644 --- a/src/usr/isteps/istep08/call_proc_cen_ref_clk_enable.C +++ b/src/usr/isteps/istep08/call_proc_cen_ref_clk_enable.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2015 */ +/* Contributors Listed Below - COPYRIGHT 2015,2016 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -115,15 +115,15 @@ void* call_proc_cen_ref_clk_enable(void *io_pArgs ) if( l_membufsAttached ) { - /* @TODO RTC:134078 use fapi2 targets - fapi::Target l_fapiProcTarget( fapi::TARGET_TYPE_PROC_CHIP, - *l_proc_iter ); - */ + // Cumulus only + // @TODO RTC:144076 + //fapi::Target l_fapiProcTarget( fapi::TARGET_TYPE_PROC_CHIP, + // *l_proc_iter ); // Invoke the HWP passing in the proc target and // a bit mask indicating connected centaurs // Cumulus only - //@TODO RTC:134078 + //@TODO RTC:144076 //FAPI_INVOKE_HWP(l_errl, // p9_proc_cen_ref_clk_enable, // l_fapiProcTarget, l_membufsAttached ); diff --git a/src/usr/isteps/istep08/call_proc_enable_osclite.C b/src/usr/isteps/istep08/call_proc_enable_osclite.C index dd7e0d45a..d9bd03bc1 100644 --- a/src/usr/isteps/istep08/call_proc_enable_osclite.C +++ b/src/usr/isteps/istep08/call_proc_enable_osclite.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2015 */ +/* Contributors Listed Below - COPYRIGHT 2015,2016 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -80,7 +80,7 @@ void* call_proc_enable_osclite(void *io_pArgs) TRACDCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "call_proc_enable_osclite" ); - //@TODO RTC:134078 + //@TODO RTC:144076 //call p9_enable_osclite //Cumulus only //FAPI_INVOKE_HWP(l_errl,p9_enable_osclite); |