summaryrefslogtreecommitdiffstats
path: root/src/usr/i2c/i2c.C
diff options
context:
space:
mode:
authorMatthew Raybuck <matthew.raybuck@ibm.com>2019-03-21 13:45:56 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2019-03-22 10:39:20 -0500
commitc3264eed4874d5b40ed089da86ba128f8c8f9b82 (patch)
treeabffdddc72fdbcdef20a15cb4f01256d1ea68cc0 /src/usr/i2c/i2c.C
parentb8cfbb22598c993d17a62f4f4705d4fa80b45f7d (diff)
downloadtalos-hostboot-c3264eed4874d5b40ed089da86ba128f8c8f9b82.tar.gz
talos-hostboot-c3264eed4874d5b40ed089da86ba128f8c8f9b82.zip
Add minor tweaks to I2C Callouts for UCD
Adds some comments and collects traces for Ucd Errors. Change-Id: I431684a2ff2f5466bd6f9f917e902ffc45809d7d RTC:205982 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/74854 Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/i2c/i2c.C')
-rwxr-xr-xsrc/usr/i2c/i2c.C7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/usr/i2c/i2c.C b/src/usr/i2c/i2c.C
index 5cf3944e5..7f696c4e6 100755
--- a/src/usr/i2c/i2c.C
+++ b/src/usr/i2c/i2c.C
@@ -5617,8 +5617,9 @@ void addHwCalloutsI2c(errlHndl_t i_err,
HWAS::SRCI_PRIORITY_HIGH);
}
// For FSP systems which don't yet have special handling for
- // i2c device callouts we still need to handle the TPM search
- // to avoid regression back to the "non TPM aware" behavior.
+ // i2c device callouts we still need to handle the TPM and UCD
+ // search to avoid regression back to the "non TPM aware" and
+ // "non UCD aware" behavior.
else
{
// Loop thru TPMs in the system and match physical path,
@@ -5655,6 +5656,8 @@ void addHwCalloutsI2c(errlHndl_t i_err,
}
}
+ // Right now we are assuming that we never have a UCD on the same bus
+ // as a TPM
if (!l_devFound)
{
// Loop thru the UCDs in the system and match physical path,
OpenPOWER on IntegriCloud