Zeppelin BUP updates

- targeting: skip over ATTR_BAD_DQ_BITMAP during fapi attriubte dump
             as it is not looked up correctly for cumulus.
             Need to add it back in future.
- istep changes:
    - remove p9_throttle_sync from istep 13, it is already getting
      called in istep 14
    - add support for memdiags on cumulus
- centaur pibrc errors: mask out PROTECTION_BIT for centaur scoms as it is
                        irrelevant for centaurs
- configureHbrtHypIds: correctly setup DMI information

Change-Id: Ifeaca2f58e16b7ecac9e1329409b98bc6a2f38e7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49382
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Thomas R. Sand <trsand@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>

2 files changed, 7 insertions, 16 deletions

diff --git a/src/usr/fapi2/attribute_service.C b/src/usr/fapi2/attribute_service.C
index 5b4aa93b0..2bd43d2e4 100644
--- a/src/usr/fapi2/attribute_service.C
+++ b/src/usr/fapi2/attribute_service.C
@@ -588,16 +588,6 @@ ReturnCode __getMcsAndPortSlct( const Target<TARGET_TYPE_DIMM>& i_fapiDimm,
                 break;
             }
 
-            // Get the MCS.
-            TARGETING::TargetHandleList l_memBufList;
-            getParentAffinityTargets( l_memBufList, l_port,
-                TARGETING::CLASS_CHIP, TARGETING::TYPE_MEMBUF );
-
-            TARGETING::TargetHandleList l_mcsList;
-            getParentAffinityTargets( l_mcsList, l_memBufList[0],
-                TARGETING::CLASS_UNIT, TARGETING::TYPE_MCS );
-            o_mcsTarget = l_mcsList[0];
-
         }
         // If the proc is Nimbus, we need to get the MCA.
         else
@@ -1684,9 +1674,6 @@ ReturnCode platGetMBvpdAttr(
                            const size_t i_valSize
                            )
 {
-    FAPI_INF("platGetMBvpdAttr: Enter");
-    FAPI_INF("platGetMBvpdAttr: Attr: 0x%08X", i_attr);
-
     ReturnCode rc;
     constexpr bool hbSwError{true};
 
diff --git a/src/usr/fapi2/plat_attr_override_sync.C b/src/usr/fapi2/plat_attr_override_sync.C
index e978dbb39..e96e9f080 100644
--- a/src/usr/fapi2/plat_attr_override_sync.C
+++ b/src/usr/fapi2/plat_attr_override_sync.C
@@ -787,9 +787,13 @@ void AttrOverrideSync::triggerAttrSync(fapi2::TargetType i_type,
 
         for(size_t i = 0; i < l_elems; i++)
         {
+            //#@TODO RTC: 182602 -- Need to scrub through attributes for dimm target
+            //For now, just skipping over BAD_DQ_BITMAP as it does not have a valid
+            //lookup for cumulus
             //Look for specific ATTR
-            if((i_attrHash!= 0x0) &&  //looking for specific ATTR
-               (i_attrHash != l_attrs[i].iv_attrId))
+            if(((i_attrHash!= 0x0) &&  //looking for specific ATTR
+               (i_attrHash != l_attrs[i].iv_attrId)) ||
+               (l_attrs[i].iv_attrId == fapi2::ATTR_BAD_DQ_BITMAP))
             {
                 continue;
             }
@@ -806,7 +810,7 @@ void AttrOverrideSync::triggerAttrSync(fapi2::TargetType i_type,
             if(l_bytes > KILOBYTE)
             {
                 FAPI_INF("triggerAttrSync: ATTR %x bigger [%x] than 1K... skipping",
-                         l_bytes);
+                         l_attrs[i].iv_attrId, l_bytes);
                 continue;
             }
             l_buf = reinterpret_cast<uint8_t *>(realloc(l_buf, l_bytes));