diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2018-08-16 15:08:23 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-08-16 19:03:29 -0500 |
| commit | 6bf123e83d18d4ac06c37ab6a58482d749d3b31a (patch) | |
| tree | 176e15e48dc71859c7798e5fafb0a93e49efec0c /src/usr/fapi2 | |
| parent | f70518cf12dcb1ade112bfe5b6c36c6d9978794c (diff) | |
| download | talos-hostboot-6bf123e83d18d4ac06c37ab6a58482d749d3b31a.tar.gz talos-hostboot-6bf123e83d18d4ac06c37ab6a58482d749d3b31a.zip | |
Remove double free from WOF lookup in HBRT
The recent change to use a stored lid image instead of allocating
space missed where we tried to free the data.
Change-Id: I780a6576019e6904ac31b50fd02d955e7e651e11
CQ: SW442669
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64693
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/fapi2')
| -rw-r--r-- | src/usr/fapi2/plat_wof_access.C | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/usr/fapi2/plat_wof_access.C b/src/usr/fapi2/plat_wof_access.C index f4a6313c8..bd58fb01a 100644 --- a/src/usr/fapi2/plat_wof_access.C +++ b/src/usr/fapi2/plat_wof_access.C @@ -631,11 +631,7 @@ fapi2::ReturnCode platParseWOFTables(uint8_t* o_wofData) // Free the wof tables memory if(l_pWofImage != nullptr) { -#ifdef __HOSTBOOT_RUNTIME - free(l_pWofImage); - l_pWofImage = nullptr; - -#else +#ifndef __HOSTBOOT_RUNTIME errlHndl_t l_tmpErr = nullptr; // Release the memory we may still have allocated and set the // permissions to prevent further access to it |
