diff options
author | Mark Wenning <wenning@us.ibm.com> | 2011-09-30 15:09:57 -0500 |
---|---|---|
committer | Mark W. Wenning <wenning@us.ibm.com> | 2011-11-01 10:58:00 -0500 |
commit | 14cd4e689a68a7440309090d0a6f82d25f8b6984 (patch) | |
tree | 92210b10941c76565af27bc9a5b68502b89daac4 /src/usr/errl/errlentry.C | |
parent | beb8da45e9ad11796185bfb99f47fce35a090f9e (diff) | |
download | talos-hostboot-14cd4e689a68a7440309090d0a6f82d25f8b6984.tar.gz talos-hostboot-14cd4e689a68a7440309090d0a6f82d25f8b6984.zip |
RTC3964: ErrorLog User Data Parser
- created
- add unittest for FILENAME
- add unittest for StackTrace
- still need to handle x86 (mini-errl) side
- post-review changes
- Monte's suggestions
- Thi's suggestions
- remove appendToLog() - combine with addToLog()
- fix merge error - fsi was in both BASE and EXTENDED
Change-Id: I863aae9f75aad5d576e839a9ef3099af6943982b
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/429
Tested-by: Jenkins Server
Reviewed-by: Mark W. Wenning <wenning@us.ibm.com>
Diffstat (limited to 'src/usr/errl/errlentry.C')
-rw-r--r-- | src/usr/errl/errlentry.C | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/usr/errl/errlentry.C b/src/usr/errl/errlentry.C index fc171fbfc..902d43544 100644 --- a/src/usr/errl/errlentry.C +++ b/src/usr/errl/errlentry.C @@ -38,6 +38,7 @@ #include <trace/interface.H> #include <arch/ppc.H> + namespace ERRORLOG { @@ -60,6 +61,7 @@ ErrlEntry::ErrlEntry(const errlSeverity_t i_sev, iv_termState(TERM_STATE_UNKNOWN) { + } @@ -131,8 +133,6 @@ void ErrlEntry::appendToFFDC(ErrlUD * i_pErrlUD, } - - /////////////////////////////////////////////////////////////////////////////// // Return a Boolean indication of success. @@ -143,8 +143,8 @@ bool ErrlEntry::collectTrace(const char i_name[], const uint32_t i_max) do { // By passing nil arguments, obtain the size of the buffer. - uint64_t l_cbFull = TRACE::Trace::getTheInstance().getBuffer( i_name, - NULL, + uint64_t l_cbFull = TRACE::Trace::getTheInstance().getBuffer( i_name, + NULL, 0 ); if( 0 == l_cbFull ) { @@ -153,14 +153,14 @@ bool ErrlEntry::collectTrace(const char i_name[], const uint32_t i_max) break; } - if( 0 == i_max ) + if( 0 == i_max ) { // Full trace buffer desired. Allocate the buffer. char l_traceBuffer[ l_cbFull ]; // Get the data into the buffer. - TRACE::Trace::getTheInstance().getBuffer( i_name, - l_traceBuffer, + TRACE::Trace::getTheInstance().getBuffer( i_name, + l_traceBuffer, l_cbFull ); // Save the trace buffer as a UD section on this. @@ -170,7 +170,7 @@ bool ErrlEntry::collectTrace(const char i_name[], const uint32_t i_max) ERRL_UDV_DEFAULT_VER_1, ERRL_UDT_TRACE ); - // Add the trace section to the vector of sections + // Add the trace section to the vector of sections // for this error log. iv_SectionVector.push_back( l_udSection ); |