diff options
author | Zane Shelley <zshelle@us.ibm.com> | 2018-10-10 16:39:18 -0500 |
---|---|---|
committer | Zane C. Shelley <zshelle@us.ibm.com> | 2018-10-15 09:43:20 -0500 |
commit | bbd4b6cad45526c100e49c29523339034f5f2651 (patch) | |
tree | 110dc9faf5f2ec82095bd0f0715527a05c4c33a7 /src/usr/diag/prdf | |
parent | e0d09f462610961d419ad90ff78b4ea33e1772ee (diff) | |
download | talos-hostboot-bbd4b6cad45526c100e49c29523339034f5f2651.tar.gz talos-hostboot-bbd4b6cad45526c100e49c29523339034f5f2651.zip |
PRD: removed default resolution due to problems with CS filter
Change-Id: If364223cfe77aa6283915332eabbf1394ee64bc9
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67319
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67419
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/usr/diag/prdf')
-rwxr-xr-x | src/usr/diag/prdf/common/framework/resolution/prdfResolutionMap.C | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/src/usr/diag/prdf/common/framework/resolution/prdfResolutionMap.C b/src/usr/diag/prdf/common/framework/resolution/prdfResolutionMap.C index bfa857227..3da0d9a68 100755 --- a/src/usr/diag/prdf/common/framework/resolution/prdfResolutionMap.C +++ b/src/usr/diag/prdf/common/framework/resolution/prdfResolutionMap.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2017 */ +/* Contributors Listed Below - COPYRIGHT 2012,2018 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -253,7 +253,9 @@ int32_t ResolutionMap::LookUp( ResolutionList & o_list, BitKey & io_bitList, STEP_CODE_DATA_STRUCT & scd ) { + /* See note below uint32_t lsize = o_list.size(); + */ int32_t l_rc = SUCCESS; if(iv_filter != NULL) @@ -295,6 +297,13 @@ int32_t ResolutionMap::LookUp( ResolutionList & o_list, o_list.push_back( i->iv_res ); } } + + /* There are several cases in our filtering where we may get to a register + * and find nothing at attention. For example, the only active bit can't be + * blamed as the root cause of a checkstop. In this case, we don't want the + * default resolution. Otherwise, we will have erroneous callouts. I am + * going to leave this code here now, just in case, but eventually it should + * be removed once we have proved there are not adverse side effects. // we didn't find anything to add, so use default if( lsize == o_list.size() ) { @@ -312,6 +321,7 @@ int32_t ResolutionMap::LookUp( ResolutionList & o_list, o_list.push_back( defaultRes ); } } + */ if( iv_filter != NULL ) { |