PRD: remove assert for debug purposes

Change-Id: I2db9d5868e7f38f06719c0c47850032bd10ef298
CQ: SW400798
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45531
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>

1 files changed, 19 insertions, 6 deletions

diff --git a/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.C b/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.C
index 4dc2dc7e3..d37793455 100644
--- a/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.C
+++ b/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.C
@@ -67,7 +67,17 @@ uint32_t MemTdCtlr<T>::handleCmdComplete( STEP_CODE_DATA_STRUCT & io_sc )
 
         #else // IPL only
 
-        PRDF_ASSERT( isInMdiaMode() ); // MDIA must be running.
+        // TODO: RTC 179251 asserting here doesn't give us enough FFDC to debug
+        //       why we got this erroneous attention. Eventually, we will want
+        //       to add the capture data to the assert error log. Until then
+        //       exit with a bad RC and make the error log predictive.
+        // PRDF_ASSERT( isInMdiaMode() ); // MDIA must be running.
+        if ( !isInMdiaMode() )
+        {
+            PRDF_ERR( PRDF_FUNC "IPL cmd complete attn outside of MDIA" );
+            o_rc = FAIL;
+            break;
+        }
 
         // Inform MDIA the command has completed and PRD is starting analysis.
         o_rc = mdiaSendEventMsg( iv_chip->getTrgt(), MDIA::RESET_TIMER );
@@ -137,11 +147,14 @@ uint32_t MemTdCtlr<T>::handleCmdComplete( STEP_CODE_DATA_STRUCT & io_sc )
 
         #ifndef __HOSTBOOT_RUNTIME // IPL only
 
-        // Tell MDIA to skip further analysis on this target.
-        uint32_t l_rc = mdiaSendEventMsg( iv_chip->getTrgt(),
-                                          MDIA::STOP_TESTING );
-        if ( SUCCESS != l_rc )
-            PRDF_ERR( PRDF_FUNC "mdiaSendEventMsg(STOP_TESTING) failed" );
+        if ( isInMdiaMode() )
+        {
+            // Tell MDIA to skip further analysis on this target.
+            uint32_t l_rc = mdiaSendEventMsg( iv_chip->getTrgt(),
+                                              MDIA::STOP_TESTING );
+            if ( SUCCESS != l_rc )
+                PRDF_ERR( PRDF_FUNC "mdiaSendEventMsg(STOP_TESTING) failed" );
+        }
 
         #endif
     }