diff options
author | Zane Shelley <zshelle@us.ibm.com> | 2017-01-30 14:52:53 -0600 |
---|---|---|
committer | Zane C. Shelley <zshelle@us.ibm.com> | 2017-01-30 17:57:58 -0500 |
commit | 7839e4d093507f8b35679183e6678324272e2fb3 (patch) | |
tree | 404d19492dd1071594167b2d3c3271644a92f2e7 /src/usr/diag/mdia | |
parent | 034c91ca4d89036a70048df45453b12c4b446db7 (diff) | |
download | talos-hostboot-7839e4d093507f8b35679183e6678324272e2fb3.tar.gz talos-hostboot-7839e4d093507f8b35679183e6678324272e2fb3.zip |
MDIA: Bumped MDIA timeout value becasue of Nimbus DD1.0 workaround
Change-Id: I9b5e6d711e6c3a1ad2b7a40a0b829145619e25f7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35604
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Tested-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Diffstat (limited to 'src/usr/diag/mdia')
-rw-r--r-- | src/usr/diag/mdia/mdiasm.C | 23 | ||||
-rw-r--r-- | src/usr/diag/mdia/mdiasm.H | 9 |
2 files changed, 17 insertions, 15 deletions
diff --git a/src/usr/diag/mdia/mdiasm.C b/src/usr/diag/mdia/mdiasm.C index f91224552..ef5835123 100644 --- a/src/usr/diag/mdia/mdiasm.C +++ b/src/usr/diag/mdia/mdiasm.C @@ -403,8 +403,8 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs) // Committing an info log to help debug SW timeout if((*wit)->timeoutCnt >= MAINT_CMD_TIMEOUT_LOG) { - MDIA_FAST("sm: committing a SW timed out info log " - "for %x", get_huid(target)); + MDIA_FAST("sm: committing a SW timeout info log " + "for HUID:0x%08X", get_huid(target)); /*@ * @errortype @@ -435,9 +435,10 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs) (*wit)->timeoutCnt++; } - MDIA_FAST("sm: work item %d reset SW timed out on: %x, " - "timeoutCnt: %d", *((*wit)->workItem), - get_huid(target), (*wit)->timeoutCnt); + MDIA_FAST("sm: work item %d reset SW timed out on " + "HUID:0x%08X, timeoutCnt: %d", + *((*wit)->workItem), get_huid(target), + (*wit)->timeoutCnt); // register a new timeout monitor uint64_t monitorId = getMonitor().addMonitor(MAINT_CMD_TIMEOUT); @@ -472,7 +473,7 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs) HWAS::GARD_NULL); // If maint cmd complete bit is not on, time out - MDIA_FAST("sm: stopping command: %p", target); + MDIA_FAST("sm: stopping command HUID:0x%08X", get_huid(target)); //target type is MBA if ( TYPE_MBA == trgtType ) { @@ -535,10 +536,8 @@ void StateMachine::processCommandTimeout(const MonitorIDs & i_monitorIDs) wkflprop = *wit; // log a timeout event - MDIA_ERR("sm: command %p: %d HW timed out on: %x", - target, - *((*wit)->workItem), - get_huid(target)); + MDIA_ERR("sm: workItem %d HW timeout on HUID:0x%08X", + *((*wit)->workItem), get_huid(target)); errlCommit(timeoutErrl, MDIA_COMP_ID); @@ -746,7 +745,7 @@ bool StateMachine::scheduleWorkItem(WorkFlowProperties & i_wfp) TargetHandle_t target = getTarget(i_wfp); - MDIA_FAST("sm: dispatching work item %d for: %p, priority: %d, " + MDIA_FAST("sm: dispatching work item %d for: 0x%08x, priority: %d, " "unit: %d", *i_wfp.workItem, get_huid(target), priority, @@ -802,7 +801,7 @@ bool StateMachine::executeWorkItem(WorkFlowProperties * i_wfp) uint64_t workItem = *i_wfp->workItem; - MDIA_FAST("sm: executing work item %d for: %x", + MDIA_FAST("sm: executing work item %d for: 0x%08x", workItem, get_huid(getTarget(*i_wfp))); mutex_unlock(&iv_mutex); diff --git a/src/usr/diag/mdia/mdiasm.H b/src/usr/diag/mdia/mdiasm.H index 4c6a7b49b..5a304c1aa 100644 --- a/src/usr/diag/mdia/mdiasm.H +++ b/src/usr/diag/mdia/mdiasm.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2016 */ +/* Contributors Listed Below - COPYRIGHT 2012,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -41,8 +41,11 @@ namespace MDIA { -//MBA timeout value - 30 secs -static const uint64_t MAINT_CMD_TIMEOUT = 30000000000; +// HW timeout value - 30 secs +// Nimbus DD1.0 has a workaround that will go over 30 seconds. Will need to bump +// it up for now. May consider lowering it later, but only if there is a +// problem. +static const uint64_t MAINT_CMD_TIMEOUT = 30000000000 * 10; //Longer MBA timeout to be used when continuous tracing is enabled - 30 min static const uint64_t MAINT_CMD_TIMEOUT_LONG = 1800000000000; |