diff options
| author | Andrew Jeffery <andrewrj@au1.ibm.com> | 2018-09-17 17:23:04 +0930 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-10-02 14:36:19 -0500 |
| commit | 8a4663c131e113ac85337a55ba72ce9e1688ec49 (patch) | |
| tree | 6f8862c726a1cb4f6c0ceb46f395ac4cefb43309 /src/runtime | |
| parent | 506a20f3bb46ce2033719354fdf7d8c3f146985e (diff) | |
| download | talos-hostboot-8a4663c131e113ac85337a55ba72ce9e1688ec49.tar.gz talos-hostboot-8a4663c131e113ac85337a55ba72ce9e1688ec49.zip | |
assert: Include file name in assert output
Printing the line number without an associated file is almost
meaningless; add the file name to improve debug ergonomics.
Change-Id: I454876ccc567cb58066362caced7efbaf92cfe62
Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66117
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/rt_assert.C | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/runtime/rt_assert.C b/src/runtime/rt_assert.C index a22fe461a..ea19030f1 100644 --- a/src/runtime/rt_assert.C +++ b/src/runtime/rt_assert.C @@ -5,7 +5,9 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* COPYRIGHT International Business Machines Corp. 2013,2014 */ +/* Contributors Listed Below - COPYRIGHT 2013,2018 */ +/* [+] International Business Machines Corp. */ +/* */ /* */ /* Licensed under the Apache License, Version 2.0 (the "License"); */ /* you may not use this file except in compliance with the License. */ @@ -28,12 +30,13 @@ /** Hook location for trace module to set up when loaded. */ namespace TRACE { void (*traceCallback)(void*, size_t) = NULL; }; -extern "C" void __assert(AssertBehavior i_assertb, int i_line) +extern "C" void __assert(AssertBehavior i_assertb, const char* i_file, + int i_line) { if (i_assertb != ASSERT_TRACE_DONE) { - printk("Assertion failed @%p on line %d.\n", - linkRegister(), i_line); + printk("Assertion failed @%p on line %s:%d.\n", + linkRegister(), i_file, i_line); } g_hostInterfaces->assert(); |
