Clean up potential uninitialized object instances.

Change-Id: I859f94234d5672f55f745dd37b9662c310b694a7
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4236
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

6 files changed, 76 insertions, 82 deletions

diff --git a/src/kernel/block.C b/src/kernel/block.C
index c33529963..7cd7e75af 100644
--- a/src/kernel/block.C
+++ b/src/kernel/block.C
@@ -66,7 +66,7 @@ void Block::init(MessageQueue* i_msgQ, uint64_t *i_spteAddr)
     if (i_spteAddr == NULL)
     {
         // Create a shadow PTE for each page.
-        iv_ptes = new ShadowPTE[iv_size / PAGESIZE];
+        iv_ptes = new ShadowPTE[iv_size / PAGESIZE]();
     }
     else // set the page table to reside at the address requested
     {
diff --git a/src/kernel/exception.C b/src/kernel/exception.C
index 80e04fc34..c82bfec98 100644
--- a/src/kernel/exception.C
+++ b/src/kernel/exception.C
@@ -199,8 +199,7 @@ void kernel_execute_fp_unavail()
     {
         // Enable FP by creating a FP context.
         // Context switch code will handle the rest.
-        t->fp_context = new context_fp_t;
-        memset(t->fp_context, '\0', sizeof(context_fp_t));
+        t->fp_context = new context_fp_t();
     }
 }
 
diff --git a/src/kernel/misc.C b/src/kernel/misc.C
index 9fd511c33..e280a1527 100644
--- a/src/kernel/misc.C
+++ b/src/kernel/misc.C
@@ -179,8 +179,7 @@ namespace KernelMisc
         CpuManager::deactivateCPU(cpu);
 
         // Create kernel save area and store ptr in bottom of kernel stack.
-        task_t* saveArea = new task_t;
-        memset(saveArea, '\0', sizeof(task_t));
+        task_t* saveArea = new task_t();
         saveArea->context.msr_mask = 0xD030; // EE, ME, PR, IR, DR.
         *(reinterpret_cast<task_t**>(cpu->kernel_stack_bottom)) = saveArea;
 
@@ -251,8 +250,7 @@ namespace KernelMisc
         CpuManager::deactivateCPU(cpu);
 
         // Create kernel save area and store ptr in bottom of kernel stack.
-        task_t* saveArea = new task_t;
-        memset(saveArea, '\0', sizeof(task_t));
+        task_t* saveArea = new task_t();
         saveArea->context.msr_mask = 0xD030; // EE, ME, PR, IR, DR.
         *(reinterpret_cast<task_t**>(cpu->kernel_stack_bottom)) = saveArea;
 
diff --git a/src/kernel/msghandler.C b/src/kernel/msghandler.C
index 7761d36ae..4530ed6b6 100644
--- a/src/kernel/msghandler.C
+++ b/src/kernel/msghandler.C
@@ -1,26 +1,25 @@
-/*  IBM_PROLOG_BEGIN_TAG
- *  This is an automatically generated prolog.
- *
- *  $Source: src/kernel/msghandler.C $
- *
- *  IBM CONFIDENTIAL
- *
- *  COPYRIGHT International Business Machines Corp. 2011-2012
- *
- *  p1
- *
- *  Object Code Only (OCO) source materials
- *  Licensed Internal Code Source Materials
- *  IBM HostBoot Licensed Internal Code
- *
- *  The source code for this program is not published or other-
- *  wise divested of its trade secrets, irrespective of what has
- *  been deposited with the U.S. Copyright Office.
- *
- *  Origin: 30
- *
- *  IBM_PROLOG_END_TAG
- */
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/kernel/msghandler.C $                                     */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2011,2013              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 #include <assert.h>
 #include <errno.h>
 #include <util/locked/queue.H>
@@ -38,7 +37,7 @@ void MessageHandler::sendMessage(msg_sys_types_t i_type, void* i_key,
     task_t* ready_task = NULL;
 
     // Save pending info for when we get the response.
-    MessageHandler_Pending* mhp = new MessageHandler_Pending;
+    MessageHandler_Pending* mhp = new MessageHandler_Pending();
     mhp->key = i_key;
     mhp->task = i_task;
 
@@ -53,7 +52,7 @@ void MessageHandler::sendMessage(msg_sys_types_t i_type, void* i_key,
     if (!iv_pending.find(i_key))
     {
         // Create message.
-        msg_t* m = new msg_t;
+        msg_t* m = new msg_t();
         m->type = i_type;
         m->data[0] = reinterpret_cast<uint64_t>(i_key);
         m->data[1] = reinterpret_cast<uint64_t>(i_data);
diff --git a/src/kernel/taskmgr.C b/src/kernel/taskmgr.C
index 2ff6ce4ad..6a4850fec 100644
--- a/src/kernel/taskmgr.C
+++ b/src/kernel/taskmgr.C
@@ -1,25 +1,25 @@
-//  IBM_PROLOG_BEGIN_TAG
-//  This is an automatically generated prolog.
-//
-//  $Source: src/kernel/taskmgr.C $
-//
-//  IBM CONFIDENTIAL
-//
-//  COPYRIGHT International Business Machines Corp. 2010 - 2011
-//
-//  p1
-//
-//  Object Code Only (OCO) source materials
-//  Licensed Internal Code Source Materials
-//  IBM HostBoot Licensed Internal Code
-//
-//  The source code for this program is not published or other-
-//  wise divested of its trade secrets, irrespective of what has
-//  been deposited with the U.S. Copyright Office.
-//
-//  Origin: 30
-//
-//  IBM_PROLOG_END
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/kernel/taskmgr.C $                                        */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2010,2013              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 #include <util/singleton.H>
 #include <kernel/taskmgr.H>
 #include <kernel/task.H>
@@ -86,8 +86,7 @@ task_t* TaskManager::_createIdleTask()
 task_t* TaskManager::_createTask(TaskManager::task_fn_t t,
 				 void* p, bool withStack, bool kernelParent)
 {
-    task_t* task = new task_t;
-    memset(task, '\0', sizeof(task_t));
+    task_t* task = new task_t();
 
     task->tid = this->getNextTid();
 
@@ -127,7 +126,7 @@ task_t* TaskManager::_createTask(TaskManager::task_fn_t t,
     task->state_info = NULL;
 
     // Create tracker instance for this task.
-    task_tracking_t* tracker = new task_tracking_t;
+    task_tracking_t* tracker = new task_tracking_t();
     tracker->key = task->tid;
     tracker->task = task;
     tracker->status = -1;
@@ -293,7 +292,7 @@ void TaskManager::_waitTask(task_t* t, int64_t tid, int* status, void** retval)
         }
         else // Otherwise, create wait-info to defer task.
         {
-            task_wait_t* tj = t->tracker->wait_info = new task_wait_t;
+            task_wait_t* tj = t->tracker->wait_info = new task_wait_t();
             tj->tid = tid;
             tj->status = status;
             tj->retval = retval;
diff --git a/src/kernel/timemgr.C b/src/kernel/timemgr.C
index 32ffa4a68..fd4c55853 100644
--- a/src/kernel/timemgr.C
+++ b/src/kernel/timemgr.C
@@ -1,26 +1,25 @@
-/*  IBM_PROLOG_BEGIN_TAG
- *  This is an automatically generated prolog.
- *
- *  $Source: src/kernel/timemgr.C $
- *
- *  IBM CONFIDENTIAL
- *
- *  COPYRIGHT International Business Machines Corp. 2010-2012
- *
- *  p1
- *
- *  Object Code Only (OCO) source materials
- *  Licensed Internal Code Source Materials
- *  IBM HostBoot Licensed Internal Code
- *
- *  The source code for this program is not published or other-
- *  wise divested of its trade secrets, irrespective of what has
- *  been deposited with the U.S. Copyright Office.
- *
- *  Origin: 30
- *
- *  IBM_PROLOG_END_TAG
- */
+/* IBM_PROLOG_BEGIN_TAG                                                   */
+/* This is an automatically generated prolog.                             */
+/*                                                                        */
+/* $Source: src/kernel/timemgr.C $                                        */
+/*                                                                        */
+/* IBM CONFIDENTIAL                                                       */
+/*                                                                        */
+/* COPYRIGHT International Business Machines Corp. 2010,2013              */
+/*                                                                        */
+/* p1                                                                     */
+/*                                                                        */
+/* Object Code Only (OCO) source materials                                */
+/* Licensed Internal Code Source Materials                                */
+/* IBM HostBoot Licensed Internal Code                                    */
+/*                                                                        */
+/* The source code for this program is not published or otherwise         */
+/* divested of its trade secrets, irrespective of what has been           */
+/* deposited with the U.S. Copyright Office.                              */
+/*                                                                        */
+/* Origin: 30                                                             */
+/*                                                                        */
+/* IBM_PROLOG_END_TAG                                                     */
 #include <kernel/timemgr.H>
 #include <kernel/scheduler.H>
 #include <util/singleton.H>
@@ -46,7 +45,7 @@ void TimeManager::init_cpu(cpu_t* cpu)
 
 void TimeManager::_init_cpu(cpu_t* cpu)
 {
-    cpu->delay_list = new delaylist_t;
+    cpu->delay_list = new delaylist_t();
 }
 
 uint64_t TimeManager::convertSecToTicks(uint64_t i_sec, uint64_t i_nsec)