diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2014-01-07 09:30:51 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-01-10 16:19:14 -0600 |
| commit | aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3 (patch) | |
| tree | d6a587a8582ac9d085b08e028c757a0ea94bb825 /src/include/usr | |
| parent | ea2a49ff0cd3827458025f75d5b6bd7054d18779 (diff) | |
| download | talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.tar.gz talos-hostboot-aa83ebd12d6cf6d6ead06e45ab61d46a53a15be3.zip | |
Remove leftover fixme/todo and update error callouts
Remove all untagged fixme/todo comments
Adde new parm to error log constructor to avoid extra code in
common software error case
Update error callouts
Add strncpy
Change-Id: I8bd8f48193a96b79db91ed35c4fd485e6da38dba
RTC: 67921
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/7921
Tested-by: Jenkins Server
Reviewed-by: Michael Baiocchi <baiocchi@us.ibm.com>
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/include/usr')
| -rw-r--r-- | src/include/usr/errl/errlentry.H | 7 | ||||
| -rw-r--r-- | src/include/usr/mbox/ipc_reasoncodes.H | 4 | ||||
| -rw-r--r-- | src/include/usr/mbox/mbox_reasoncodes.H | 3 | ||||
| -rw-r--r-- | src/include/usr/mbox/mboxif.H | 5 | ||||
| -rw-r--r-- | src/include/usr/runtime/tceif.H | 3 |
5 files changed, 16 insertions, 6 deletions
diff --git a/src/include/usr/errl/errlentry.H b/src/include/usr/errl/errlentry.H index d00c9c54a..89369797e 100644 --- a/src/include/usr/errl/errlentry.H +++ b/src/include/usr/errl/errlentry.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2011,2013 */ +/* COPYRIGHT International Business Machines Corp. 2011,2014 */ /* */ /* p1 */ /* */ @@ -118,13 +118,16 @@ public: * in the primary SRC * @param[in] i_user2 64 bits of user data which are placed * in the primary SRC + * @param[in] i_hbSwError if true, will automatically add a HIGH + * severity callout for EPUB_PRC_HB_CODE * @return None */ ErrlEntry(const errlSeverity_t i_sev, const uint8_t i_modId, const uint16_t i_reasonCode, const uint64_t i_user1 = 0, - const uint64_t i_user2 = 0); + const uint64_t i_user2 = 0, + const bool i_hbSwError = false ); /** * @brief Destructor diff --git a/src/include/usr/mbox/ipc_reasoncodes.H b/src/include/usr/mbox/ipc_reasoncodes.H index 1758653e3..df098bf0b 100644 --- a/src/include/usr/mbox/ipc_reasoncodes.H +++ b/src/include/usr/mbox/ipc_reasoncodes.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2013 */ +/* COPYRIGHT International Business Machines Corp. 2013,2014 */ /* */ /* p1 */ /* */ @@ -25,6 +25,8 @@ #include <hbotcompid.H> +#define IPC_TRACE_NAME "IPC" + namespace IPC { enum IPCModuleId diff --git a/src/include/usr/mbox/mbox_reasoncodes.H b/src/include/usr/mbox/mbox_reasoncodes.H index 2bce46660..1c21b52e7 100644 --- a/src/include/usr/mbox/mbox_reasoncodes.H +++ b/src/include/usr/mbox/mbox_reasoncodes.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2012,2013 */ +/* COPYRIGHT International Business Machines Corp. 2012,2014 */ /* */ /* p1 */ /* */ @@ -74,6 +74,7 @@ namespace MBOX enum mboxUserDetailDataSubsection { MBOX_UDT_MBOXMSG_DATA = 0x01, + MBOX_UDT_MSG_DATA = 0x02, //@todo: RTC:93750 }; }; diff --git a/src/include/usr/mbox/mboxif.H b/src/include/usr/mbox/mboxif.H index 8bce7b495..b17fbeb13 100644 --- a/src/include/usr/mbox/mboxif.H +++ b/src/include/usr/mbox/mboxif.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2012,2013 */ +/* COPYRIGHT International Business Machines Corp. 2012,2014 */ /* */ /* p1 */ /* */ @@ -27,6 +27,9 @@ #include <errl/errlentry.H> #include <mbox/mbox_queues.H> +#define MBOX_TRACE_NAME MBOX_COMP_NAME +#define MBOXMSG_TRACE_NAME "MBOXMSG" + namespace MBOX { enum diff --git a/src/include/usr/runtime/tceif.H b/src/include/usr/runtime/tceif.H index 9dcc7ca14..6300d9138 100644 --- a/src/include/usr/runtime/tceif.H +++ b/src/include/usr/runtime/tceif.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2013 */ +/* COPYRIGHT International Business Machines Corp. 2013,2014 */ /* */ /* p1 */ /* */ @@ -28,6 +28,7 @@ #include <errl/errlentry.H> #include <devicefw/userif.H> +#define TCE_TRACE_NAME "TCE" namespace TCE { |
