diff options
author | Ilya Smirnov <ismirno@us.ibm.com> | 2018-02-06 09:07:40 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-08 10:02:12 -0500 |
commit | 4bcfb10e2752b110d79a7a535adccde1ec119c97 (patch) | |
tree | 05c5f73d4dd20656cd77df5732c2fab6f9c85e70 /src/include/usr | |
parent | c9c74dbf7f023c919aaa1a02d2d7a44eaa436939 (diff) | |
download | talos-hostboot-4bcfb10e2752b110d79a7a535adccde1ec119c97.tar.gz talos-hostboot-4bcfb10e2752b110d79a7a535adccde1ec119c97.zip |
Remove Istep 10.3 From IPL Flow
Istep 10.3 (host_set_voltages) has been moved to Istep 8.12
and needs to be no-oped. Executing host_set_voltages twice
causes crashes due to secureboot thinking we are trying to
skip an istep. Note that validateSecuritySettings that was
performed in 10.3 has now been moved to 10.4 (with the required
sub-routines).
Change-Id: I81284157dedebb3f4ee357ce28b29b1dd6a3fe8a
CQ:SW416209
CMVC-Coreq:1044932
Backport: release-fips910
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53443
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr')
-rw-r--r-- | src/include/usr/isteps/istep10list.H | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/src/include/usr/isteps/istep10list.H b/src/include/usr/isteps/istep10list.H index 97f5648bd..d3ef83233 100644 --- a/src/include/usr/isteps/istep10list.H +++ b/src/include/usr/isteps/istep10list.H @@ -36,8 +36,8 @@ * : Integrate P9 Islands into SMP * 10.02 host_slave_sbe_update * : Update slave SBE - * 10.03 host_set_voltages - * : Set correct chip voltages + * 10.03 <empty> + * : * 10.04 proc_cen_ref_clk_enable * : Setup centaur ref clocks * 10.05 proc_enable_osclite @@ -94,16 +94,6 @@ void* call_proc_build_smp( void *io_pArgs ); void* call_host_slave_sbe_update( void *io_pArgs ); /** - * @brief host_set_voltages - * - * param[in,out] - pointer to any arguments, usually NULL - * - * return any error logs to istep - * - */ -void* call_host_set_voltages( void *io_pArgs ); - -/** * @brief proc_cen_ref_clk_enable * * param[in,out] - pointer to any arguments, usually NULL @@ -245,9 +235,9 @@ const TaskInfo g_istep10[] = { { START_FN, EXT_IMAGE, NORMAL_IPL_OP, true } }, { - ISTEPNAME(10,03,"host_set_voltages"), - ISTEP_10::call_host_set_voltages, - { START_FN, EXT_IMAGE, NORMAL_IPL_OP, false } + "", // empty istep + NULL, + { NONE, EXT_IMAGE, IPL_NOOP, false } }, { ISTEPNAME(10,04,"proc_cen_ref_clk_enable"), |