PNORDD Cleanup - sfcinit updates and perf improvements

Cleaning up a number of things under this commit:
-Changed to always assume FSP performed SFC Setup
-Get Erase block size based on what FSP Building Block
   set it to
-Re-ordered some switch to put most likely choice first
-Converted some else/if statements to switch statements
-Added some shutdown calls on error paths.

RTC: 47066
Change-Id: I015bb90b67ead9ad34e2ea1827cc92f7966d3162
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3183
Tested-by: Jenkins Server
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Douglas R. Gilbert <dgilbert@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>

1 files changed, 9 insertions, 1 deletions

diff --git a/src/include/usr/pnor/pnor_reasoncodes.H b/src/include/usr/pnor/pnor_reasoncodes.H
index e580e2242..6e66a89e8 100644
--- a/src/include/usr/pnor/pnor_reasoncodes.H
+++ b/src/include/usr/pnor/pnor_reasoncodes.H
@@ -64,11 +64,19 @@ namespace PNOR
         RC_UNSUPPORTED_OPERATION     = PNOR_COMP_ID | 0x07,
         RC_LPC_ERROR                 = PNOR_COMP_ID | 0x08,
         RC_BAD_STARTUP_RC            = PNOR_COMP_ID | 0x09,
+        //RC_UNSUPORTED_HARDWARE Must have one unique use
+        //   for Shutdown path  
         RC_UNSUPORTED_HARDWARE       = PNOR_COMP_ID | 0x0A,
         RC_MICRON_INCOMPLETE         = PNOR_COMP_ID | 0x0B,
-        //RC_PARTITION_TABLE_INVALID Must be Unique by itself
+        //RC_PARTITION_TABLE_INVALID Must have one unique use
         //   for Shutdown path  
         RC_PARTITION_TABLE_INVALID   = PNOR_COMP_ID | 0x0C,
+        //RC_UNSUPPORTED_MODE can only be used in
+        //   shutdown calls.
+        RC_UNSUPPORTED_MODE          = PNOR_COMP_ID | 0x0D,
+        //RC_UNSUPPORTED_SFCRANGE can only be used in
+        //   shutdown calls.
+        RC_UNSUPPORTED_SFCRANGE      = PNOR_COMP_ID | 0x0E,
     };
 };