diff options
| author | Mike Jones <mjjones@us.ibm.com> | 2014-01-27 15:33:09 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-02-14 12:41:36 -0600 |
| commit | 10a93afdbdd5bccc9a10b797d66b008580ba16bb (patch) | |
| tree | caddb050384fe2eb4cd8844c59a28d9ea9e8b7c0 /src/include/usr/initservice | |
| parent | 5850220077f29041920e83de66ec458dac9c82a7 (diff) | |
| download | talos-hostboot-10a93afdbdd5bccc9a10b797d66b008580ba16bb.tar.gz talos-hostboot-10a93afdbdd5bccc9a10b797d66b008580ba16bb.zip | |
Hostboot Serviceability Review Part 2
Resolving TODOs and ensuring error logs have correct callouts
Change-Id: Ic2e65427487fb91553ffe4ed6e3ed922004963ba
RTC: 92837
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/8374
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/include/usr/initservice')
| -rw-r--r-- | src/include/usr/initservice/initsvcstructs.H | 16 |
1 files changed, 3 insertions, 13 deletions
diff --git a/src/include/usr/initservice/initsvcstructs.H b/src/include/usr/initservice/initsvcstructs.H index 49114e5d5..036369e9c 100644 --- a/src/include/usr/initservice/initsvcstructs.H +++ b/src/include/usr/initservice/initsvcstructs.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2011,2013 */ +/* COPYRIGHT International Business Machines Corp. 2011,2014 */ /* */ /* p1 */ /* */ @@ -149,16 +149,11 @@ struct TaskFlags * - execution flags, see TaskFlags above * */ -/** - * @todo store a pointer to the taskname string here instead of allocating - * 64 bytes for each entry? - */ struct TaskInfo { - const char taskname[VFS_MODULE_NAME_MAX]; + const char * const taskname; void* (*taskfn)(void *ptr); const TaskFlags taskflags; - }; @@ -167,18 +162,13 @@ struct TaskInfo * * Holds information on other modules that need to be loaded so that this * istep will run. - * - * @todo This is a placeholder right now */ struct DepModInfo { - const char modulename[MAX_DEPENDENT_MODULES][VFS_MODULE_NAME_MAX]; - + const char * const modulename[MAX_DEPENDENT_MODULES]; }; - - /** * @struct ExtTaskInfo * |
