diff options
author | Brian Horton <brianh@linux.ibm.com> | 2015-08-19 13:41:30 -0500 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2015-09-03 14:40:03 -0500 |
commit | 0579143faea0a19bd4133ce5179855ec7dc3c9b7 (patch) | |
tree | bb79013be84055a49f57913a8aa814ea20c5d776 /src/include/usr/errl | |
parent | 06e40c4aa3efe6f006dc7971ad58f08f42117ea3 (diff) | |
download | talos-hostboot-0579143faea0a19bd4133ce5179855ec7dc3c9b7.tar.gz talos-hostboot-0579143faea0a19bd4133ce5179855ec7dc3c9b7.zip |
fix issues with dup sel/esel
. call errlmanager ack inline/synchronously, so that we don't have
dup eSELs due to shutdown
. don't resend sensor SEL events for errorlogs read out of PNOR
Depends-On: Ia2b211d8ebf489e92f2bc3d281d92175a6b61f30
Change-Id: I32c8e49ef2e00567987cdf030a225b61e7077cf6
CQ: SW312094
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/19993
Tested-by: Jenkins Server
Tested-by: Jenkins OP Build CI
Tested-by: Jenkins OP HW
Tested-by: FSP CI Jenkins
Reviewed-by: WILLIAM G. HOFFA <wghoffa@us.ibm.com>
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/include/usr/errl')
-rw-r--r-- | src/include/usr/errl/errlmanager.H | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/src/include/usr/errl/errlmanager.H b/src/include/usr/errl/errlmanager.H index 586b42221..be3445007 100644 --- a/src/include/usr/errl/errlmanager.H +++ b/src/include/usr/errl/errlmanager.H @@ -482,9 +482,11 @@ private: * @brief Create an ipmi message with the error log and send it to BMC * * @param[in,out] io_err Error log handle to be committed - * + * @param[in] i_sendSels true if sensor SELs should be sent to BMC, + * false if not (ie, on read from PNOR, do not + * (re)send the SEL to the BMC */ - void sendErrLogToBmc(errlHndl_t &io_err); + void sendErrLogToBmc(errlHndl_t &io_err, bool i_sendSels = true); #endif /** @@ -504,16 +506,17 @@ private: // Note: When adding a new flag, add to the trace in errlogShutdown() enum ERRLOG_FLAGS { - PNOR_FLAG = 0x01, - MBOX_FLAG = 0x02, - ERRLDISP_FLAG = 0x04, - IPMI_FLAG = 0x08, - ALL_FLAGS = PNOR_FLAG | MBOX_FLAG + PNOR_FLAG = 0x01, + MBOX_FLAG = 0x02, + ERRLDISP_FLAG = 0x04, + IPMI_FLAG = 0x08, + IPMI_NOSEL_FLAG = 0x10, + ALL_FLAGS = PNOR_FLAG | MBOX_FLAG #ifdef CONFIG_BMC_IPMI - | IPMI_FLAG + | IPMI_FLAG #endif #ifdef CONFIG_CONSOLE_OUTPUT_ERRORDISPLAY - | ERRLDISP_FLAG + | ERRLDISP_FLAG #endif }; |